Automatic account expiry doesn't happen

Questions about correct functionality:
- when setting/updating site expiry should it update the user expiry of all existing users (maybe not site admins)? or only newly created users?
- should it override existing set expiry for user (or only if less that existing user expiry)?
- should the setting/updating of side expiry notify affected users (email/internal notification)?

My thoughts on how it could work:
- on setting/updating the site expiry it sets/updates relevant table column in database for user expiry to match that way when viewing the accounts setting page the expiry will display as well as the currently working functionality to be adhered to.

I would suggest:

1. when setting/updating site expiry should it update the user expiry of all existing users (maybe not site admins)? or only newly created users?
It should go for all accounts that do not have a specific expiry date set already. Good idea to exclude the site admin from expiry.

2. should it override existing set expiry for user (or only if less that existing user expiry)?
I would not override existing specific expiry dates as someone has set those specifically. If we reset the expiry dates for those that have already been expired, their accounts suddenly become active again which should not be the case. Thus, see 1. Expiry for all accounts that do not have a specific date set.

3. should the setting/updating of side expiry notify affected users (email/internal notification)?
No. There is a second setting which you can activate letting users know when their account is about to expire / be set to inactive.

just discussing this (Bob and Kristina)

As for 1+2:
1. Default setting should go for all new users.
2. In addition, there is a setting (radio button) to update all existing users no matter whether they have an expiry set or not.
3. In addition, there is a radio button to update only existing users who do not already have an expiry date set.
3. Another radio button to not update any existing users because these may be governed by a default expiry rule on institution level already.

https://reviews.mahara.org/#/c/2241/

Hi Bob and Kristina;

How can I set back default account lifetime to 'No end date'.

I suggest the setting 'Override user account lifetime' only shows up when the admin changes the 'Default account lifetime' setting

About the default account inactivity time, I think we should fire another bug.

Reviewed: https://reviews.mahara.org/2241
Committed: http://gitorious.org/mahara/mahara/commit/4919c4e1276c3817e55e9797cc22296a555a8e3e
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 4919c4e1276c3817e55e9797cc22296a555a8e3e
Author: Robert Lyon <email address hidden>
Date: Fri May 24 12:20:43 2013 +1200

Fix for automatic account expiry (Bug #1097565)

Added site options to allow for override of user expiry when
setting site expiry (if the user is not site admin).

- for new users
- for new users and existing users without expiry set
- for all users

Allowing for switching back to 'no end date'.
Need to force refresh the page to display info correctly after save.

Change-Id: I0a772b3db7c2ae5144ed4120cf851d4bba633f66
Signed-off-by: Robert Lyon <email address hidden>

Part of this is bug fix, part is new feature. I tagged it "nominatedfeature" so it gets picked up for the user manual.