German OK and Cancel buttons show ~

Bug #1103495 reported by Björn Michaelsen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
LibreOffice
Fix Released
Medium
libreoffice (Fedora)
Fix Released
Low
libreoffice (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

This would be a release regression 3.5.4->3.5.7 if unfixed

commit 5509b3abdd66b475f7b7b7171614cd925efdb844 in translations changed the translation of OK and Cancel for german to contain ~ to markup the accelerator key. This has the odd result of showing a literal ~ under Unix. See vcl/source/control/button.cxx for the odd code there which is unix-specific to add ~ to the string, resulting in doubled ~

for details see fdo#56281

Revision history for this message
In , Frank (frank-redhat-bugs) wrote :

Created attachment 630377
An picture that show it.

Description of problem:
In the selection window for the printer, the cancel button is named "~Abbrechen" instant of "Abbrechen"

Version-Release number of selected component (if applicable):
libreoffice-langpack-de-3.5.7.2-2.fc17.x86_64

Revision history for this message
In , Caolan (caolan-redhat-bugs) wrote :

grr, looks like its the "OK" and "Cancel" buttons globally are not converting the ~ underline token to the right thing

Revision history for this message
In , Caolan (caolan-redhat-bugs) wrote :

oh huh, updated .de translations added the ~ underline token, but there's a unix-specific extra ~ addition so it ends up duplicated

Revision history for this message
In , Caolanm (caolanm) wrote :

commit 5509b3abdd66b475f7b7b7171614cd925efdb844 in translations changed the translation of OK and Cancel for german to contain ~ to markup the accelerator key. This has the odd result of showing a literal ~ under Unix. See vcl/source/control/button.cxx for the odd code there which is unix-specific to add ~ to the string, resulting in doubled ~

Revision history for this message
In , Libreoffice-bugs (libreoffice-bugs) wrote :

Caolan McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=920807d4491834cd88e545fdb930c9105d58c4cd

Resolves: rhbz#868479 / fdo#56281 doubled ~ in German ok/cancel translations

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

Revision history for this message
In , Caolan (caolan-redhat-bugs) wrote :

will workaround in >= libreoffice-3.5.7.2-3.fc17

Revision history for this message
In , Libreoffice-bugs (libreoffice-bugs) wrote :

Caolan McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-3-6":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=47a8db922ee6980c540c2223be5452bc6b2b2bbb&g=libreoffice-3-6

Resolves: rhbz#868479 / fdo#56281 doubled ~ in German ok/cancel translations

It will be available in LibreOffice 3.6.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

Revision history for this message
In , Libreoffice-bugs (libreoffice-bugs) wrote :

Caolan McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-3-5":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1141d04daea3a0091c2d7533018dbe17e5b5a8bd&g=libreoffice-3-5

Resolves: rhbz#868479 / fdo#56281 doubled ~ in German ok/cancel translations

It will be available in LibreOffice 3.5.8.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

Revision history for this message
In , Fedora (fedora-redhat-bugs) wrote :

libreoffice-3.6.3.1-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/libreoffice-3.6.3.1-3.fc18

Revision history for this message
In , Fedora (fedora-redhat-bugs) wrote :

libreoffice-3.5.7.2-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/libreoffice-3.5.7.2-3.fc17

Revision history for this message
In , Fedora (fedora-redhat-bugs) wrote :

Package libreoffice-3.6.3.1-3.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing libreoffice-3.6.3.1-3.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-16704/libreoffice-3.6.3.1-3.fc18
then log in and leave karma (feedback).

Revision history for this message
In , Wugs (wugs) wrote :

@ Caolán:
Thank you for fixing this issue! It was very annoying on Mac OS X, too: no loss of functionality at all, but just making LibO look unprofessional ...

Revision history for this message
In , Libreoffice-bugs (libreoffice-bugs) wrote :

Caolan McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-3-6-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7dbcf00ffe16e61a9fbd7f58c6ed0c644d2e81ca&g=libreoffice-3-6-3

Resolves: rhbz#868479 / fdo#56281 doubled ~ in German ok/cancel translations

It will be available already in LibreOffice 3.6.3.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

Revision history for this message
In , Fedora (fedora-redhat-bugs) wrote :

libreoffice-3.6.3.1-3.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.

Changed in df-libreoffice:
importance: Unknown → Medium
status: Unknown → Fix Released
Revision history for this message
Björn Michaelsen (bjoern-michaelsen) wrote :

lp#1103495: released on Fedora 17 and upstream, prevents release regression against 3.5.4

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libreoffice - 1:4.0.0~beta2-0ubuntu2

---------------
libreoffice (1:4.0.0~beta2-0ubuntu2) raring; urgency=low

  * Build using the internal libmspub for a first build.
 -- Matthias Klose <email address hidden> Tue, 19 Feb 2013 00:05:26 +0100

Changed in libreoffice (Ubuntu):
status: New → Fix Released
Changed in libreoffice (Fedora):
importance: Unknown → Low
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.