Launchpad itself

OffsiteFormPostError raised for referer with square braces in query

Bug #112315 reported by Gavin Panella
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Undecided
Gavin Panella

Bug Description

Older releases of apport link users to Launchpad with links of the form:

  https://launchpad.net/ubuntu/+source/libbonobo/+filebug/...?field.title=[apport]+...

Submitting the bug from that page triggers an OffsiteFormPostError. Removing the square brackets from the query string fixes the problem. Looking at the code shows that this is a problem with parsing the referer header. It's unclear whether the link violates RFC-3986 or not, but the browser is sending it and Launchpad should either accept it or signal a more appropriate error.

Gavin Panella (allenap)
Changed in launchpad:
status: Unconfirmed → In Progress
Revision history for this message
Gavin Panella (allenap) wrote :

Need to also change the text-to-html formatter used for bug comments.

Changed in launchpad:
assignee: nobody → allenap
Gavin Panella (allenap)
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Christian Reis (kiko) wrote :

Have you filed another bug about that, Gavin?

Revision history for this message
Gavin Panella (allenap) wrote :

No, I made the changes at the same time. Would you prefer a separate bug+branch for that?

Revision history for this message
Christian Reis (kiko) wrote :

No -- if it's reviewed and landed already I think it's fine.

Revision history for this message
Joey Stanford (joey) wrote :

changing to fix released. in RF 4261

Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.