Secure delete not called for snapshots even when expected

Bug #1134768 reported by John Griffith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Won't Fix
High
Rushi Agrawal

Bug Description

Some of the changes to the LVM secure_delete features introduced a bug where cinder.volume.drivers.lvm:clear_volume only checks the reference obejcts "size" parameter and returns if None. The problem is that the clear_volume method is also used to clear snapshots on delete.

This is easily fixed by changing size_in_g = volume.get('size') to (volume.get('size') or volume.get('snapshot_size'), however this introduces yet another problem.

On Ubuntu Precise we're still plagued by: https://bugs.launchpad.net/cinder/+bug/1023755

So I think the best we can do right now is to log info regarding what we're doing here, or at the very least comment/document in the code that skipping secure_delete on the LVM snapshot is intentional.

It may also be worth checking /etc/issue and deciding how to proceed based on that.

tags: added: folsom-backport-potential
description: updated
Thierry Carrez (ttx)
Changed in cinder:
milestone: grizzly-rc1 → none
tags: added: grizzly-rc-potential
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → grizzly-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24987

Changed in cinder:
assignee: John Griffith (john-griffith) → Rushi Agrawal (rushiagr)
status: Triaged → In Progress
Thierry Carrez (ttx)
tags: removed: grizzly-rc-potential
Changed in cinder:
milestone: grizzly-rc2 → none
Revision history for this message
Kurt Seifried (kseifried) wrote :

Does this only affect Ubuntu Precise or anyone else at all?

Revision history for this message
John Griffith (john-griffith) wrote :

Kurt,

This is Ubuntu only so far. I was unable to reproduce on other platforms and have not heard of anybody reproducing on other platforms either.

Changed in cinder:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.