Ubuntu
unity package

[UIFe] Window list in right click context menu should indicate the focused window

Bug #1152477 reported by Tigran Gabrielyan
52
This bug affects 11 people
Affects Status Importance Assigned to Milestone
Ayatana Design
Fix Released
Medium
John Lea
Unity
Fix Released
Medium
Tigran Gabrielyan
unity (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Ubuntu 13.04

When we right click on a launcher's icon which has 2 or more windows open, we now have a list of open windows we may switch focus to.

If the current focused window is in this list, it should be highlighted already. Some apps have the same name in the title bar and it is sometimes hard to tell which item in the list is the other window you are trying to give focus to.

Example:

2 Chrome windows open, call it Window A and Window B.
Window B has focus.
Right click on chrome's launcher.

Current behavior:
    Window A
    Window B

What it should be:
    Window A
  * Window B

* = radio state checked

Ubuntu-doc list: https://lists.ubuntu.com/archives/ubuntu-doc/2013-March/017153.html

See original description
Tags: raring udp

Related branches

lp:~tigrangab/unity/unity-fix-1152477
PS Jenkins bot (community): Approve (continuous-integration)
Marco Trevisan (Treviño): Approve
Andrea Azzarone (community): Approve
Diff: 48 lines (+14/-0)
2 files modified
launcher/ApplicationLauncherIcon.cpp (+8/-0)
tests/test_application_launcher_icon.cpp (+6/-0)
Tigran Gabrielyan (tigrangab)
tags: added: raring
description: updated
summary: - Right click context menu on launcher icons window list should highlight
- the current focused window
+ Window list in right click context menu should show active/focused
+ window
description: updated
Tigran Gabrielyan (tigrangab)
summary: - Window list in right click context menu should show active/focused
+ Window list in right click context menu should indicate the focused
window
Tigran Gabrielyan (tigrangab)
Changed in unity (Ubuntu):
assignee: nobody → Tigran Gabrielyan (tigrangab)
status: New → In Progress
Revision history for this message
Tigran Gabrielyan (tigrangab) wrote : Re: Window list in right click context menu should indicate the focused window

Patch added: http://bazaar.launchpad.net/~tigrangab/unity/unity-fix-1152477/revision/3203

See attachment
-------------------------
Firefox_launchpad_open.png: Firefox window with launchpad.net opened and is the focused window, so that item has the radio checked state
Firefox_google_open.png: Firefox window with google.com opened and is the focused window, so that itemhas the radio checked state
Firefox_nautilus_open.png: Nautilis is focused so no firefox window entry has radio checked state

Andrea Azzarone (azzar1)
Changed in unity:
status: New → Incomplete
tags: added: needs-design
Revision history for this message
Adolfo Jayme Barrientos (fitojb) wrote :

I agree with this request, I think it's sensible and makes sense. Also, thanks for creating a patch and screenshots, Tigran! Kudos!

John Lea (johnlea)
Changed in ayatana-design:
assignee: nobody → John Lea (johnlea)
importance: Undecided → Medium
Changed in unity:
importance: Undecided → Medium
Changed in unity (Ubuntu):
importance: Undecided → Medium
Changed in ayatana-design:
status: New → Fix Committed
Changed in unity:
status: Incomplete → Triaged
tags: added: udp
removed: needs-design
Revision history for this message
John Lea (johnlea) wrote :

@tigrangab; thanks for both the good suggestion, clear description, screenshots and a patch that implements the change ;-) Submitting all these together makes it really easy to review and approve the change, thanks again!

+1 from design

(I wish more bug reports were like this one, this is a textbook example of how to submit a change request ;-)

Revision history for this message
Tigran Gabrielyan (tigrangab) wrote :

@johnlea No problem :)

I just wanted to confirm that you gave the approval for radio button option.

Revision history for this message
John Lea (johnlea) wrote :

@tigrangab; yes, radio option approved ;-)

For clarity, screenshots attached to comment #1 are good, approved by design.

Tigran Gabrielyan (tigrangab)
summary: - Window list in right click context menu should indicate the focused
- window
+ [FFe] Window list in right click context menu should indicate the
+ focused window
Marco Trevisan (Treviño) (3v1n0)
Changed in unity:
status: Triaged → In Progress
assignee: nobody → Tigran Gabrielyan (tigrangab)
milestone: none → 7.0.0
Changed in unity (Ubuntu):
status: In Progress → New
assignee: Tigran Gabrielyan (tigrangab) → nobody
Andrea Azzarone (azzar1)
summary: - [FFe] Window list in right click context menu should indicate the
+ [UIFe] Window list in right click context menu should indicate the
focused window
Revision history for this message
Andrea Azzarone (azzar1) wrote :

Hi Tigran, can you email doc-team as per https://wiki.ubuntu.com/FreezeExceptionProcess#UserInterfaceFreeze_Exceptions.

Revision history for this message
Tigran Gabrielyan (tigrangab) wrote :

I'm waiting for mod approval so I can post the links here.

Revision history for this message
Tigran Gabrielyan (tigrangab) wrote :

Ubuntu-doc list: https://lists.ubuntu.com/archives/ubuntu-doc/2013-March/017153.html

Revision history for this message
Benjamin Kerensa (bkerensa) wrote :

I think the impact on documentation will be minimal if any.

+1 from Doc Team

Tigran Gabrielyan (tigrangab)
description: updated
Andrea Azzarone (azzar1)
description: updated
Stephen M. Webb (bregma)
Changed in unity:
milestone: 7.0.0 → 7.0.1
Revision history for this message
Steve Langasek (vorlon) wrote :

This is very low-impact for the docs team since it only affects a context menu, which is almost never included in screenshots; approved the UIFe.

Changed in unity (Ubuntu):
status: New → Triaged
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity at revision None, scheduled for release in unity, milestone backlog

Changed in unity:
status: In Progress → Fix Committed
Andrea Azzarone (azzar1)
Changed in unity (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 7.0.0daily13.04.08-0ubuntu1

---------------
unity (7.0.0daily13.04.08-0ubuntu1) raring; urgency=low

  [ Tigran Gabrielyan ]
  * [UIFe] Window list in right click context menu should indicate the
    focused window (LP: #1152477)

  [ Andrea Azzarone ]
  * Launcher - When a app is automatically placed in the Launcher after
    being installed from the Software Center, it should be in the 'non-
    running' state (LP: #987727)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 3283
 -- Ubuntu daily release <email address hidden> Mon, 08 Apr 2013 04:02:51 +0000

Changed in unity (Ubuntu):
status: Fix Committed → Fix Released
John Lea (johnlea)
Changed in ayatana-design:
status: Fix Committed → Fix Released
Revision history for this message
Stephen M. Webb (bregma) wrote :

Fix released in Unity 7.1.0.

Changed in unity:
milestone: 7.0.1 → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.