OpenPandora patch for FAT FS

Well, ISO 8601 defines the ':', so I am not too fond of changing the char in all cases. Can you add a #ifdef that only applies for Pandora?

It seems to apply to FAT FS in general, not only on Pandora platforms. So it will occur on Linux and Windows, too... (but I wonder why it hasn't bothered someone in the past... )

I think a compile-time option is not the best solution to this... otoh, removing ':' seems wrong too.
And a user-overridable run-time solution with fallback only adds complexity.

Linux has never used fat for anything and windows is exfat since xp (i think). I doubt those filesystems have this limitation at all - I have a hard time that vfat had this limitation.

All Microsoft Windows filesystems I know (Fat16, Fat32, NTFS) disallow the ":" sign - simply because it is reserved for partitions (like c:\) - because of that, there are already special cases for Windows builds, that replace the ":" - the OpenPandora problem is new in that way, that a none Windows OS is installed and running on a windows filesystem (which is uncommon in the "normal" unix world, but quite common for mobile devices).

So this bug is quite valid - maybe there is a way to check whether the filesystem allows ":" ??

Exfat is not supported on OpenPandora, so Windows users use fat32 or ntfs for SD cards.

This characters are not allowed on fat32 filenames:

'\', '/', '?', '*', ':', ';' and '+'

This is the error that crash the game:

Unexpected error during the game
[/media/pandora/pandora/compilar/widelands-build17-src/src/logic/replay.cc:241] Failed to save game for replay: ZipFilesystem::MakeDirectory: problem with file/directory: /binary/

Changing ':' for '.' fixed this. For more info:

http://boards.openpandora.org/index.php/topic/11799-ported-game-widelands/?hl=widelands

Okay, convinced. Please do not make the patch conditional though, just replace it in all versions of Widelands for consistency.

No more #ifdef

Committed in r6548. Thanks for your work!

Released in build-18 rc1.