Syndetics data elements with no content not being detected as such

Bug #1155267 reported by Jeff Godin
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.2
Fix Released
Medium
Unassigned
2.3
Fix Released
Medium
Unassigned

Bug Description

Symptom: When using the Syndetic Solutions added content provider, most/all titles show Author Notes, Reviews, Table of Contents, Excerpt, even though there may be no data in those elements.

This is a recent symptom, which appears to have been brought on by a change in how Syndetic Solutions returns their content.

Previously, we relied on a <title> element of "error" to detect empty data elements.

Now, it appears that we need to look for "No Data Available".

This should be the quick fix which is easily applied and backport friendly.

Working branch to follow.

Revision history for this message
Jeff Godin (jgodin) wrote :

one line fix at user/jeff/lp1155267_ac_syndetics_empty_detection

recommend backport to all supported releases.

when testing, consider clearing html ac elements from memcached (either selectively or with a full memcached restart) after applying the patch, to avoid seeing empty data elements which were cached before the fix.

tags: added: pullrequest
Changed in evergreen:
assignee: Jeff Godin (jgodin) → nobody
Ben Shum (bshum)
Changed in evergreen:
importance: Undecided → Medium
milestone: none → 2.4.0-beta
status: New → Triaged
Revision history for this message
Ben Shum (bshum) wrote :

Works for me. Thanks Jeff! Picked to master, rel_2_3, and rel_2_2.

Changed in evergreen:
status: Triaged → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.