Ubuntu
glib-networking package

should use the direct proxy resolver in unity sessions

Bug #1172792 reported by Sebastien Bacher on 2013-04-25

This bug affects 1 person

	Status	Importance	Assigned to
Glib Networking	Fix Released	Medium	gnome-bugs #698936
glib-networking (Ubuntu)	Fix Released	Undecided	Iain Lane
Raring	Fix Released	Undecided	Iain Lane
Saucy	Fix Released	Undecided	Iain Lane

Bug Description

* Impact:
The gnome mode is not activated and the code go through fallback which runs extra processes (sh and pxgproxy)

* Test Case:
- run /usr/lib/ubuntu-geoip/ubuntu-geoip-provider
- look at the processes list

before the fix ubuntu-geoip-provider was having "sh -c ... pxgsettings ..." processes, it shouldl not have those

* Regression potential:
another codepath will be used for proxies, we should check that they still work correctly from ubuntu-geoip-provider or other GNOME applications

------

The code in raring has this function

"static gboolean
g_proxy_resolver_gnome_is_supported (GProxyResolver *object)
{
return !g_strcmp0 (g_getenv ("DESKTOP_SESSION"), "gnome");
}"

that makes the code fallback to use libproxy's which does the same thing in an hackish way and spawn pxgproxy commands should shell intepreters

In Unity we change set the DESKTOP_SESSION to "ubuntu", that should be a gnome_is_support valid value as well

Tags:

Related branches

lp:ubuntu/saucy/glib-networking

Sebastien Bacher (seb128) on 2013-04-25

summary:	- should use the direct proxy resolved in unity sessions + should use the direct proxy resolver in unity sessions
Changed in glib-networking (Ubuntu):
assignee:	nobody → Iain Lane (laney)

Revision history for this message

Iain Lane (laney) wrote on 2013-04-25:

glib-networking_2.36.1-0ubuntu2.debdiff Edit (1.7 KiB, text/plain)

Here's my initial patch. I'll do the needful tomorrow for this.

The next work will be to figure out how best to avoid libproxy having the pxgsettings helper which runs all of the time.

Ubuntu Foundations Team Bug Bot (crichton) on 2013-04-25

tags:

added: patch

Revision history for this message

Iain Lane (laney) wrote on 2013-04-26:

Uploaded to raring and saucy.

Changed in glib-networking (Ubuntu Raring):
assignee:	nobody → Iain Lane (laney)
status:	New → In Progress
Changed in glib-networking (Ubuntu Saucy):
status:	New → Fix Committed
Changed in glib-networking:
importance:	Undecided → Unknown
status:	New → Unknown

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-04-26:

This bug was fixed in the package glib-networking - 2.36.1-0ubuntu2

---------------
glib-networking (2.36.1-0ubuntu2) saucy; urgency=low

  * Have the GNOME proxy resolver function on Unity too so we don't fall back
    to libproxy. Upstream created an automatic libproxy fallback for non-GNOME
    sessions in 2.35.3, but this plugin can and should be used on Ubuntu too.
    This will avoid one major source of pxgsettings processes which are
    currently spawned by libproxy. (LP: #1172792)
-- Iain Lane <email address hidden> Fri, 26 Apr 2013 12:12:30 +0100

Changed in glib-networking (Ubuntu Saucy):
status:	Fix Committed → Fix Released

Bug Watch Updater (bug-watch-updater) on 2013-04-26

Changed in glib-networking:
importance:	Unknown → Medium
status:	Unknown → New

Bug Watch Updater (bug-watch-updater) on 2013-05-02

Changed in glib-networking:
status:	New → Fix Released

Revision history for this message

Brian Murray (brian-murray) wrote on 2013-05-30: Please test proposed package

Hello Sebastien, or anyone else affected,

Accepted glib-networking into raring-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/glib-networking/2.36.2-0ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in glib-networking (Ubuntu Raring):
status:	In Progress → Fix Committed
tags:	added: verification-needed

Revision history for this message

Ubuntu Foundations Team Bug Bot (crichton) wrote on 2013-08-29: [glib-networking/raring] verification still needed

The fix for this bug has been awaiting testing feedback in the -proposed repository for raring for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

tags:

added: removal-candidate

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-10-09:

This bug was fixed in the package glib-networking - 2.36.2-0ubuntu0.1

---------------
glib-networking (2.36.2-0ubuntu0.1) raring; urgency=low

  * New upstream release (LP: #1179875)
    + proxy/gnome: Fix "automatic" mode, which was mistakenly being treated as
      "none"
    + proxy/gnome: Use this in Unity sessions as well as GNOME ones.
    + proxy/libproxy: Fix handling of SOCKS proxies
  * debian/patches/0001-proxy-tests-libproxy-Set-GIO_EXTRA_MODULES-to-use-th.patch:
    Patch testsuite to pick up the just-built libproxy module, fixing test
    failures.

glib-networking (2.36.1-0ubuntu1.1) raring; urgency=low