Updating groups by CSV caused 'Not found' page

Bug #1187571 reported by Son Nguyen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon

Bug Description

Version: master
Platform: all

When updating groups by CSV and if CSV contains a new group, a unexpected 'Not found' page appears.

Expected result: an error message with line number which contains the new group info.
like: Error on line 3 of your file: The group with shortname "g01" does not exists.

Tags: csvupload
Revision history for this message
Robert Lyon (robertl-9) wrote :
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
status: New → In Progress
Changed in mahara:
importance: High → Medium
milestone: none → 1.8.0rc1
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2301
Committed: http://gitorious.org/mahara/mahara/commit/b11f42e2947126c0fe95b166b2c252e72fe7c45b
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit b11f42e2947126c0fe95b166b2c252e72fe7c45b
Author: Robert Lyon <email address hidden>
Date: Mon Jul 1 16:13:59 2013 +1200

Show warn if nonexistant group is in group csv update bug #1187571

To test:
- Fresh install upload some groups via csv
- Add a new group to the csv and then try and upload with the 'Update
groups' option checked

should give broken 'page not found'

- Apply patch
- Add a new group to the csv and then try and upload with the 'Update
groups' option checked

should tell you the line where things are wrong in normal error.

Change-Id: Ifb7558c5c3b51f7fa0d6c677e7ef65badd1d0a24
Signed-off-by: Robert Lyon <email address hidden>

Son Nguyen (ngson2000)
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.8rc1 → 1.8.0
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.