Leap2A doesn't export collections under "All data"

Bug #1191442 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon

Bug Description

Mahara master (1.8)

When the portfolio contains a collection, this is not exported. This works fine in Mahara 1.7 on the demo site but not on master.

I exported a Leap2A portfolio with 1 collection on the demo site and imported it back in there and the collection was still there. I took the same Leap2A export and imported into master and only had the pages available, but not the collection.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

The Leap2A import works fine when I select "Just some of my collections" to export.

Changed in mahara:
milestone: none → 1.8.0rc1
Revision history for this message
Aaron Wells (u-aaronw) wrote :

This appears to be a regression caused by one of the commits on the master branch. So, we should be able to find what caused it by using git bisect, if nothing else.

Changed in mahara:
assignee: nobody → Aaron Wells (u-aaronw)
tags: added: regression
Changed in mahara:
assignee: Aaron Wells (u-aaronw) → nobody
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Robert Lyon (robertl-9) wrote :

Hmm,

I created a collection in a 1.7_STABLE site and exported and re-imported it to 1.7_STABLE and that worked fine

I then took the leap2A file and imported it into a latest 1.8 master site and it imported fine. I could see the two pages I made and the collection for them also.

Is this still not working right?

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Download full text (12.7 KiB)

I still have the problems. Now I actually get a lot of warnings:

1. Right on the export page when the export is finished:
=================
<div class="backtrace">[WAR] 20 (export/leap/lib.php:291) Undefined variable: widths</div>
<div class="backtrace"><strong>Call stack (most recent first):</strong> <ul><li><span style="color:#933;"></span><span style="color:#060;"></span><span style="color:#339;">log_message</span><span style="color:#060;">(</span><span style="color:#f00;">&quot;Undefined variable: widths&quot;, 8, true, true, &quot;/home/kristina/code/mahara/htdocs/export/leap/lib....&quot;, 291</span><span style="color:#060;">)</span> at <strong>/home/kristina/code/mahara/htdocs/lib/errors.php:446</strong></li><li><span style="color:#933;"></span><span style="color:#060;"></span><span style="color:#339;">error</span><span style="color:#060;">(</span><span style="color:#f00;">8, &quot;Undefined variable: widths&quot;, &quot;/home/kristina/code/mahara/htdocs/export/leap/lib....&quot;, 291, array(size 14)</span><span style="color:#060;">)</span> at <strong>/home/kristina/code/mahara/htdocs/export/leap/lib.php:291</strong></li><li><span style="color:#933;">PluginExportLeap</span><span style="color:#060;">-&gt;</span><span style="color:#339;">export_views</span><span style="color:#060;">(</span><span style="color:#f00;"></span><span style="color:#060;">)</span> at <strong>/home/kristina/code/mahara/htdocs/export/leap/lib.php:134</strong></li><li><span style="color:#933;">PluginExportLeap</span><span style="color:#060;">-&gt;</span><span style="color:#339;">export</span><span style="color:#060;">(</span><span style="color:#f00;"></span><span style="color:#060;">)</span> at <strong>/home/kristina/code/mahara/htdocs/export/download.php:108</strong></li></div>
=================================

2. When I import the user:
============================

[WAR] 49 (import/leap/lib.php:824) Undefined variable: sql
Call stack (most recent first):

    log_message("Undefined variable: sql", 8, true, true, "/home/kristina/code/mahara/htdocs/import/leap/lib....", 824) at /home/kristina/code/mahara/htdocs/lib/errors.php:446
    error(8, "Undefined variable: sql", "/home/kristina/code/mahara/htdocs/import/leap/lib....", 824, array(size 17)) at /home/kristina/code/mahara/htdocs/import/leap/lib.php:824
    PluginImportLeap->import_entry_as_mahara_view(object(SimpleXMLElement)) at /home/kristina/code/mahara/htdocs/import/leap/lib.php:683
    PluginImportLeap->import_using_strategy(object(SimpleXMLElement), 1, array(size 0)) at /home/kristina/code/mahara/htdocs/import/leap/lib.php:501
    PluginImportLeap->import_from_load_mapping() at /home/kristina/code/mahara/htdocs/import/leap/lib.php:146
    PluginImportLeap->process() at /home/kristina/code/mahara/htdocs/admin/users/add.php:339
    adduser_submit(object(Pieform), array(size 21)) at Unknown:0
    call_user_func_array("adduser_submit", array(size 2)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:528
    Pieform->__construct(array(size 7)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:170
    Pieform::process(array(size 7)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pi...

Revision history for this message
Robert Lyon (robertl-9) wrote :

have added patchset to fix the trying to access non existing table and stop the other errors from appearing

https://reviews.mahara.org/#/c/2451/

Changed in mahara:
status: Triaged → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2450
Committed: http://gitorious.org/mahara/mahara/commit/9f70ef285f3dd59b82ec57a83466666e9e50e217
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9f70ef285f3dd59b82ec57a83466666e9e50e217
Author: Robert Lyon <email address hidden>
Date: Thu Aug 29 11:26:32 2013 +1200

fixing a warning message about widths bug #1191442

Change-Id: I30658faf750485aa8715d48a8ba7eda56e39109c
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/2451
Committed: http://gitorious.org/mahara/mahara/commit/5c3fdd9072a1678586c0d17178d1f41cf58aeab9
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 5c3fdd9072a1678586c0d17178d1f41cf58aeab9
Author: Robert Lyon <email address hidden>
Date: Thu Aug 29 16:07:42 2013 +1200

Getting collections to export for leap2a (Bug 1191442)

- getting collections to export when choosing
leap2a and 'all my data'

- getting the errors to subside and getting an export from 1.8 to
be able to be imported into 1.8 again
- getting correct default layout to be chosen for importing
portfolio page.

Change-Id: I81c4c7f5ffc307e8e841cafda3e38ee5864e43c7
Signed-off-by: Robert Lyon <email address hidden>

Aaron Wells (u-aaronw)
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.8rc1 → 1.8.0
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.