input_pointing jobs does not contain good information for the reviewer
Bug #1192541 reported by
Ara Pulido
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox |
Fix Released
|
High
|
Daniel Manrique |
Bug Description
As part of the resources jobs, input_pointing jobs are created for each of the MOUSE or TOUCH device found in udev.
The problem is that the name of the jobs are created just with the path, not the product name, so when reviewing submissions we can get things like:
"input/
With no clue of what point device didn't work.
We need to somehow include the product name in the job name or the output (but this is a manual test case...)
Related branches
lp:~roadmr/checkbox/1192541-descriptive-input-test-names
- Sylvain Pineau: Approve
- Ara Pulido (community): Approve
-
Diff: 25 lines (+3/-1)2 files modifiedcheckbox-old/debian/changelog (+2/-0)
checkbox-old/jobs/input.txt.in (+1/-1)
tags: | added: job |
Changed in checkbox: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
This is an example of a job generated by the local job in question:
plugin: manual input24 pci0000: 00/0000: 00:1a.0/ usb1/1- 1/1-1.2/ 1-1.2:1. 0/input/ input24"
name: input/pointing_
requires: device.path == "/devices/
description:
PURPOSE:
This will test your Logitech USB Receiver device
STEPS:
1. Move the cursor with your Logitech USB Receiver.
VERIFICATION:
Did the cursor move?
Notice the cryptic name:
name: input/pointing_ input24
The modification I have in mind will replace the name with a concatenation of the product name, type and path.. Logitech_ USB_Receiver_ MOUSE_input24
name: input/pointing_
hopefully this will be enough. Unfortunately we do have to include some sort of unique identifier (what if a user has two identical mice plugged in?), to avoid generating clashing job names. The actual udev identifier is as good as anything. But I *am* including more detailed information.
I'll propose a merge request with this but wait for feedback, since the new names are more informative but very ugly :/ so I'd like some opinions