input_pointing jobs does not contain good information for the reviewer

Bug #1192541 reported by Ara Pulido
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox
Fix Released
High
Daniel Manrique

Bug Description

As part of the resources jobs, input_pointing jobs are created for each of the MOUSE or TOUCH device found in udev.

The problem is that the name of the jobs are created just with the path, not the product name, so when reviewing submissions we can get things like:

"input/pointing_input14 test fail"

With no clue of what point device didn't work.

We need to somehow include the product name in the job name or the output (but this is a manual test case...)

Tags: job

Related branches

Daniel Manrique (roadmr)
tags: added: job
Revision history for this message
Daniel Manrique (roadmr) wrote :

This is an example of a job generated by the local job in question:

plugin: manual
name: input/pointing_input24
requires: device.path == "/devices/pci0000:00/0000:00:1a.0/usb1/1-1/1-1.2/1-1.2:1.0/input/input24"
description:
 PURPOSE:
     This will test your Logitech USB Receiver device
 STEPS:
     1. Move the cursor with your Logitech USB Receiver.
 VERIFICATION:
     Did the cursor move?

Notice the cryptic name:

name: input/pointing_input24

The modification I have in mind will replace the name with a concatenation of the product name, type and path..
name: input/pointing_Logitech_USB_Receiver_MOUSE_input24

hopefully this will be enough. Unfortunately we do have to include some sort of unique identifier (what if a user has two identical mice plugged in?), to avoid generating clashing job names. The actual udev identifier is as good as anything. But I *am* including more detailed information.

I'll propose a merge request with this but wait for feedback, since the new names are more informative but very ugly :/ so I'd like some opinions

Changed in checkbox:
assignee: nobody → Daniel Manrique (roadmr)
status: New → In Progress
Revision history for this message
Daniel Manrique (roadmr) wrote :

These are the two input tests generated on my laptop:

input/pointing_ETPS2_Elantech_Touchpad_TOUCHPAD_input7: pass
input/pointing_Logitech_USB_Receiver_MOUSE_input24: pass

The names are a bit unwieldy but it's entirely clear what each one is for.

Daniel Manrique (roadmr)
Changed in checkbox:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.