Ubuntu
unity8 package

autopilot test scenarios for lockscreens are wrong

Bug #1204984 reported by Michael Zanetti
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity8 (Ubuntu)
Fix Released
Undecided
Michael Terry

Bug Description

Since the refactored autopilot tests, we execute the test_lockscreens also for the Tablet form factor which is wrong because it mixes the desktop greeter with the phone lockscreens.

This however reveals an issue in the code too which probably should not allow such a scenario.

Related branches

lp:~mterry/unity8/lockscreen-autopilot
Michael Zanetti (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Katie Taylor: Pending (design) requested
Diff: 273 lines (+76/-45)
7 files modified
Greeter/Greeter.qml (+2/-3)
Greeter/GreeterContent.qml (+0/-1)
Shell.qml (+1/-1)
tests/autopilot/unity8/shell/emulators/greeter.py (+4/-1)
tests/autopilot/unity8/shell/tests/test_hud.py (+5/-5)
tests/autopilot/unity8/shell/tests/test_lock_screen.py (+62/-30)
tests/mocks/LightDM/single/GreeterPrivate.cpp (+2/-4)
lp:ubuntu/saucy-proposed/unity8
Revision history for this message
Michael Zanetti (mzanetti) wrote :

mterry, can you shed some light why we can mix the password enabled Greeter and the Phone lockscreens and if that is actually the expected behavior? Certainly it makes no sense from a end user POV.

Changed in unity8:
assignee: nobody → Michael Terry (mterry)
status: New → Incomplete
Revision history for this message
Michael Terry (mterry) wrote :

Yeah, seems wrong. Looks like a confused definition of Greeter.locked, and some other widgets looking at that value instead of Greeter.narrowMode. Branch coming for autopilot and code fixes.

Michael Terry (mterry)
Changed in unity8:
status: Incomplete → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity8 at revision 160, scheduled for release in unity8, milestone Unknown

Changed in unity8:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 7.81.3+13.10.20130805-0ubuntu1

---------------
unity8 (7.81.3+13.10.20130805-0ubuntu1) saucy; urgency=low

  [ Michael Terry ]
  * Fixes the lockscreen and swiping on the greeter still being possible
    even when in tablet mode. (LP: #1204984)
  * Watch powerd signals to notice a sleep and unfocus current app when
    that happens.

  [ Michael Zanetti ]
  * make findChild also find invisible childs This considerably
    increases the amount of items to be searched up to a level where
    testShell didn't finish any more with searching. Hence this commit
    also changes findChild to do a breadth-first instead of a depth-
    first search.
  * Read background from GSettings or fallback to default_background.

  [ Andrea Cimitan ]
  * Read background from GSettings or fallback to default_background.

  [ Albert Astals ]
  * Make LVWPH provide a delegateIndex for sectionHeaders This way we
    can match the sectionHeader to the model easier in the qml/js side .
  * Fix tryCompare call The 4th parameter of tryCompare is timeout not
    message .

  [ Daniel d'Andrada ]
  * Read background from GSettings or fallback to default_background.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 162
 -- Ubuntu daily release <email address hidden> Mon, 05 Aug 2013 02:32:05 +0000

Changed in unity8 (Ubuntu):
status: New → Fix Released
Michael Terry (mterry)
Changed in unity8:
status: Fix Committed → Fix Released
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
assignee: nobody → Michael Terry (mterry)
no longer affects: unity8
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.