[MIR] location-service

The package is built on supported archs:
https://launchpad.net/ubuntu/+source/location-service/0.0.1+13.10.20130829.1-0ubuntu1

(we don't support powerpc for the touch stack)

The desktop team is going to look at the package once in Ubuntu (subscribed to the package in launchpad)

* What's the story with the following bit of code in the permissions manager? Seems problematic.
    if (credentials.pid != pid || credentials.uid != uid)
        return Result::granted; // FIXME(tvoss): This should return rejected.
* Seems like it's missing a Build-Depends on graphviz for /usr/bin/dot
* Should have "Pre-Depends: ${misc:Pre-Depends}" for libubuntu-location-service0
* Has tests and runs them, great!
* No important bugs

Also needs lcov and dbus-cpp-dev, which I've added to this bug. I'll look at them next.

Also for location-service, a couple lintian warnings that seem not great:
* W: location-service source: dependency-is-not-multi-archified ubuntu-location-service-examples depends on ubuntu-location-service-doc (multi-arch: no)
* W: ubuntu-location-service-doc: embedded-javascript-library usr/share/LocationService/doc/html/jquery.js

dbus-cpp looks mostly fine, has tests, etc. It needs a team bug subscriber though. Especially since it only keeps bugs in Ubuntu.

As for lcov, is it really needed? Do we do anything with that coverage information? Like I don't notice a test that fails if there isn't enough coverage. Or maybe I missed it.

> dbus-cpp looks mostly fine, has tests, etc. It needs a team bug subscriber though. Especially since it only keeps bugs in Ubuntu.

subscribed desktop-bugs to it, thanks!

I addressed the packaging changes and lintian warnings in the linked branch. For the FIXME in the code: https://bugs.launchpad.net/location-service/+bug/1219164.

Marked the lcov task Invalid since you've removed the build-dep in the linked branch (and lcov already has another MIR at #1218209 anyway)

dbus-cpp also depends on lcov. Can we drop it there too?

Sure, linked the respective dbus-cpp branch

I'm seeing another problem with location-service:

dpkg-shlibdeps: warning: symbol _ZN6google21ParseCommandLineFlagsEPiPPPcb used by debian/libubuntu-location-service0/usr/lib/arm-linux-gnueabihf/libubuntu-location-service.so.0.0.1 found in none of the libraries
dpkg-shlibdeps: warning: symbol _ZN6google24ShutDownCommandLineFlagsEv used by debian/libubuntu-location-service0/usr/lib/arm-linux-gnueabihf/libubuntu-location-service.so.0.0.1 found in none of the libraries

The library is using some symbols from libgflags.so.2, from package libgflags2. But for some reason, the resulting binary deb package does not correctly Depend on libgflags2.

This bug was fixed in the package location-service - 0.0.1+13.10.20130903-0ubuntu1

---------------
location-service (0.0.1+13.10.20130903-0ubuntu1) saucy; urgency=low

  [ thomas-voss ]
  * * Remove build-dependency on lcov. * Add build-dependency on
    graphviz. * Add "Pre-Depends: ${misc:Pre-Depends}" for libubuntu-
    location-service0. * Add MultiArch: foreign for ubuntu-location-
    service-doc. * Disable JS-based search engine in doxygen setup to
    address lintian warning. (LP: #1218896)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 36
 -- Ubuntu daily release <email address hidden> Tue, 03 Sep 2013 15:16:22 +0000

This bug was fixed in the package dbus-cpp - 0.0.1+13.10.20130904-0ubuntu1

---------------
dbus-cpp (0.0.1+13.10.20130904-0ubuntu1) saucy; urgency=low

  [ thomas-voss ]
  * Drop lcov dependency. (LP: #1218896)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 12
 -- Ubuntu daily release <email address hidden> Wed, 04 Sep 2013 02:32:09 +0000

OK, approved location-service. The only remaining issue is bug 1219164, which will be fixed before 13.10.

(The effect of the bug is that the user isn't prompted when apps -- that apparmor allows to access location info -- request to access it. Location-service just assumes the user wants to allow it.)

dbus-cpp 0.0.1+13.10.20130904-0ubuntu1 in saucy: universe/libs -> main
dbus-cpp-dev 0.0.1+13.10.20130904-0ubuntu1 in saucy amd64: universe/libdevel/optional/100% -> main
dbus-cpp-dev 0.0.1+13.10.20130904-0ubuntu1 in saucy armhf: universe/libdevel/optional/100% -> main
dbus-cpp-dev 0.0.1+13.10.20130904-0ubuntu1 in saucy i386: universe/libdevel/optional/100% -> main
dbus-cpp-dev 0.0.1+13.10.20130904-0ubuntu1 in saucy powerpc: universe/libdevel/optional/100% -> main
dbus-cpp-dev-examples 0.0.1+13.10.20130904-0ubuntu1 in saucy amd64: universe/x11/optional/100% -> main
dbus-cpp-dev-examples 0.0.1+13.10.20130904-0ubuntu1 in saucy armhf: universe/x11/optional/100% -> main
dbus-cpp-dev-examples 0.0.1+13.10.20130904-0ubuntu1 in saucy i386: universe/x11/optional/100% -> main
dbus-cpp-dev-examples 0.0.1+13.10.20130904-0ubuntu1 in saucy powerpc: universe/x11/optional/100% -> main
Override [y|N]? y
9 publications overridden.

location-service 0.0.1+13.10.20130904-0ubuntu1 in saucy: universe/utils -> main
libubuntu-location-service-dev 0.0.1+13.10.20130904-0ubuntu1 in saucy amd64: universe/libdevel/optional/100% -> main
libubuntu-location-service-dev 0.0.1+13.10.20130904-0ubuntu1 in saucy armhf: universe/libdevel/optional/100% -> main
libubuntu-location-service-dev 0.0.1+13.10.20130904-0ubuntu1 in saucy i386: universe/libdevel/optional/100% -> main
libubuntu-location-service0 0.0.1+13.10.20130904-0ubuntu1 in saucy amd64: universe/libs/optional/100% -> main
libubuntu-location-service0 0.0.1+13.10.20130904-0ubuntu1 in saucy armhf: universe/libs/optional/100% -> main
libubuntu-location-service0 0.0.1+13.10.20130904-0ubuntu1 in saucy i386: universe/libs/optional/100% -> main
ubuntu-location-service-doc 0.0.1+13.10.20130904-0ubuntu1 in saucy amd64: universe/doc/optional/100% -> main
ubuntu-location-service-doc 0.0.1+13.10.20130904-0ubuntu1 in saucy armhf: universe/doc/optional/100% -> main
ubuntu-location-service-doc 0.0.1+13.10.20130904-0ubuntu1 in saucy i386: universe/doc/optional/100% -> main
ubuntu-location-service-doc 0.0.1+13.10.20130904-0ubuntu1 in saucy powerpc: universe/doc/optional/100% -> main
ubuntu-location-service-examples 0.0.1+13.10.20130904-0ubuntu1 in saucy amd64: universe/utils/optional/100% -> main
ubuntu-location-service-examples 0.0.1+13.10.20130904-0ubuntu1 in saucy armhf: universe/utils/optional/100% -> main
ubuntu-location-service-examples 0.0.1+13.10.20130904-0ubuntu1 in saucy i386: universe/utils/optional/100% -> main
Override [y|N]? y
14 publications overridden.

The component was demoted in previous cycles and needs to be promoted back, there is no action needed on the bug but changing to fix-commited to help with the component mismatch summary of the situation

Override component to main
location-service 3.0.0+16.10.20160811-0ubuntu1 in yakkety: universe/utils -> main
libubuntu-location-service-dbg 3.0.0+16.10.20160811-0ubuntu1 in yakkety amd64: universe/debug/optional/100% -> main
libubuntu-location-service-dbg 3.0.0+16.10.20160811-0ubuntu1 in yakkety arm64: universe/debug/optional/100% -> main
libubuntu-location-service-dbg 3.0.0+16.10.20160811-0ubuntu1 in yakkety armhf: universe/debug/optional/100% -> main
libubuntu-location-service-dbg 3.0.0+16.10.20160811-0ubuntu1 in yakkety i386: universe/debug/optional/100% -> main
libubuntu-location-service-dbg 3.0.0+16.10.20160811-0ubuntu1 in yakkety powerpc: universe/debug/optional/100% -> main
libubuntu-location-service-dbg 3.0.0+16.10.20160811-0ubuntu1 in yakkety ppc64el: universe/debug/optional/100% -> main
libubuntu-location-service-dev 3.0.0+16.10.20160811-0ubuntu1 in yakkety amd64: universe/libdevel/optional/100% -> main
libubuntu-location-service-dev 3.0.0+16.10.20160811-0ubuntu1 in yakkety arm64: universe/libdevel/optional/100% -> main
libubuntu-location-service-dev 3.0.0+16.10.20160811-0ubuntu1 in yakkety armhf: universe/libdevel/optional/100% -> main
libubuntu-location-service-dev 3.0.0+16.10.20160811-0ubuntu1 in yakkety i386: universe/libdevel/optional/100% -> main
libubuntu-location-service-dev 3.0.0+16.10.20160811-0ubuntu1 in yakkety powerpc: universe/libdevel/optional/100% -> main
libubuntu-location-service-dev 3.0.0+16.10.20160811-0ubuntu1 in yakkety ppc64el: universe/libdevel/optional/100% -> main
libubuntu-location-service3 3.0.0+16.10.20160811-0ubuntu1 in yakkety amd64: universe/libs/optional/100% -> main
libubuntu-location-service3 3.0.0+16.10.20160811-0ubuntu1 in yakkety arm64: universe/libs/optional/100% -> main
libubuntu-location-service3 3.0.0+16.10.20160811-0ubuntu1 in yakkety armhf: universe/libs/optional/100% -> main
libubuntu-location-service3 3.0.0+16.10.20160811-0ubuntu1 in yakkety i386: universe/libs/optional/100% -> main
libubuntu-location-service3 3.0.0+16.10.20160811-0ubuntu1 in yakkety powerpc: universe/libs/optional/100% -> main
libubuntu-location-service3 3.0.0+16.10.20160811-0ubuntu1 in yakkety ppc64el: universe/libs/optional/100% -> main
ubuntu-location-service-bin 3.0.0+16.10.20160811-0ubuntu1 in yakkety amd64: universe/utils/optional/100% -> main
ubuntu-location-service-bin 3.0.0+16.10.20160811-0ubuntu1 in yakkety arm64: universe/utils/optional/100% -> main
ubuntu-location-service-bin 3.0.0+16.10.20160811-0ubuntu1 in yakkety armhf: universe/utils/optional/100% -> main
ubuntu-location-service-bin 3.0.0+16.10.20160811-0ubuntu1 in yakkety i386: universe/utils/optional/100% -> main
ubuntu-location-service-bin 3.0.0+16.10.20160811-0ubuntu1 in yakkety powerpc: universe/utils/optional/100% -> main
ubuntu-location-service-bin 3.0.0+16.10.20160811-0ubuntu1 in yakkety ppc64el: universe/utils/optional/100% -> main
ubuntu-location-service-doc 3.0.0+16.10.20160811-0ubuntu1 in yakkety amd64: universe/doc/optional/100% -> main
ubuntu-location-service-doc 3.0.0+16.10.20160811-0ubuntu1 in yakkety arm64: universe/doc/optional/100% -> main
ubuntu-location-service-doc 3.0.0+16.10.20160811-0ubuntu1 in yakkety ...