OpenStack Heat

Exceeding stack limits results in 500 errors

Bug #1230191 reported by Steven Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Clint Byrum
OpenStack Heat 2013.2 "havana"

Bug Description

Due to a combination of the exception mapping rework performed under blueprint exception-formatting, and the recent addition of several new exception types related to enforcing stack limits of various types, we now return 500 errors if a user exceeds any of these limits.

Seems like we need to do some or all of the following:

- Stop adding new exceptions for every new type of limit we add, use the generic RequestLimitExceeded
- Modify existing limit-related exceptions to use RequestLimitExceeded
- Fix the CFN API mapping to map RequestLimitExceeded to something other than ISE, e.g HeatInvalidParameterValueError
- Fix api/middleware/fault.py to map the exceptions properly for the native API

Steven Hardy (shardy)
Changed in heat:
milestone: none → havana-rc1
importance: Undecided → High
status: New → Triaged
Clint Byrum (clint-fewbar)
Changed in heat:
assignee: nobody → Clint Byrum (clint-fewbar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/48582

Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/48582
Committed: http://github.com/openstack/heat/commit/9233d44f955f18c56ffbdacc280dea0e9dccc699
Submitter: Jenkins
Branch: master

commit 9233d44f955f18c56ffbdacc280dea0e9dccc699
Author: Clint Byrum <email address hidden>
Date: Thu Sep 26 23:05:16 2013 -0700

    Conform stack resource error so it gives a 4xx

    This exception was added and landed while the change to use
    RequestLimitExceeded was still in progress. Giving a 5xx error when the
    user has caused the problem directly is not what we want.

    We leave the exception in place to allow the shared error message. I
    also have hopes that we will be o-k with extra exceptions and just
    extend RequestLimitExceeded when we have a similar situation.

    Change-Id: Ic9b176625e6ad2b8c42c420dab79984d134304e5
    Partial-Bug: #1230191

Revision history for this message
Faramir (faramir) wrote : AUTO: Hai Liang Wang is on vacation from 09-29 to 10-08 (returning 10/09/2013)

I am out of the office until 10/09/2013.

Conact me by phone for anything urgency.
Phone Number - 15801213126 . thanks !

Note: This is an automated response to your message "[Bug 1230191] Fix
merged to heat (master)" sent on 09/30/2013 8:00:55.

This is the only notification you will receive while this person is away.

Steven Hardy (shardy)
Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.