Mir

Mir servers crash with SIGSEGV in libhybris-common.so.1 on Nexus7 when using the hwcomposer (tegra3)

Bug #1231917 reported by Daniel van Vugt
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Medium
Kevin DuBois
Mir 0.1.2
android-src-vendor (Ubuntu)
Fix Released
Medium
Ricardo Salveti
libhybris (Ubuntu)
Invalid
Medium
Unassigned
mir (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Mir servers crash with SIGSEGV in libhybris-common.so.1 on Nexus7, when using android's hw composer.

gdb ./mir_demo_server_basic
...
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x494e2460 (LWP 7515)]
0x40c0f880 in ?? () from /usr/lib/arm-linux-gnueabihf/libhybris-common.so.1
(gdb) bt
#0 0x40c0f880 in ?? ()
   from /usr/lib/arm-linux-gnueabihf/libhybris-common.so.1
#1 0x41be1dbc in ?? ()
#2 0x41be1dbc in ?? ()
Backtrace stopped: previous frame identical to this frame (corrupt stack?)

This might be the same issue crashing integration-tests.... ?

See original description
Tags: nexus7

Related branches

lp:~kdub/mir/n7-support
Alan Griffiths: Approve
Alexandros Frantzis (community): Needs Fixing
Daniel van Vugt: Approve (manual testing)
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 1174 lines (+277/-420)
12 files modified
include/test/mir_test_doubles/mock_hwc_composer_device_1.h (+10/-2)
src/server/graphics/android/hwc10_device.cpp (+7/-9)
src/server/graphics/android/hwc10_device.h (+3/-0)
src/server/graphics/android/hwc11_device.cpp (+10/-9)
src/server/graphics/android/hwc11_device.h (+3/-5)
src/server/graphics/android/hwc_layerlist.cpp (+81/-102)
src/server/graphics/android/hwc_layerlist.h (+35/-59)
src/server/graphics/android/resource_factory.cpp (+1/-2)
tests/unit-tests/graphics/android/test_hwc10_device.cpp (+5/-8)
tests/unit-tests/graphics/android/test_hwc11_device.cpp (+14/-50)
tests/unit-tests/graphics/android/test_hwc_device.cpp (+13/-40)
tests/unit-tests/graphics/android/test_hwc_layerlist.cpp (+95/-134)
Superseded for merging into lp:mir/0.1
PS Jenkins bot (community): Approve (continuous-integration)
Mir development team: Pending requested
Diff: 20671 lines (+6569/-4994)
329 files modified
3rd_party/android-input/android/CMakeLists.txt (+1/-0)
3rd_party/android-input/android/frameworks/base/include/androidfw/Input.h (+5/-2)
3rd_party/android-input/android/frameworks/base/include/androidfw/InputTransport.h (+10/-7)
3rd_party/android-input/android/frameworks/base/include/androidfw/IntSet.h (+104/-0)
3rd_party/android-input/android/frameworks/base/include/androidfw/VelocityControl.h (+2/-0)
3rd_party/android-input/android/frameworks/base/include/androidfw/VelocityTracker.h (+24/-22)
3rd_party/android-input/android/frameworks/base/services/input/InputDevice.cpp (+6/-3)
3rd_party/android-input/android/frameworks/base/services/input/InputDispatcher.cpp (+40/-33)
3rd_party/android-input/android/frameworks/base/services/input/InputDispatcher.h (+6/-6)
3rd_party/android-input/android/frameworks/base/services/input/InputEventPrinter.h (+138/-0)
3rd_party/android-input/android/frameworks/base/services/input/InputListener.h (+1/-1)
3rd_party/android-input/android/frameworks/base/services/input/InputReader.cpp (+409/-354)
3rd_party/android-input/android/frameworks/base/services/input/InputReader.h (+68/-40)
3rd_party/android-input/android/frameworks/base/services/input/InputTransport.cpp (+8/-8)
3rd_party/android-input/android/frameworks/base/services/input/IntSet.cpp (+123/-0)
3rd_party/android-input/android/frameworks/base/services/input/PointerController.cpp (+5/-8)
3rd_party/android-input/android/frameworks/base/services/input/PointerController.h (+2/-5)
3rd_party/android-input/android/frameworks/base/services/input/VelocityControl.cpp (+2/-2)
3rd_party/android-input/android/frameworks/base/services/input/VelocityTracker.cpp (+80/-83)
CMakeLists.txt (+1/-1)
debian/changelog (+7/-4)
debian/control (+2/-2)
debian/libmirserver11.install (+1/-1)
doc/Doxyfile.in (+192/-82)
doc/building_source_for_android.md (+4/-4)
doc/component_reports.md (+3/-0)
doc/installing_prebuilt_on_pc.md (+2/-2)
doc/using_mir_on_pc.md (+6/-4)
examples/demo-inprocess-surface-client/demo_inprocess_surface_client.cpp (+2/-1)
examples/demo-inprocess-surface-client/inprocess_egl_client.cpp (+12/-11)
examples/demo-inprocess-surface-client/inprocess_egl_client.h (+9/-11)
examples/demo-shell/demo_shell.cpp (+0/-5)
examples/demo-shell/window_manager.cpp (+2/-9)
examples/demo-shell/window_manager.h (+0/-3)
examples/demo_input_filter.cpp (+25/-3)
examples/image_renderer.cpp (+59/-5)
examples/render_surfaces.cpp (+19/-16)
examples/render_to_fb.cpp (+1/-4)
include/client/mir_toolkit/mir_client_library_drm.h (+14/-0)
include/platform/mir/graphics/nested_context.h (+3/-0)
include/server/mir/compositor/buffer_stream.h (+6/-5)
include/server/mir/compositor/scene.h (+3/-6)
include/server/mir/default_configuration_options.h (+2/-0)
include/server/mir/default_server_configuration.h (+10/-1)
include/server/mir/frontend/surface.h (+2/-21)
include/server/mir/shell/application_session.h (+3/-0)
include/server/mir/shell/focus_controller.h (+6/-2)
include/server/mir/shell/session.h (+1/-0)
include/server/mir/shell/session_manager.h (+3/-0)
include/server/mir/shell/surface.h (+16/-68)
include/server/mir/shell/surface_builder.h (+3/-3)
include/server/mir/shell/surface_controller.h (+2/-2)
include/server/mir/surfaces/basic_surface.h (+40/-48)
include/server/mir/surfaces/buffer_stream_factory.h (+3/-4)
include/server/mir/surfaces/surface_controller.h (+6/-6)
include/server/mir/surfaces/surfaces_report.h (+60/-0)
include/shared/mir/input/input_platform.h (+3/-1)
include/shared/mir/input/input_receiver_report.h (+48/-0)
include/shared/mir/input/null_input_receiver_report.h (+46/-0)
include/test/mir_test/draw/android_graphics.h (+1/-1)
include/test/mir_test_doubles/mock_android_framebuffer_window.h (+0/-46)
include/test/mir_test_doubles/mock_buffer_bundle.h (+1/-0)
include/test/mir_test_doubles/mock_buffer_stream.h (+3/-2)
include/test/mir_test_doubles/mock_display_device.h (+6/-6)
include/test/mir_test_doubles/mock_egl.h (+17/-0)
include/test/mir_test_doubles/mock_focus_setter.h (+1/-1)
include/test/mir_test_doubles/mock_frontend_surface.h (+1/-1)
include/test/mir_test_doubles/mock_hwc_composer_device_1.h (+8/-0)
include/test/mir_test_doubles/mock_shell_session.h (+2/-0)
include/test/mir_test_doubles/mock_surface.h (+3/-3)
include/test/mir_test_doubles/mock_surface_controller.h (+1/-1)
include/test/mir_test_doubles/mock_surface_renderer.h (+4/-3)
include/test/mir_test_doubles/mock_surface_state.h (+1/-0)
include/test/mir_test_doubles/null_session_event_sink.h (+1/-1)
include/test/mir_test_doubles/null_snapshot_strategy.h (+1/-1)
include/test/mir_test_doubles/stub_buffer_allocator.h (+1/-9)
include/test/mir_test_doubles/stub_buffer_stream.h (+6/-2)
include/test/mir_test_doubles/stub_display_buffer_factory.h (+75/-0)
include/test/mir_test_doubles/stub_display_device.h (+12/-10)
include/test/mir_test_doubles/stub_driver_interpreter.h (+75/-0)
include/test/mir_test_doubles/stub_ipc_factory.h (+2/-2)
include/test/mir_test_doubles/stub_shell_session.h (+4/-0)
include/test/mir_test_doubles/stub_surface.h (+1/-1)
include/test/mir_test_doubles/stub_surface_builder.h (+12/-6)
include/test/mir_test_doubles/stub_surface_controller.h (+1/-1)
src/client/CMakeLists.txt (+1/-0)
src/client/default_connection_configuration.cpp (+20/-2)
src/client/default_connection_configuration.h (+9/-0)
src/client/logging/input_receiver_report.cpp (+125/-0)
src/client/logging/input_receiver_report.h (+54/-0)
src/client/lttng/CMakeLists.txt (+5/-4)
src/client/mir_client_library.cpp (+29/-8)
src/client/mir_connection.cpp (+16/-0)
src/client/mir_connection.h (+4/-0)
src/platform/graphics/CMakeLists.txt (+0/-1)
src/server/CMakeLists.txt (+2/-1)
src/server/compositor/CMakeLists.txt (+1/-0)
src/server/compositor/buffer_bundle.h (+1/-0)
src/server/compositor/buffer_stream_factory.cpp (+3/-3)
src/server/compositor/buffer_stream_factory.h (+1/-1)
src/server/compositor/buffer_stream_surfaces.cpp (+6/-1)
src/server/compositor/buffer_stream_surfaces.h (+3/-2)
src/server/compositor/bypass.cpp (+2/-2)
src/server/compositor/bypass.h (+3/-3)
src/server/compositor/default_configuration.cpp (+85/-0)
src/server/compositor/default_display_buffer_compositor.cpp (+3/-3)
src/server/compositor/default_display_buffer_compositor_factory.cpp (+3/-3)
src/server/compositor/default_display_buffer_compositor_factory.h (+2/-0)
src/server/compositor/gl_renderer.cpp (+2/-2)
src/server/compositor/gl_renderer.h (+2/-2)
src/server/compositor/gl_renderer_factory.cpp (+1/-1)
src/server/compositor/gl_renderer_factory.h (+1/-1)
src/server/compositor/multi_threaded_compositor.cpp (+1/-1)
src/server/compositor/occlusion.cpp (+1/-1)
src/server/compositor/occlusion.h (+1/-1)
src/server/compositor/renderer.h (+2/-5)
src/server/compositor/rendering_operator.cpp (+2/-3)
src/server/compositor/rendering_operator.h (+2/-2)
src/server/compositor/switching_bundle.cpp (+20/-3)
src/server/compositor/switching_bundle.h (+12/-3)
src/server/default_configuration_options.cpp (+6/-0)
src/server/default_server_configuration.cpp (+0/-672)
src/server/frontend/CMakeLists.txt (+1/-0)
src/server/frontend/default_configuration.cpp (+97/-2)
src/server/frontend/global_event_sender.cpp (+1/-1)
src/server/frontend/global_event_sender.h (+1/-1)
src/server/frontend/protobuf_message_processor.cpp (+1/-1)
src/server/frontend/protobuf_session_creator.cpp (+1/-1)
src/server/frontend/resource_cache.cpp (+1/-1)
src/server/frontend/session_mediator.cpp (+53/-32)
src/server/frontend/session_mediator.h (+4/-1)
src/server/frontend/session_mediator_android.cpp (+1/-1)
src/server/frontend/session_mediator_gbm.cpp (+1/-1)
src/server/frontend/surface.cpp (+1/-16)
src/server/frontend/unauthorized_display_changer.cpp (+5/-6)
src/server/frontend/unauthorized_display_changer.h (+4/-4)
src/server/graphics/CMakeLists.txt (+7/-0)
src/server/graphics/android/CMakeLists.txt (+1/-2)
src/server/graphics/android/android_display.cpp (+52/-12)
src/server/graphics/android/android_display.h (+13/-10)
src/server/graphics/android/android_display_buffer_factory.h (+6/-12)
src/server/graphics/android/android_display_factory.cpp (+0/-96)
src/server/graphics/android/android_display_factory.h (+0/-57)
src/server/graphics/android/android_framebuffer_window.cpp (+0/-78)
src/server/graphics/android/android_framebuffer_window.h (+0/-50)
src/server/graphics/android/android_framebuffer_window_query.h (+0/-44)
src/server/graphics/android/android_platform.cpp (+24/-12)
src/server/graphics/android/android_platform.h (+8/-2)
src/server/graphics/android/display_buffer.cpp (+80/-0)
src/server/graphics/android/display_buffer.h (+60/-0)
src/server/graphics/android/display_buffer_factory.cpp (+66/-90)
src/server/graphics/android/display_buffer_factory.h (+23/-7)
src/server/graphics/android/display_device.h (+7/-8)
src/server/graphics/android/display_resource_factory.h (+16/-14)
src/server/graphics/android/fb_device.cpp (+1/-3)
src/server/graphics/android/fb_device.h (+2/-2)
src/server/graphics/android/hwc10_device.cpp (+10/-13)
src/server/graphics/android/hwc10_device.h (+9/-6)
src/server/graphics/android/hwc11_device.cpp (+55/-12)
src/server/graphics/android/hwc11_device.h (+5/-6)
src/server/graphics/android/hwc_common_device.cpp (+1/-17)
src/server/graphics/android/hwc_common_device.h (+4/-8)
src/server/graphics/android/hwc_layerlist.cpp (+74/-102)
src/server/graphics/android/hwc_layerlist.h (+46/-59)
src/server/graphics/android/resource_factory.cpp (+63/-60)
src/server/graphics/android/resource_factory.h (+24/-23)
src/server/graphics/android/server_render_window.cpp (+2/-2)
src/server/graphics/android/server_render_window.h (+3/-3)
src/server/graphics/default_configuration.cpp (+146/-0)
src/server/graphics/default_display_configuration_policy.cpp (+6/-6)
src/server/graphics/default_display_configuration_policy.h (+3/-6)
src/server/graphics/gbm/native_gbm_platform.cpp (+1/-0)
src/server/graphics/nested/host_connection.cpp (+3/-3)
src/server/graphics/nested/host_connection.h (+1/-1)
src/server/graphics/nested/nested_display.cpp (+30/-20)
src/server/graphics/nested/nested_display.h (+1/-1)
src/server/graphics/nested/nested_platform.cpp (+11/-2)
src/server/graphics/nested/nested_platform.h (+1/-1)
src/server/input/CMakeLists.txt (+1/-0)
src/server/input/android/dummy_android_pointer_controller.h (+2/-4)
src/server/input/default_configuration.cpp (+128/-0)
src/server/input/display_input_region.cpp (+1/-1)
src/server/input/event_filter_chain.cpp (+1/-1)
src/server/input/nested_input_configuration.cpp (+2/-2)
src/server/input/nested_input_relay.cpp (+1/-1)
src/server/input/null_input_configuration.cpp (+1/-1)
src/server/logging/CMakeLists.txt (+2/-0)
src/server/logging/connector_report.cpp (+1/-1)
src/server/logging/default_configuration.cpp (+112/-0)
src/server/logging/display_report.cpp (+4/-3)
src/server/logging/session_mediator_report.cpp (+1/-1)
src/server/logging/surfaces_report.cpp (+119/-0)
src/server/logging/surfaces_report.h (+56/-0)
src/server/lttng/CMakeLists.txt (+5/-4)
src/server/shell/CMakeLists.txt (+1/-3)
src/server/shell/application_session.cpp (+1/-1)
src/server/shell/broadcasting_session_event_sink.cpp (+1/-1)
src/server/shell/broadcasting_session_event_sink.h (+2/-2)
src/server/shell/consuming_placement_strategy.cpp (+1/-1)
src/server/shell/default_configuration.cpp (+202/-0)
src/server/shell/default_focus_mechanism.cpp (+1/-1)
src/server/shell/default_focus_mechanism.h (+1/-1)
src/server/shell/default_session_container.cpp (+1/-1)
src/server/shell/gl_pixel_buffer.cpp (+1/-1)
src/server/shell/gl_pixel_buffer.h (+1/-1)
src/server/shell/graphics_display_layout.cpp (+1/-1)
src/server/shell/mediating_display_changer.cpp (+2/-2)
src/server/shell/organising_surface_factory.cpp (+1/-1)
src/server/shell/registration_order_focus_sequence.cpp (+1/-1)
src/server/shell/registration_order_focus_sequence.h (+1/-1)
src/server/shell/session_manager.cpp (+3/-3)
src/server/shell/threaded_snapshot_strategy.cpp (+2/-2)
src/server/shell/threaded_snapshot_strategy.h (+1/-1)
src/server/surfaces/CMakeLists.txt (+4/-0)
src/server/surfaces/default_configuration.cpp (+111/-0)
src/server/surfaces/mutable_surface_state.h (+1/-0)
src/server/surfaces/surface.cpp (+33/-9)
src/server/surfaces/surface.h (+81/-0)
src/server/surfaces/surface_allocator.cpp (+10/-8)
src/server/surfaces/surface_allocator.h (+6/-3)
src/server/surfaces/surface_controller.cpp (+4/-4)
src/server/surfaces/surface_data.cpp (+10/-0)
src/server/surfaces/surface_data.h (+1/-0)
src/server/surfaces/surface_factory.h (+2/-2)
src/server/surfaces/surface_impl.cpp (+37/-29)
src/server/surfaces/surface_impl.h (+110/-0)
src/server/surfaces/surface_source.cpp (+6/-9)
src/server/surfaces/surface_source.h (+13/-10)
src/server/surfaces/surface_stack.cpp (+33/-18)
src/server/surfaces/surface_stack.h (+11/-8)
src/server/surfaces/surface_stack_model.h (+4/-4)
src/server/surfaces/surfaces_report.cpp (+27/-0)
src/shared/input/android/android_input_platform.cpp (+11/-3)
src/shared/input/android/android_input_platform.h (+4/-1)
src/shared/input/android/android_input_receiver.cpp (+9/-2)
src/shared/input/android/android_input_receiver.h (+7/-2)
tests/acceptance-tests/CMakeLists.txt (+1/-0)
tests/acceptance-tests/test_client_input.cpp (+2/-2)
tests/acceptance-tests/test_client_library_drm.cpp (+59/-0)
tests/acceptance-tests/test_display_configuration.cpp (+3/-17)
tests/acceptance-tests/test_focus_selection.cpp (+3/-3)
tests/acceptance-tests/test_server_shutdown.cpp (+15/-10)
tests/acceptance-tests/test_surfaces_with_output_id.cpp (+1/-1)
tests/integration-tests/compositor/test_buffer_stream.cpp (+77/-5)
tests/integration-tests/compositor/test_swapping_swappers.cpp (+1/-1)
tests/integration-tests/graphics/android/test_display_integration.cpp (+36/-105)
tests/integration-tests/graphics/android/test_internal_client.cpp (+16/-9)
tests/integration-tests/graphics/gbm/test_buffer_integration.cpp (+6/-10)
tests/integration-tests/shell/test_session.cpp (+8/-19)
tests/integration-tests/shell/test_session_manager.cpp (+5/-6)
tests/integration-tests/test_display_info.cpp (+7/-13)
tests/integration-tests/test_drm_auth_magic.cpp (+2/-17)
tests/integration-tests/test_error_reporting.cpp (+2/-2)
tests/integration-tests/test_surface_first_frame_sync.cpp (+3/-3)
tests/integration-tests/test_surfaceloop.cpp (+9/-20)
tests/integration-tests/test_swapinterval.cpp (+7/-6)
tests/mir-stress/src/client.h (+1/-1)
tests/mir_test_doubles/mock_egl.cpp (+1/-1)
tests/mir_test_framework/testing_server_options.cpp (+9/-14)
tests/unit-tests/android_input/CMakeLists.txt (+1/-0)
tests/unit-tests/android_input/input_reader.cpp (+156/-98)
tests/unit-tests/android_input/int_set.cpp (+133/-0)
tests/unit-tests/client/input/test_android_input_receiver.cpp (+8/-5)
tests/unit-tests/client/input/test_android_input_receiver_thread.cpp (+5/-2)
tests/unit-tests/client/test_client_mir_surface.cpp (+1/-1)
tests/unit-tests/client/test_mir_connection.cpp (+48/-1)
tests/unit-tests/compositor/test_buffer_stream.cpp (+14/-3)
tests/unit-tests/compositor/test_default_display_buffer_compositor.cpp (+5/-5)
tests/unit-tests/compositor/test_gl_renderer.cpp (+4/-4)
tests/unit-tests/compositor/test_multi_threaded_compositor.cpp (+1/-1)
tests/unit-tests/compositor/test_rendering_operator.cpp (+2/-3)
tests/unit-tests/compositor/test_switching_bundle.cpp (+149/-22)
tests/unit-tests/frontend/CMakeLists.txt (+1/-0)
tests/unit-tests/frontend/stress_protobuf_communicator.cpp (+1/-1)
tests/unit-tests/frontend/test_global_event_sender.cpp (+1/-1)
tests/unit-tests/frontend/test_protobuf_reports_errors.cpp (+1/-1)
tests/unit-tests/frontend/test_protobuf_sends_fds.cpp (+1/-1)
tests/unit-tests/frontend/test_protobuf_surface_apis.cpp (+1/-1)
tests/unit-tests/frontend/test_published_socket_connector.cpp (+1/-1)
tests/unit-tests/frontend/test_resource_cache.cpp (+1/-1)
tests/unit-tests/frontend/test_session_mediator.cpp (+6/-12)
tests/unit-tests/frontend/test_session_mediator_android.cpp (+4/-18)
tests/unit-tests/frontend/test_session_mediator_gbm.cpp (+5/-19)
tests/unit-tests/frontend/test_unauthorized_display_changer.cpp (+3/-4)
tests/unit-tests/graphics/android/CMakeLists.txt (+2/-3)
tests/unit-tests/graphics/android/test_android_display_factory.cpp (+0/-210)
tests/unit-tests/graphics/android/test_android_fb.cpp (+179/-499)
tests/unit-tests/graphics/android/test_android_framebuffer_window.cpp (+0/-283)
tests/unit-tests/graphics/android/test_android_platform.cpp (+7/-4)
tests/unit-tests/graphics/android/test_display_buffer_factory.cpp (+214/-0)
tests/unit-tests/graphics/android/test_fb_device.cpp (+35/-34)
tests/unit-tests/graphics/android/test_hwc10_device.cpp (+27/-47)
tests/unit-tests/graphics/android/test_hwc11_device.cpp (+75/-47)
tests/unit-tests/graphics/android/test_hwc_device.cpp (+30/-88)
tests/unit-tests/graphics/android/test_hwc_display.cpp (+115/-94)
tests/unit-tests/graphics/android/test_hwc_layerlist.cpp (+99/-134)
tests/unit-tests/graphics/android/test_resource_factory.cpp (+65/-73)
tests/unit-tests/graphics/android/test_server_interpreter.cpp (+16/-18)
tests/unit-tests/graphics/gbm/test_gbm_display.cpp (+2/-2)
tests/unit-tests/graphics/gbm/test_gbm_display_configuration.cpp (+1/-1)
tests/unit-tests/graphics/gbm/test_gbm_display_multi_monitor.cpp (+1/-1)
tests/unit-tests/graphics/gbm/test_native_gbm_platform.cpp (+12/-0)
tests/unit-tests/graphics/test_default_display_configuration_policy.cpp (+1/-1)
tests/unit-tests/graphics/test_display.cpp (+12/-26)
tests/unit-tests/input/android/test_android_input_lexicon.cpp (+14/-0)
tests/unit-tests/input/test_display_input_region.cpp (+1/-1)
tests/unit-tests/input/test_event_filter_chain.cpp (+1/-1)
tests/unit-tests/logging/test_display_report.cpp (+3/-2)
tests/unit-tests/options/test_program_option.cpp (+4/-4)
tests/unit-tests/shell/CMakeLists.txt (+0/-3)
tests/unit-tests/shell/test_broadcasting_session_event_sink.cpp (+1/-1)
tests/unit-tests/shell/test_consuming_placement_strategy.cpp (+1/-1)
tests/unit-tests/shell/test_default_focus_mechanism.cpp (+3/-3)
tests/unit-tests/shell/test_gl_pixel_buffer.cpp (+1/-1)
tests/unit-tests/shell/test_graphics_display_layout.cpp (+1/-1)
tests/unit-tests/shell/test_mediating_display_changer.cpp (+2/-2)
tests/unit-tests/shell/test_organising_surface_factory.cpp (+1/-1)
tests/unit-tests/shell/test_registration_order_focus_sequence.cpp (+3/-3)
tests/unit-tests/shell/test_session_manager.cpp (+8/-8)
tests/unit-tests/shell/test_the_session_container_implementation.cpp (+2/-2)
tests/unit-tests/shell/test_threaded_snapshot_strategy.cpp (+2/-2)
tests/unit-tests/surfaces/CMakeLists.txt (+1/-0)
tests/unit-tests/surfaces/test_surface.cpp (+70/-19)
tests/unit-tests/surfaces/test_surface_allocator.cpp (+1/-1)
tests/unit-tests/surfaces/test_surface_controller.cpp (+6/-6)
tests/unit-tests/surfaces/test_surface_data.cpp (+18/-0)
tests/unit-tests/surfaces/test_surface_impl.cpp (+39/-33)
tests/unit-tests/surfaces/test_surface_stack.cpp (+83/-36)
tools/setup-partial-armhf-chroot.sh (+17/-17)
lp:ubuntu/trusty-proposed/mir
Revision history for this message
Kevin DuBois (kdub) wrote :

old nexus 7 (nvidia hardware) or new nexus 7 (qcom hardware)?

it might be that the hwc isn't working for the nexus 7. You can try to mv /system/lib/hw/hwcomposer.* out of that directory, which will force mir into a backup composition mode.

Revision history for this message
Pete Woods (pete-woods) wrote :

Thanks for the suggestion, Kevin. Unfortunately this doesn't seem to help. :(

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in libhybris (Ubuntu):
status: New → Confirmed
Revision history for this message
Pete Woods (pete-woods) wrote :

I should note that is old Nexus hardware (i.e. tegra3).

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Yes, old Nexus 7 (Tegra 3).

Changed in mir:
status: New → Confirmed
importance: Undecided → Low
Changed in libhybris (Ubuntu):
importance: Undecided → Low
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

I did a quick check, and noticed that it crashes in my_pthread_mutex_lock, a hybris hook for the original pthread_mutex_lock.

The problem is that the mutex used (__mutex) contains an anddress that's not part of the mapped memory region for the process, causing a segfault when we try to access the content of such variable.

To make things even more complicated, the call is originated by /system/lib/hw/gralloc.tegra3.so, and if you also refuse to handle the lock, it'll crash inside the library later on.

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Seems to be related with the hwcomposer, as after removing /system/lib/hw/hwcomposer.tegra3.so I'm able to start mir_demo and run a few examples.

Unity8 is crashing still it seems, still debugging.

Daniel van Vugt (vanvugt)
Changed in mir:
importance: Low → Medium
Changed in libhybris (Ubuntu):
importance: Low → Medium
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Ok, the other unity8 related crash was because we didn't had the permissions set right. Will be pushing a change to lxc-android-config to get that fixed.

Also uploading a new android package without the hwcomposer for grouper, until we're able to ignore it from Mir itself (could use getprop to check if grouper, and not load it).

Hopefully tomorrow we should have an image which is capable of running Mir. There's still one rendering issue when opening apps and moving back to the shell, but will report that properly once the image is out.

Ricardo Salveti (rsalveti)
summary: - Mir servers crash with SIGSEGV in libhybris-common.so.1 on Nexus7
+ Mir servers crash with SIGSEGV in libhybris-common.so.1 on Nexus7 when
+ using the hwcomposer (tegra3)
Revision history for this message
Pete Woods (pete-woods) wrote :

Update: unity appears to no-longer crash on startup when using Mir on my Nexus 7.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Seems to be fixed in:

libhybris (0.1.0+git20130606+c5d897a-0ubuntu33) saucy; urgency=low

Changed in mir:
status: Confirmed → Invalid
Changed in libhybris (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Marking as valid still as it happens when using the android hwcomposper.

Changed in mir:
status: Invalid → Confirmed
Changed in libhybris (Ubuntu):
status: Fix Released → Confirmed
description: updated
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

OK, but why reopen for Mir? What needs fixing in Mir?

Changed in mir:
status: Confirmed → Incomplete
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

After a bit of more investigation, this actually seems to be a bug in the way Mir is using the hwcomposer interface (not using the 2 layers, and also with a different init/flags set).

The crash happens because it tries to use a pthread_mutex that is not initialized. From our current investigation nothing is calling/using this pthread_mutex before the crash, so it's probably due a different code path used with Mir.

Changed in mir:
status: Incomplete → Confirmed
assignee: nobody → Kevin DuBois (kdub)
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Assigned to kdub as he's currently investigating the issue.

Revision history for this message
Kevin DuBois (kdub) wrote :

the issue was that the hwcomposer was relying on HWC_GEOMETRY_CHANGED flag to do some initialization of its internal data structures (including some pthread mutexes). Mir was not setting this flag leaving those mutexes uninitialized. When hwc tried to lock the uninitialized mutexes, we would segfault in hybris at that point.

Fixed by
1) setting HWC_GEOMETRY_CHANGED during posting
2) submitting a skipped gles layer to force posting everytime.

branch with fix is linked

Changed in mir:
status: Confirmed → In Progress
Revision history for this message
Kevin DuBois (kdub) wrote :

for the reports about 'my nexus 7 works'....

In mir, we first try to load the HWC display mechanism, and then, if we can't load HWC, we load an alternative display mechanism (FB)

We saw that the HWC was segfaulting, so we removed hwcomposer.tegra3.so from the build. This forced FB composition.
After the fix lands, we can safely add back hwcomposer.tegra3.so to the build.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I assume "FB composition" is not desirable, and slower... ?

Changed in mir:
milestone: none → 0.1.2
Kevin DuBois (kdub)
Changed in mir:
status: In Progress → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → Fix Released
Changed in libhybris (Ubuntu):
status: Confirmed → Triaged
Changed in mir (Ubuntu):
status: New → Triaged
importance: Undecided → High
importance: High → Medium
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Adding bug task to android-src-vendor so we can add hwcomposer.tegra3.so back once latest mir is available in the archive.

Changed in libhybris (Ubuntu):
status: Triaged → Invalid
Changed in android-src-vendor (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Ricardo Salveti (rsalveti)
Daniel van Vugt (vanvugt)
Changed in mir (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.3 KiB)

This bug was fixed in the package mir - 0.1.2+14.04.20131128.1-0ubuntu1

---------------
mir (0.1.2+14.04.20131128.1-0ubuntu1) trusty; urgency=low

  [ Kevin Gunn ]
  * New upstream release 0.1.2
    - graphics: android: improve interface for mga::DisplayDevice so its
      just concerned with rendering and posting.
    - surfaces: rename "surfaces" component to "scene".
    - surfaces, shell: Migrate Session data model from shell to surfaces.
    - graphics: change fill_ipc_package() to use real pointers.
    - mir_client_library.h: Fix typo "do and locking" should be "do any
      locking".
    - API enumerations cleanup: Remove slightly misleading *_enum_max_
      values, and replace them with more accurate plural forms.
    - test_android_communication_package: Do not expect opened fd to be >0,
      we may have closed stdin making this a valid value (LP: #1247718).
    - Update docs about running Mir on the desktop to mention new package
      ubuntu-desktop-mir.
    - offscreen: Add a display that renders its output to offscreen buffers
    - graphics: android: fix regression for hwc1.0 devices introduced in r1228
      (LP: #1252433).
    - OffscreenPlatform provides the services that the offscreen display
      needs from the Platform.
    - graphics: android: consolidate the GLContexts classes in use.
    - Fix uninitialized variable causing random drm_auth_magic test
      failures. (LP: #1252144).
    - Add a fullyish functional Udev wrapper. This currently sits in
      graphics/gbm, but will be moved to the top-level when input device
      detection migrates.
    - Add resizing support to example code; demo-shell and clients.
    - eglapp: Clarify messages about pixel formats (LP: #1168304).
    - Adds support to the MirMotionEvent under pointer_coordinates called
      tool_type. This will allow clients to tell what type of tool is
      being used, from mouse/finger/etc. (LP: #1252498)
    - client,frontend: Report the real available surface pixel formats to
      clients. (LP: #1240833)
    - graphics: android: 1) change hwc1.1 to make use of sync fences during
      the compositor's gl renderloop. Note that we no longer wait for the
      render to complete, we pass this responsibility to the driver and the
      kernel. 2) support nexus 10. (LP: #1252173) (LP: #1203268)
    - shell: don't publish SurfacesContainer - it can be private to shell.
    - gbm: Don't mess up the VT mode on setup failure Only restore the
      previous VT mode during shutdown if it was VT_AUTO.
    - Fix a crash due to a failed eglMakeCurrent() call when in nested mode.
    - shell: unity-mir uses shell::FocusSetter - make the header public again
    - Add resize support to client surfaces (mir::client::MirSurface).
    - graphics: android: support 'old aka 2012' nexus 7 hwc (nvidia tegra3
      SoC) better. (LP: #1231917)
    - Add resize support to *ClientBuffer classes. Now always get dimensions
      from the latest buffer package.
    - android: support driver hooks for the Mali T604 (present in nexus 10)
    - Add width and height to the protocol Buffer messages, in preparation
      for resizable surfaces.
    - surfaces, shell, logging, te...

Read more...

Changed in mir (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

android-src-vendor (5-0ubuntu1) trusty; urgency=medium

  * Adding back hwcompositor for grouper as it's now compatible with
    MIR

 -- Ricardo Salveti de Araujo <email address hidden> Tue, 14 Jan 2014 22:40:23 -0200

Changed in android-src-vendor (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.