[mir] key events not working through input devices (aka volume up/down)

Bug #1233245 reported by Loïc Minier
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mir
Invalid
Critical
Robert Carr
Ubuntu File Manager App
Invalid
Undecided
Unassigned
unity-mir
Fix Released
Critical
Robert Carr
qtubuntu (Ubuntu)
Fix Released
Undecided
Robert Carr
unity-mir (Ubuntu)
Fix Released
Undecided
Unassigned
unity8 (Ubuntu)
Invalid
High
Michał Sawicz

Bug Description

Hi,

Volume up / down works under SF, but not under Mir.

Cheers,

Related branches

Loïc Minier (lool)
Changed in unity8 (Ubuntu):
assignee: nobody → Michał Sawicz (saviq)
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
status: New → Confirmed
kevin gunn (kgunn72)
Changed in unity8 (Ubuntu):
status: Confirmed → Triaged
importance: Undecided → High
milestone: none → ubuntu-13.10
Changed in unity8:
milestone: none → phone-v1-freeze
importance: Undecided → High
status: New → Triaged
Michał Sawicz (saviq)
Changed in unity8:
assignee: nobody → Nick Dedekind (nick-dedekind)
Changed in unity8 (Ubuntu):
assignee: Michał Sawicz (saviq) → nobody
Michał Sawicz (saviq)
summary: - Volume up/down keys not working in music-app with Mir
+ Volume up/down keys not working with Mir
description: updated
Revision history for this message
Michał Sawicz (saviq) wrote : Re: Volume up/down keys not working with Mir

OK so we're not getting VolumeUp or VolumeDown at all in the shell. Affecting Mir, as we'll need it to work there. Potentially unity-mir, too?

Changed in unity8:
assignee: Nick Dedekind (nick-dedekind) → Michał Sawicz (saviq)
Michał Sawicz (saviq)
Changed in unity8:
status: Triaged → Incomplete
Changed in unity8 (Ubuntu):
status: Triaged → Incomplete
Revision history for this message
Michał Sawicz (saviq) wrote : Re: [mir] key events not working through input devices

This is causing autopilot failures as well.

summary: - Volume up/down keys not working with Mir
+ [mir] key events not working through input devices
Changed in unity-mir:
assignee: nobody → Daniel d'Andrada (dandrader)
status: New → In Progress
importance: Undecided → High
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

The volume keys are working fine for me

Just flashed my galaxy nexus with image 80.
Opened the "sound" panel in unity8 and pressed volume keys up and down. The volume slider moves accordingly.

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Maybe the fix for bug 1233944 also fixed this one...

no longer affects: unity-mir
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Ignore my two previous updates. I was running under SurfaceFlinger. Sorry for the noise.

Changed in mir:
assignee: nobody → Daniel d'Andrada (dandrader)
status: New → In Progress
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

[DD, android-input] [EventHub]/dev/input/event2 got: t0=1276, t1=686553, type=1, code=114, value=1
[DD, android-input] [EventHub]/dev/input/event2 got: t0=1276, t1=686553, type=0, code=0, value=0
[II, android-input] [InputDispatcher]Dropping event because there is no focused window or focused application.

So key events (volume up/down) are received correctly by android-input in mir but not being forwarded to unity8 or any app.

Changed in unity-mir:
status: New → In Progress
assignee: nobody → Daniel d'Andrada (dandrader)
kevin gunn (kgunn72)
Changed in unity-mir:
importance: Undecided → Critical
summary: - [mir] key events not working through input devices
+ [mir] key events not working through input devices (aka volume up/down)
Changed in mir:
importance: Undecided → Critical
Changed in unity-mir:
milestone: none → phone-v1-freeze
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Passing the bug to Robert Carr, now that it's about fixing the focus in unity8-mir. I.e. making unity8 focused when it's on foreground.
Since it will take me quite a bit to wrap my head around all those mir interfaces regarding focus and we want this fix for yesterday, I believe Robert (author of a good deal of this mir focus code) will be able to get it fixed waaaay faster than myself.

Changed in mir:
assignee: Daniel d'Andrada (dandrader) → Robert Carr (robertcarr)
status: In Progress → New
Changed in unity-mir:
assignee: Daniel d'Andrada (dandrader) → Robert Carr (robertcarr)
status: In Progress → Triaged
Changed in mir:
status: New → Triaged
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I'm reluctant to say Triaged in Mir because that means mir-team understands what needs fixing in Mir. I certainly don't, but assume that racarr does.

Changed in mir:
status: Triaged → In Progress
Changed in unity-mir:
status: Triaged → In Progress
Changed in mir:
status: In Progress → Incomplete
status: Incomplete → Triaged
Michał Sawicz (saviq)
Changed in qtubuntu:
status: New → In Progress
assignee: nobody → Robert Carr (robertcarr)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:qtubuntu at revision 184, scheduled for release in qtubuntu, milestone ubuntu-13.05

Changed in qtubuntu:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in qtubuntu (Ubuntu):
status: New → Confirmed
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity-mir at revision 102, scheduled for release in unity-mir, milestone phone-v1-freeze

Changed in unity-mir:
status: In Progress → Fix Committed
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
status: Incomplete → Invalid
Changed in unity8:
status: Incomplete → Invalid
Changed in qtubuntu (Ubuntu):
status: Confirmed → Fix Committed
Changed in unity-mir (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtubuntu - 0.52+13.10.20131008-0ubuntu1

---------------
qtubuntu (0.52+13.10.20131008-0ubuntu1) saucy; urgency=low

  [ Loïc Minier ]
  * Add Vcs-Bzr field with lp:qtubuntu.

  [ Robert Carr ]
  * Map the volume up and down keys to keysyms in mir. (LP: #1233245)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 184
 -- Ubuntu daily release <email address hidden> Tue, 08 Oct 2013 12:14:42 +0000

Changed in qtubuntu (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-mir - 0.1+13.10.20131008.2-0ubuntu1

---------------
unity-mir (0.1+13.10.20131008.2-0ubuntu1) saucy; urgency=low

  [ Ricardo Mendoza ]
  * Add support for upstart-app-launch to request application resume &
    focus. This revealed extra work: prevent unexpected focus events
    propagating to shell, fix lifecycle bug and add workaround for
    handling of non-application sessions (like QtWebProcess and maliit).
    (LP: #1228345)
  * Make shell surface be an input monitor. (LP: #1236736, #1231713,
    #1233245)
  * Make sure we dont lose focus on the currently focused application
    when dismissing an invalid session startup. (LP: #1236789)

  [ Daniel d'Andrada ]
  * Do not let touches meant for the OSK hit the Shell components behind
    it. (LP: #1236773)

  [ Michał Sawicz ]
  * Map rect to scene in setMirInputArea and set the geometry onEnabled.
    (LP: #1235383, #1235215)
  * Focus the shell when no sessions are focused. It's difficult with
    the current architecture for the shell to receive keyboard focus, as
    it does not have an associated application session. Work around this
    by implementing a defaulting FocusSetter, which assigns keyboard
    focus to the shell surface when focus would otherwise be cleared.

  [ Robert Carr ]
  * Focus the shell when no sessions are focused. It's difficult with
    the current architecture for the shell to receive keyboard focus, as
    it does not have an associated application session. Work around this
    by implementing a defaulting FocusSetter, which assigns keyboard
    focus to the shell surface when focus would otherwise be cleared.

  [ Gerry Boland ]
  * Add support for upstart-app-launch to request application resume &
    focus. This revealed extra work: prevent unexpected focus events
    propagating to shell, fix lifecycle bug and add workaround for
    handling of non-application sessions (like QtWebProcess and maliit).
    (LP: #1228345)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 105
 -- Ubuntu daily release <email address hidden> Tue, 08 Oct 2013 19:14:08 +0000

Changed in unity-mir (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Incomplete for Mir. Does Mir need fixing for this?

Changed in mir:
status: Triaged → Incomplete
Michał Sawicz (saviq)
Changed in mir:
status: Incomplete → Invalid
Changed in ubuntu-filemanager-app:
status: New → Invalid
Changed in qtubuntu:
status: Fix Committed → Fix Released
Changed in unity-mir:
status: Fix Committed → Fix Released
status: Fix Released → In Progress
status: In Progress → Fix Committed
status: Fix Committed → Fix Released
Michał Sawicz (saviq)
Changed in qtubuntu (Ubuntu):
assignee: nobody → Robert Carr (robertcarr)
no longer affects: qtubuntu
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
assignee: nobody → Michał Sawicz (saviq)
no longer affects: unity8
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.