Reporter: links are broken Combined Aged and Active Circ -> Patron profle/Home library

We were able to fix this at C/W MARS by including the following links in the combcirc data source:

<link field="usr_home_ou" reltype="has_a" key="id" map="" class="aou"/>
<link field="usr_profile" reltype="has_a" key="id" map="" class="pgt"/>

In the end the entire fm_IDL entry looked like this:

<class id="combcirc" controller="open-ils.cstore" oils_obj:fieldmapper="action::all_circulation" oils_persist:tablename="action.all_circulation" reporter:core="true" reporter:label="Combined Aged and Active Circulations" oils_persist:readonly="true">
  <fields oils_persist:primary="id" oils_persist:sequence="money.billable_xact_id_seq">
   <field reporter:label="Check In Library" name="checkin_lib" reporter:datatype="org_unit"/>
   <field reporter:label="Check In Staff" name="checkin_staff" reporter:datatype="link"/>
   <field reporter:label="Check In Date/Time" name="checkin_time" reporter:datatype="timestamp"/>
   <field reporter:label="Circulating Library" name="circ_lib" reporter:datatype="org_unit"/>
   <field reporter:label="Circulating Staff" name="circ_staff" reporter:datatype="link"/>
   <field reporter:label="Desk Renewal" name="desk_renewal" reporter:datatype="bool"/>
   <field reporter:label="Due Date/Time" name="due_date" reporter:datatype="timestamp"/>
   <field reporter:label="Circulation Duration" name="duration" reporter:datatype="interval"/>
   <field reporter:label="Circ Duration Rule" name="duration_rule" reporter:datatype="link"/>
   <field reporter:label="Fine Interval" name="fine_interval" reporter:datatype="interval"/>
   <field reporter:label="Circ ID" name="id" reporter:datatype="id" />
   <field reporter:label="Max Fine Amount" name="max_fine" reporter:datatype="money" />
   <field reporter:label="Max Fine Rule" name="max_fine_rule" reporter:datatype="link"/>
   <field reporter:label="OPAC Renewal" name="opac_renewal" reporter:datatype="bool"/>
   <field reporter:label="Phone Renewal" name="phone_renewal" reporter:datatype="bool"/>
   <field reporter:label="Recurring Fine Amount" name="recurring_fine" reporter:datatype="money" />
   <field reporter:label="Recurring Fine Rule" name="recurring_fine_rule" reporter:datatype="link"/>
   <field reporter:label="Remaining Renewals" name="renewal_remaining" reporter:datatype="int" />
   <field reporter:label="Grace Period" name="grace_period" reporter:datatype="interval" />
   <field reporter:label="Fine Stop Reason" name="stop_fines" reporter:datatype="text"/>
   <field reporter:label="Fine Stop Date/Time" name="stop_fines_time" reporter:datatype="timestamp"/>
   <field reporter:label="Circulating Item" name="target_copy" reporter:datatype="link"/>
   <field reporter:label="Patron ZIP" name="usr_post_code" reporter:datatype="text"/>
   <field reporter:label="Transaction Finish Date/Time" name="xact_finish" reporter:datatype="timestamp" />
   <field reporter:label="Checkout Date/Time" name="xact_start" reporter:datatype="timestamp" />
   <field reporter:label="Record Creation Date/Time" name="create_time" reporter:datatype="timestamp" />
   <field reporter:label="Transaction Billings" name="billings" oils_persist:virtual="true" reporter:datatype="link"/>
   <field reporter:label...

Discovered this issue in our 2.9 system. I added Codey's fix to a working branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=6ae5890dd70bafe616839a2502821fb41732fea5

I have tested this code and consent to signing off on it with my name, Jeanette Lundgren and my email address, <email address hidden>

Force pushed a commit to change the author to Codey Kolasinski. Here's the link to the branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/LP_1234932_Fix_broken_links_in_combcirc

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Codey Kolasinski <email address hidden>

Thank you Michele, Codey and Jeanette! Signed off and merged to master, 2.10 and 2.9.