fix legacy keygrabber for gnome-ish sessions

Bug #1235625 reported by Tim Lunn
42
This bug affects 6 people
Affects Status Importance Assigned to Milestone
gnome-settings-daemon (Ubuntu)
Fix Released
Undecided
Unassigned
Saucy
Fix Released
Undecided
Unassigned

Bug Description

[ Description ]

In Saucy, media keys in gnome-ish (using gnome-settings-daemon) sessions only work when gnome-panel or Unity are in use, as the code path checks for their names on the bus. They ought to work for all sessions.

[ Fix ]

Change the logic so that the keygrabber is started all the time except under Shell sessions.

[ QA ]

In a session that runs gnome-settings-daemon but neither panel nor shell (xfce or Openbox? or a custom xmonad), check that media keys now work.

[ Regression potential ]

Changes activation criteria for the legacy keygrabber. Check it still works in Unity, panel and that the new method works under shell.

[ Original report ]

The previous patch to fix the legacy keygrabber was Unity specific and breaks on gnome-ish sessions that require it, instead we should load the legacy keygrabber for any session that is not gnome-shell

Tim Lunn (darkxst)
tags: added: saucy
Tim Lunn (darkxst)
Changed in gnome-settings-daemon (Ubuntu):
status: New → In Progress
assignee: nobody → Tim (darkxst)
Revision history for this message
Tim Lunn (darkxst) wrote :
Changed in gnome-settings-daemon (Ubuntu):
assignee: Tim (darkxst) → nobody
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "gsd-3.8.5-7.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Thanks Tim for fixing it, I can confirm that shortcuts now work fine in GNOME Flashback session.

William has filed a MP against gnome-settings-daemon (lp:~attente/gnome-settings-daemon/non-latin-media-keys), that touches the same file (gsd-media-keys-manager.c), your changes don't conflict so I think it will make sense to upload both at the same time.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-settings-daemon - 3.8.5-0ubuntu7

---------------
gnome-settings-daemon (3.8.5-0ubuntu7) saucy; urgency=low

  [ Ikuya Awashiro ]
  * debian/patches/series:
    - removed git_revert_hardcoded_input_methods.patch.
     - Hard coded input methods required for some language. (lp: #1230265)

  [ Tim ]
  * debian/patches/fix_media_keys_on_unity.patch: Revise patch to load
    legacy keygrabber for all non-gnome-shell sessions (LP: #1235625)

  [ Iain Lane ]
  * Rename on_unity_appeared in the above patch.
 -- Iain Lane <email address hidden> Mon, 07 Oct 2013 17:06:51 +0100

Changed in gnome-settings-daemon (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Hans-Christian Noren Egtvedt (egtvedt) wrote :

Verified to work on my system running gnome-session-flashback. Both media keys and ctrl+alt+t to open new terminals behave as expected now.

Revision history for this message
Spyou (nicolas-alpi) wrote :

Doesn't seems to work on my Openbox session :(

None of the shortcuts or media key works now.

Iain Lane (laney)
description: updated
Revision history for this message
Iain Lane (laney) wrote :

I haven't heard anything bad about the fix in Trusty, so let's try to give it to Saucy users too. Uploaded a fix for non-{panel,unity,shell} environments to saucy-proposed.

Changed in gnome-settings-daemon (Ubuntu Saucy):
status: New → In Progress
Revision history for this message
Stéphane Graber (stgraber) wrote : Please test proposed package

Hello Tim, or anyone else affected,

Accepted gnome-settings-daemon into saucy-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/gnome-settings-daemon/3.8.5-0ubuntu11.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in gnome-settings-daemon (Ubuntu Saucy):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Iain Lane (laney) wrote :

Could someone on 13.10 running one of the environments targeted by this fix please try it out and confirm whether it works or not?

Revision history for this message
Robin Sheat (eythian) wrote :

Can confirm that this takes play/pause and volume from not working to working under xmonad.

Iain Lane (laney)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Colin Watson (cjwatson) wrote : Update Released

The verification of the Stable Release Update for gnome-settings-daemon has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-settings-daemon - 3.8.5-0ubuntu11.2

---------------
gnome-settings-daemon (3.8.5-0ubuntu11.2) saucy; urgency=low

  * debian/patches/fix_media_keys_on_unity.patch: Another reworking. Try to
    start the legacy keygrabber all the time. Only don't if we're running
    shell. Should fix keygrabber in environments without panel or Unity. (LP:
    #1235625)
 -- Iain Lane <email address hidden> Mon, 25 Nov 2013 11:10:21 +0000

Changed in gnome-settings-daemon (Ubuntu Saucy):
status: Fix Committed → Fix Released
Revision history for this message
Edward Z. Yang (ezyang) wrote :

Hey guys, it looks like in Utopic the legacy keygrabber has been gutted entirely. What should we do now if we run an alternate window manager?

Revision history for this message
Tim Lunn (darkxst) wrote :

Edward,
    Sessions that require the legacy keygrabber should be using unity-settings-daemon which does have that still (it was forked from gnome-settings-daemon 3.8)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.