Ubuntu
software-properties package

shouldn't use deprecated gtk-logout-helper

Bug #1241210 reported by Sebastien Bacher
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-properties (Ubuntu)
Fix Released
High
Unassigned
Saucy
Fix Released
High
Unassigned

Bug Description

Impact: the "restart" command in software-properties doesn't restart

Test case:
- install 13.10 on a machine using a nvidia or ati video card
- run software-properties-gtk
- install the binary drivers
- click on restart after the install

Regression testing: the change is only going to work in gnome-session based session, that's not perfect but better than not working anywhere, we can work on a better fix later

----------

The indicator-session package dropped gtk-logout-helper, which leads to reboot not working, we should probably call gnome-session directly instead

See original description

Related branches

lp:~seb128/software-properties/dont-use-deprecated-reboot-commands
Ubuntu Core Development Team: Pending requested
Diff: 28 lines (+6/-1)
2 files modified
debian/changelog (+5/-0)
softwareproperties/gtk/SoftwarePropertiesGtk.py (+1/-1)
lp:ubuntu/saucy-proposed/software-properties
lp:~juliank/software-properties/debian
Sebastien Bacher (seb128)
Changed in software-properties (Ubuntu):
importance: Undecided → High
status: New → Triaged
status: Triaged → In Progress
Sebastien Bacher (seb128)
Changed in software-properties (Ubuntu Saucy):
status: New → Triaged
importance: Undecided → High
description: updated
Revision history for this message
Adam Conrad (adconrad) wrote : Please test proposed package

Hello Sebastien, or anyone else affected,

Accepted software-properties into saucy-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/software-properties/0.92.28 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in software-properties (Ubuntu Saucy):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-properties - 0.92.28

---------------
software-properties (0.92.28) saucy; urgency=low

  [ Bruno Nova ]
  * Ensure package sources are refreshed after modification
    Fixes Bug LP: #1075537 (and, indirectly, Bug LP: #782953 it seems).

  [ Brian Murray ]
  * Restore the removal of a line feed from a source (LP: #1239893)

  [ Jean-Baptiste Lallement ]

  * debian/manpages/add-apt-repository.1: Documented options -m and -s of
    add-apt-repository (LP: #1229092)

  [ Sebastien Bacher ]
  * softwareproperties/gtk/SoftwarePropertiesGtk.py: don't use the
    gtk-logout-helper command, it has been deprecated and dropped from the
    indicator-session binary, use gnome-session instead (lp: #1241210)
 -- Sebastien Bacher <email address hidden> Mon, 21 Oct 2013 11:16:21 -0400

Changed in software-properties (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Sebastien Bacher (seb128) wrote :

Ok, I've tested the fix with /usr/share/ubuntu-drivers-common/fake-devices-wrapper, thanks pitti for the hint!

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-properties - 0.92.28

---------------
software-properties (0.92.28) saucy; urgency=low

  [ Bruno Nova ]
  * Ensure package sources are refreshed after modification
    Fixes Bug LP: #1075537 (and, indirectly, Bug LP: #782953 it seems).

  [ Brian Murray ]
  * Restore the removal of a line feed from a source (LP: #1239893)

  [ Jean-Baptiste Lallement ]

  * debian/manpages/add-apt-repository.1: Documented options -m and -s of
    add-apt-repository (LP: #1229092)

  [ Sebastien Bacher ]
  * softwareproperties/gtk/SoftwarePropertiesGtk.py: don't use the
    gtk-logout-helper command, it has been deprecated and dropped from the
    indicator-session binary, use gnome-session instead (lp: #1241210)
 -- Sebastien Bacher <email address hidden> Mon, 21 Oct 2013 11:16:21 -0400

Changed in software-properties (Ubuntu Saucy):
status: Fix Committed → Fix Released
Revision history for this message
Scott Kitterman (kitterman) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.