Finally got a chance to test 2.5 browse on our full production database. Unfortunately, performance was unusably poor (I stopped the browse query after 32 minutes).
After some troubleshooting, it seems we need a couple helper functions to be set as STABLE (original suggestion was IMMUTABLE, but that was pointed out to be incorrect by Dan S.):
metabib.browse_bib_pivot()
metabib.browse_authority_refs_pivot()
After doing this, I got what appeared to be correct results in a couple seconds. This change makes sense to me, but since this is nothing I am expert in, I wanted to post this for general feedback before offering a branch of any kind. You can update these functions in an existing DB like so:
ALTER FUNCTION metabib.browse_bib_pivot (integer[], text) STABLE;
ALTER FUNCTION metabib.browse_authority_refs_pivot (integer[], text) STABLE;
Unfortunately I don't think these functions are, strictly speaking, mutable.
The first argument to metabib.
I believe metabib.
Per the PostgreSQL docs:
"""IMMUTABLE indicates that the function cannot modify the database and always returns the same result when given the same argument values; that is, it does not do database lookups or otherwise use information not directly present in its argument list."""