When we use Eventually in combination with the Raises matcher, the exception thrown is not caught.
>>> from autopilot.matchers import Eventually
>>> from testtools.matchers import raises
>>> matcher = Eventually(raises(RuntimeError("Hello")))
>>> def bad_fn():
... raise RuntimeError("Hello")
...
>>> bad_fn()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "<stdin>", line 2, in bad_fn
RuntimeError: Hello
>>> matcher.match(bad_fn)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python2.7/dist-packages/autopilot/matchers/__init__.py", line 109, in match
wait_fun(self.matcher, self.timeout)
File "/usr/lib/python2.7/dist-packages/autopilot/matchers/__init__.py", line 125, in _callable_wait_for
new_value = refresh_fn()
File "<stdin>", line 2, in bad_fn
RuntimeError: Hello
This is a bug in autopilot. The root problem is that we allow people to pass in a callable method to assertThat, like so:
self.assertThat
The Eventually matcher breaks the behavior defined in testtools - it calls the matchee when it should instead pass it to the underlying matcher.
I think we need to figure out how to fix this. Off the top of my head, there's no easy solution. Need to think about this some more. Suggestions welcome;