Terminator

Tab with multiple terminals not closed

Bug #1253995 reported by puccha on 2013-11-22

This bug affects 5 people

	Status	Importance	Assigned to
Terminator	Fix Released	Low	Stephen Boddy
terminator (Debian)	Fix Released	Unknown	debbugs #756300
terminator (Ubuntu)	Fix Released	Medium	Chris J Arges
Trusty	Fix Released	Medium	Unassigned

Bug Description

SRU Justification:
[Impact]
Users of terminator cannot close tabs with multiple split terminals.

[Test Case]
Start terminator. Create new tab, split new tab into multiple terminals. Try to close newly created tab.
We expect this to close.

[Regression Potential]
Patch is a small bugfix, and has been already committed upstream.

Terminator 0.97
If there are multiple terminals in a tab, the user is prompted for confirmation. Then, the program fails to close the tab and does so silently.

The confusion is about the return value of construct_confirm_close()

Fix:

$ bzr diff
=== modified file 'terminatorlib/notebook.py'
--- terminatorlib/notebook.py 2013-10-25 14:55:26 +0000
+++ terminatorlib/notebook.py 2013-11-22 11:41:31 +0000
@@ -318,9 +318,7 @@
             return
         elif maker.isinstance(child, 'Container'):
             dbg('Notebook::closetab: child is a Container')
- dialog = self.construct_confirm_close(self.window, _('tab'))
- result = dialog.run()
- dialog.destroy()
+ result = self.construct_confirm_close(self.window, _('tab'))

if result == gtk.RESPONSE_ACCEPT:
containers = None

See original description

Tags:

Related branches

lp:~stephen-j-boddy/terminator/feature-remember-focus

Merged into lp:terminator/trunk at revision 1490

Terminator: Pending requested 2013-12-19

lp:terminator/trunk

Revision history for this message

Stephen Boddy (stephen-j-boddy) wrote on 2013-12-16:

I actually found this while working on another feature and corrected it the same way. It will be fixed when I merge this new feature in.

Changed in terminator:
assignee:	nobody → Stephen Boddy (stephen-j-boddy)
status:	New → In Progress

Stephen Boddy (stephen-j-boddy) on 2013-12-19

Changed in terminator:
importance:	Undecided → Low

Stephen Boddy (stephen-j-boddy) on 2014-01-17

Changed in terminator:
status:	In Progress → Fix Committed

Revision history for this message

Chris J Arges (arges) wrote on 2014-07-28:

Fix uploaded for Utopic (0.97-3ubuntu1).

Changed in terminator (Ubuntu):
assignee:	nobody → Chris J Arges (arges)
Changed in terminator (Ubuntu Trusty):
importance:	Undecided → Medium
Changed in terminator (Ubuntu):
status:	New → In Progress
importance:	Undecided → Medium
description:	updated

Revision history for this message

Chris J Arges (arges) wrote on 2014-07-28:

fix-lp1253995-trusty.debdiff Edit (2.8 KiB, text/plain)

Here is the patch ready to be sponsored; however we need to wait until this lands in Utopic before proceeding with the SRU. Thanks

tags:

added: patch

Bug Watch Updater (bug-watch-updater) on 2014-07-28

Changed in terminator (Debian):
status:	Unknown → New

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-07-28:

This bug was fixed in the package terminator - 0.97-3ubuntu1

---------------
terminator (0.97-3ubuntu1) utopic; urgency=medium

[ Stephen Boddy ]
* Backport patch for tabs with multiple terminals not closing. (LP: #1253995)
-- Chris J Arges <email address hidden> Mon, 28 Jul 2014 09:27:27 -0500

Changed in terminator (Ubuntu):
status:	In Progress → Fix Released

Revision history for this message

Chris J Arges (arges) wrote on 2014-07-29:

Uploaded fix for trusty. Awaiting SRU process.

Bug Watch Updater (bug-watch-updater) on 2014-08-06

Changed in terminator (Debian):
status:	New → Fix Released

Revision history for this message

Brian Murray (brian-murray) wrote on 2014-08-07: Please test proposed package

Hello puccha, or anyone else affected,

Accepted terminator into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/terminator/0.97-2ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in terminator (Ubuntu Trusty):
status:	New → Fix Committed
tags:	added: verification-needed

Revision history for this message

Nico Isenbeck (nico-isenbeck) wrote on 2014-08-10:

Hello Brian,

terminator 0.97-2ubuntu0.1 from trusty-proposed fixed the problem for me!

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Scott Kitterman (kitterman) wrote on 2014-08-21: Update Released

The verification of the Stable Release Update for terminator has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-08-21:

This bug was fixed in the package terminator - 0.97-2ubuntu0.1

---------------
terminator (0.97-2ubuntu0.1) trusty; urgency=medium

[ Stephen Boddy ]
* Backport patch for tabs with multiple terminals not closing. (LP: #1253995)
-- Chris J Arges <email address hidden> Mon, 28 Jul 2014 09:42:39 -0500