Incorrect use of context managers causes FTBFS on buildds

Bug #1256947 reported by Barry Warsaw
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu system image
Fix Released
Critical
Barry Warsaw
system-image (Ubuntu)
Fix Released
Critical
Barry Warsaw

Bug Description

2.0 is FTBFS on trusty-proposed due to test suite failures that are unreproducible in local sbuilds. The test failure occurs both on the main buildd and in ppas:

https://launchpad.net/ubuntu/+source/system-image/2.0.1-0ubuntu1/+build/5275242

Currently working on some PPA builds with quilt patches to help debug the problem. Due to PPA turnaround time, this will be slow going.

Tags: client
Revision history for this message
Barry Warsaw (barry) wrote :

Michael Foord identified the problem. I am incorrectly interleaving unittest.mock.patch calls which get unwound in the wrong order. On local builds, the tests are run in an order which does not trigger this problem, but I guess fortunately, the buildds run the tests in a different order and the problem becomes evident. Fortunately, it's an easy fix - don't interleave the patch calls.

summary: - FTBFS on buildds
+ Incorrect use of context managers causes FTBFS on buildds
Changed in ubuntu-system-image:
status: New → In Progress
importance: Undecided → Critical
assignee: nobody → Barry Warsaw (barry)
tags: added: client
Changed in ubuntu-system-image:
milestone: none → 2.0.2
Barry Warsaw (barry)
Changed in ubuntu-system-image:
status: In Progress → Fix Committed
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package system-image - 2.0.3-0ubuntu1

---------------
system-image (2.0.3-0ubuntu1) trusty; urgency=low

  * New upstream release.
  * d/control: Re-enable DEP-8 tests.
  * d/tests/smoketest: A simpler test that shouldn't be susceptible to D-Bus
    flakiness in the autopkgtest VMs, but which does require network
    access to system-image.ubuntu.com (deemed okay as per pitti).
 -- Barry Warsaw <email address hidden> Mon, 09 Dec 2013 10:01:34 -0500

Changed in system-image (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.