GCache file allocation may fail if file size is a multiple of page size
Bug #1259952 reported by
Alex Yurchenko
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Galera | Status tracked in 3.x | |||||
| 2.x |
Fix Released
|
High
|
Alex Yurchenko | |||
| 3.x |
Fix Released
|
High
|
Alex Yurchenko | |||
| Percona XtraDB Cluster moved to https://jira.percona.com/projects/PXC | Status tracked in 5.6 | |||||
| 5.5 |
Fix Released
|
Undecided
|
Unassigned | |||
| 5.6 |
Fix Released
|
Undecided
|
Unassigned | |||
Bug Description
This may happen on file systems that don't support posix_fallocate(). The reason is offset == size_ case is not handled and falls through to throw exception.
Related branches
lp:~codership/galera/23.2.x
(Merged)
lp:galera
- David Bennett: Pending requested
- Diff: 0 lines
| summary: |
- GCache file allocation may fail if files size if a multiple of page size + GCache file allocation may fail if file size if a multiple of page size |
| summary: |
- GCache file allocation may fail if file size if a multiple of page size + GCache file allocation may fail if file size is a multiple of page size |
Revision history for this message
| Raghavendra D Prabhu (raghavendra-prabhu) wrote | #1 |
Revision history for this message
| Alex Yurchenko (ayurchen) wrote | #2 |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #3 |
To post a comment you must log in.
@Alex,
Has this actually happened on any instance? Asking since
posix_fallocate usually falls back to zero-writing on filesystems
where fallocate is not supported (which is why fallocate is less
used compared to posix_allocate in certain cases, since former
fails).
However, this may again fail but will be on platforms with very
old glibc (need to be really old AFAIK) where this fallback may
not have been implemented.
I tested with
wsrep_provider_
But was not able to get any crash here (it also changed the size
to a different value, not an exact multiple of 4096).