Odoo Addons (MOVED TO GITHUB)

[6.1][7.0][trunk] Delivery order should take the confirmation date of the sale order

Bug #1260778 reported by Yann Papouin on 2013-12-13

This bug affects 3 people

	Status	Importance	Assigned to
Odoo Addons (MOVED TO GITHUB)	New	Undecided	Unassigned
OpenERP Community Backports (Addons)	Status tracked in 7.0
6.1	Fix Released	Low	Yann Papouin
7.0	Fix Released	Low	Yann Papouin

Bug Description

Actually it's using the date_order from the order.
If you create your quotation one week ago and then valid your order, all dates (stock moves and picking) will be planned from the date_order that is not updated on confirmation.
It should take the confirmation date of the sale order.

Related branches

lp:~openerp-dev/openobject-addons/6.1-opw-587363-ado

Ready for review for merging into lp:openobject-addons/6.1

Xavier ALT: Pending requested 2013-03-13

Naresh(OpenERP): Pending requested 2013-03-13

lp:~yann-papouin/ocb-addons/6.1-bug-1260778-sale-date-confirm

Merged into lp:ocb-addons/6.1 at revision 6825

Holger Brunn (Therp): Approve (code review) on 2014-01-06

Sandy Carter (http://www.savoirfairelinux.com): Approve (code review, no test) on 2013-12-23

Guewen Baconnier @ Camptocamp: Approve (code review) on 2013-12-19

Pedro Manuel Baeza: Approve (code review) on 2013-12-18

lp:~yann-papouin/openobject-addons/7.0-bug-1260778-sale-date-confirm

Ready for review for merging into lp:openobject-addons/7.0

OpenERP Core Team: Pending requested 2014-03-10

lp:~yann-papouin/ocb-addons/7.0-bug-1260778-sale-date-confirm

Merged into lp:ocb-addons at revision 10010

Ronald Portier (Therp): Approve (code review) on 2014-03-10

Pedro Manuel Baeza: Approve (code review) on 2014-03-10

Sandy Carter (http://www.savoirfairelinux.com): Approve (code review, pep8) on 2014-03-10

Holger Brunn (Therp): Approve (code review) on 2014-03-10

Revision history for this message

Pedro Manuel Baeza (pedro.baeza) wrote on 2013-12-13:

Hi, Yann, this would be very interesting to be also in OCB branch until it arrives on official branch. Could you please make an MP with the patch and link to this bug?

Regards.

Revision history for this message

Ronald Portier (Therp) (rportier1962) wrote on 2013-12-16:

I already fixed this for one of our customers.

I really think the present computation is a bug, so a bugfixing branch might be appropiate.

But then some people might rely on the present logic or illogic, so I could post a module to modify the default behaviour.

What do people think?

And what would be the best project to post a new module?

Anyway, below my code, stripped from things not needed to fix this bug:

# -*- coding: utf-8 -*-
'''Modify 'sale.order' model'''
from openerp.osv import orm

class SaleOrder(orm.Model):
    '''\
Change computation of delivery and planned date to start from order
  confirmation, not from creation of quote.
'''
    _inherit = 'sale.order'

    def _get_date_planned(
            self, cr, uid, order, line, start_date, context=None):
        '''\
Intercept standard function call _get_date_planned, that receives date_order,
to replace it by date_confirm.
It would be more correct to change the function call itself, but that is
embedded in a huge method, that I do not want to override.
Should only be called when order has been confirmed!
'''
        return super(SaleOrder, self)._get_date_planned(
                cr, uid, order, line, order.date_confirm, context=context)

I already fixed this for one of our customers.

I really think the present computation is a bug, so a bugfixing branch might be appropiate.

But then some people might rely on the present logic or illogic, so I could post a module to modify the default behaviour.

What do people think?

And what would be the best project to post a new module?

Anyway, below my code, stripped from things not needed to fix this bug:

# -*- coding: utf-8 -*-                                                        
'''Modify 'sale.order' model'''                                                
from openerp.osv import orm                                                    
                                                                               
                                                                               
class SaleOrder(orm.Model):                                                    
    '''\                                                                       
Change computation of delivery and planned date to start from order          
  confirmation, not from creation of quote.                                    
'''                                                                            
    _inherit = 'sale.order'                                                    
                                                                               
    def _get_date_planned(                                                     
            self, cr, uid, order, line, start_date, context=None):             
        '''\                                                                   
Intercept standard function call _get_date_planned, that receives date_order,  
to replace it by date_confirm.                                                 
It would be more correct to change the function call itself, but that is          
embedded in a huge method, that I do not want to override.                     
Should only be called when order has been confirmed!                           
'''                                                                            
        return super(SaleOrder, self)._get_date_planned(                       
                cr, uid, order, line, order.date_confirm, context=context)

Revision history for this message

Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives) wrote on 2014-03-27:

Would you please be kind enough to check whether this proposal also fixes the issue?
It's an improvement of sale_order_dates.
https://code.launchpad.net/~numerigraphe/openobject-addons/trunk-sale-order-dates/+merge/175249

Revision history for this message

Yann Papouin (yann-papouin) wrote on 2014-03-28:

@Lionel: Comment added to your proposal

Revision history for this message

Raphaël Valyi - http://www.akretion.com (rvalyi) wrote on 2014-07-16:

PR for added Odoo v8 here: https://github.com/odoo/odoo/pull/1214/files

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.