Add support for regional languages to TinyMCE language detection
Bug #1265061 reported by
Robert Lyon
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mahara |
Fix Released
|
Low
|
Robert Lyon | ||
Bug Description
Taking just the fist 2 letters of the current language to select which language file to use with tinymce will not work correctly for some languages dialects.
eg Chinese, traditional is represented with 'zh_tw' in mahara language packs (http://
and is represented as zh-tw.js for the tinymce language pack - note the hyphen.
And is different to the tinymce language pack zh-cn.js
Revision history for this message
| Robert Lyon (robertl-9) wrote | #1 |
| Changed in mahara: | |
| status: | Confirmed → In Progress |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A change has been merged | #2 |
| Changed in mahara: | |
| status: | In Progress → Fix Committed |
| summary: |
- detecting which language to use for tinymce not correct + Add support for regional languages to TinyMCE language detection |
| tags: | added: tinymce translations |
| Changed in mahara: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Have added a patch
https:/
To test:
1) Add in some language packs to the site - make sure to add language packs that are both dialect ones, it will have a 5 char code instead of two in left hand column, and non dialect ones.
2) Make sure one of the dialect ones also exists as a dialect lang pack for tinymce (see /js/tinymce/langs/ directory for what is installed) - Currently only zh_TW matches this criteria.
3) Pick the language to test in site options
4) Go to a page that uses tinymce (eg /artefact/
- when you are viewing tinymce with mahara using zh_TW
-- without the patch it will use the zh.js lang pack
-- with the patch it will use the zh-tw.js lang pack