Evergreen

OPAC gives 'No Notification Preferences Are Configured' even when they are

Bug #1271218 reported by Terran McCanna
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
Evergreen 2.6.0-beta1
2.5
Fix Released
Low
Unassigned
Evergreen 2.5.3

Bug Description

We discovered in preparing to upgrade to 2.5 that the OPAC shows a "No Notification Preferences Are Configured" message on the Account Preferences > Notification Preferences screen regardless of whether or not notification preferences are configured.

(As it didn't affect functionality in any way, we commented out the line in our instance before rolling out.)

Possibly related to issue 1183414.

Tags: pullrequest
Revision history for this message
Jason Stephenson (jstephenson) wrote :

What version of Evergreen is it where you see this?

I am not seeing this on master as of this morning.

Revision history for this message
Terran McCanna (tmccanna) wrote :

This is on 2.5.1.

Revision history for this message
Ben Shum (bshum) wrote :

I think this is an interpretation issue. The message "No notification preferences are configured" does not affect the options selected or lack thereof. It's actually there to reference the lack of setup for user opt-in notification settings.

My suggestion is to eliminate this confusing message and just display the notification options if they exist, otherwise show nothing.

See working branch: user/bshum/lp1271218-prefs-notify

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/lp1271218-prefs-notify

Changed in evergreen:
status: New → Confirmed
tags: added: pullrequest
Changed in evergreen:
importance: Undecided → Low
milestone: none → 2.6.0-alpha1
Revision history for this message
Terran McCanna (tmccanna) wrote :

Yes, that's exactly what I was thinking of pursuing when I had a chance - thanks Ben!

Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.6.0-alpha1 → 2.6.0-beta1
Revision history for this message
Chris Sharp (chrissharp123) wrote :

Tested on Evergreen 2.5.1 - works as expected.

Signoff branch here: user/csharp/lp1271218-prefs-notify-signoff

Revision history for this message
Ben Shum (bshum) wrote :

Picked to master, rel_2_5 and rel_2_4.

Changed in evergreen:
status: Confirmed → Fix Committed
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
Evergreen Bug Maintenance (bugmaster)
no longer affects: evergreen/2.4
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.