Ubuntu
ubuntu-system-settings package

Use of separators is inconsistent in "Brightness" vs. "Battery"

Bug #1275699 reported by Matthew Paul Thomas
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-system-settings (Ubuntu)
Fix Released
Low
Iain Lane

Bug Description

<https://wiki.ubuntu.com/Brightness#Phone> shows a separator between "Display brightness:" and the following slider.

<https://wiki.ubuntu.com/Power#Phone> shows the same slider, with the same label, but no separator.

This should be made consistent somehow.

[Originally reported by Iain Lane.]

See original description

Related branches

lp:~laney/ubuntu-system-settings/brightness-panel
PS Jenkins bot: Approve (continuous-integration)
Sebastien Bacher (community): Needs Fixing
Diff: 733 lines (+527/-72)
16 files modified
debian/control (+1/-1)
plugins/battery/PageComponent.qml (+5/-68)
plugins/brightness/CMakeLists.txt (+18/-0)
plugins/brightness/PageComponent.qml (+74/-0)
plugins/brightness/brightness.cpp (+85/-0)
plugins/brightness/brightness.h (+50/-0)
plugins/brightness/brightness.settings (+3/-2)
plugins/brightness/plugin.cpp (+37/-0)
plugins/brightness/plugin.h (+36/-0)
plugins/brightness/plugin/CMakeLists.txt (+8/-0)
plugins/brightness/plugin/brightness-plugin.cpp (+64/-0)
plugins/brightness/plugin/brightness-plugin.h (+38/-0)
plugins/brightness/qmldir (+2/-0)
src/SystemSettings/BrightnessSlider.qml (+103/-0)
src/SystemSettings/CMakeLists.txt (+2/-1)
src/SystemSettings/qmldir (+1/-0)
lp:ubuntu/trusty-proposed/ubuntu-system-settings
Matthew Paul Thomas (mpt)
description: updated
Robert Ancell (robert-ancell)
Changed in ubuntu-system-settings (Ubuntu):
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Wireframe updated. <https://wiki.ubuntu.com/Brightness?action=AttachFile&do=view&target=phone-brightness.png>

Changed in ubuntu-system-settings (Ubuntu):
status: Triaged → In Progress
assignee: Matthew Paul Thomas (mpt) → Iain Lane (laney)
status: In Progress → Triaged
Revision history for this message
Iain Lane (laney) wrote :

Neat, the attached branch does that.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-settings - 0.1+14.04.20140206-0ubuntu1

---------------
ubuntu-system-settings (0.1+14.04.20140206-0ubuntu1) trusty; urgency=low

  [ Diego Sarmentero ]
  * Show updates notification in main page. .

  [ Iain Lane ]
  * Add the brightness panel (LP: #1275699)
  * Set the 'enabled' and 'value' of BrightnessSlider when the state
    from the indicator backend changes.
 -- Ubuntu daily release <email address hidden> Thu, 06 Feb 2014 15:47:52 +0000

Changed in ubuntu-system-settings (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.