Macbook Pro Third Generation HAL Support

Bug #129869 reported by Tomas Pollak
30
Affects Status Importance Assigned to Milestone
HAL
Fix Released
Medium
Mactel Support
Fix Released
Undecided
Unassigned
hal (Ubuntu)
Fix Released
Low
Martin Pitt

Bug Description

Binary package hint: hal

This is a small one. To enable Macbook Keyboard Backlight and Brightness control with the F# keys, this file requires some editing:

/usr/share/hal/fdi/policy/10osvendor/10-macbookpro-utils.fdi

Since there's no entry for the new Macbooks, whose ID is "MacBookPro3,1". You need to add this in order to make the keys work (well, they dont actually *work* as of now, but at least they get detected when you press them):

        <match key="system.hardware.product" string="MacBookPro3,1">
          <spawn udi="/org/freedesktop/Hal/devices/macbook_pro_light_sensor"/>
          <spawn udi="/org/freedesktop/Hal/devices/macbook_pro_keyboard_backlight"/>
          <spawn udi="/org/freedesktop/Hal/devices/macbook_pro_lcd_panel"/>
        </match>

The important part is the STRING thing in the first line.

Related branches

Revision history for this message
In , Sense Egbert Hofstede (sense) wrote :

"Binary package hint: hal

This is a small one. To enable Macbook Keyboard Backlight and Brightness control with the F# keys, this file requires some editing:

/usr/share/hal/fdi/policy/10osvendor/10-macbookpro-utils.fdi

Since there's no entry for the new Macbooks, whose ID is "MacBookPro3,1". You need to add this in order to make the keys work (well, they dont actually *work* as of now, but at least they get detected when you press them):

        <match key="system.hardware.product" string="MacBookPro3,1">
          <spawn udi="/org/freedesktop/Hal/devices/macbook_pro_light_sensor"/>
          <spawn udi="/org/freedesktop/Hal/devices/macbook_pro_keyboard_backlight"/>
          <spawn udi="/org/freedesktop/Hal/devices/macbook_pro_lcd_panel"/>
        </match>

The important part is the STRING thing in the first line."
Tomas Pollak
This was reported at launchpad, in Ubuntu. If this code is added the brightness controls can work.

Revision history for this message
Sense Egbert Hofstede (sense) wrote :

Reported to freedesktop.

Changed in hal:
status: New → Unknown
Changed in hal:
status: Unknown → Confirmed
Revision history for this message
In , Danny Kukawka (danny-kukawka) wrote :

Commited a patch to HAL.

Revision history for this message
Sense Egbert Hofstede (sense) wrote :

It's confirmed upstream, so it wouldn't make sense if it wouldn't be here too.

Changed in hal:
status: New → Confirmed
Changed in hal:
status: Confirmed → Fix Released
Changed in hal:
importance: Undecided → Low
status: Confirmed → Triaged
Revision history for this message
Brian Murray (brian-murray) wrote :

I have verified this in package version 0.5.10+git20080301-1ubuntu1.

Martin Pitt (pitti)
Changed in hal:
assignee: nobody → pitti
status: Triaged → In Progress
Martin Pitt (pitti)
Changed in hal:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package hal - 0.5.11~rc2-1ubuntu1

---------------
hal (0.5.11~rc2-1ubuntu1) hardy; urgency=low

  * Update our git snapshot from March 01 to current 0.5.11-RC2, which brings
    a few bug fixes.
    - Adds properties for tablet PCs (LP: #90451)
    - Fixes operation on MacBookPro third generation. (LP: #129869)
  * Remove patches applied upstream:
    - 02_allow_ufs_ufstype.patch
    - 05_fix_dell_brightness.patch
  * Adapt patches to new upstream version:
    - 96_uinput_device_support.patch
    - 96_uinput_device_support.patch
  * Merge with Debian unstable; see 0.5.10+git20080301-1ubuntu1 for remaining
    Ubuntu changes.
  * Replace 88_change_pm_quirk_policy.patch with
    01_default_suspend_quirks.patch: Only set the default suspend quirks for
    kernel problem workarounds if hal-info does not define any quirks at all
    for the hardware. (LP: #198808)

hal (0.5.11~rc2-1) unstable; urgency=low

  * New upstream release candidate
  * debian/libhal-storage1.{symbols,shlibs}, debian/libhal1.{symbols,shlibs}:
    - Updated symbols and shlibs

 -- Martin Pitt <email address hidden> Fri, 21 Mar 2008 13:39:03 +0100

Changed in hal:
status: Fix Committed → Fix Released
Changed in mactel-support:
status: New → Fix Released
Changed in hal:
importance: Unknown → Medium
Changed in hal:
importance: Medium → Unknown
Changed in hal:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.