cryptdisks_start modifies echo setting of invoking stty

This is the output of cryptdisks_start with tracing (option -x) enabled in shell.

The culprit appears to be /lib/cryptsetup/askpass:

root@darkcharl:~# stty -a
speed 38400 baud; rows 55; columns 186; line = 0;
intr = ^C; quit = ^\; erase = ^?; kill = ^U; eof = ^D; eol = M-^?; eol2 = M-^?; swtch = M-^?; start = ^Q; stop = ^S; susp = ^Z; rprnt = ^R; werase = ^W; lnext = ^V; flush = ^O;
min = 1; time = 0;
-parenb -parodd cs8 hupcl -cstopb cread -clocal -crtscts
-ignbrk brkint ignpar -parmrk -inpck -istrip -inlcr -igncr icrnl ixon -ixoff -iuclc -ixany imaxbel iutf8
opost -olcuc -ocrnl onlcr -onocr -onlret -ofill -ofdel nl0 cr0 tab0 bs0 vt0 ff0
isig icanon iexten echo echoe echok -echonl -noflsh -xcase -tostop -echoprt echoctl echoke
root@darkcharl:~#
root@darkcharl:~# /lib/cryptsetup/askpass Passphrase:
Passphrase:testmeroot@darkcharl:~# speed 38400 baud; rows 55; columns 186; line = 0;
intr = ^C; quit = ^\; erase = ^?; kill = ^U; eof = ^D; eol = M-^?; eol2 = M-^?; swtch = M-^?; start = ^Q; stop = ^S; susp = ^Z; rprnt = ^R; werase = ^W; lnext = ^V; flush = ^O;
min = 1; time = 0;
-parenb -parodd cs8 hupcl -cstopb cread -clocal -crtscts
-ignbrk brkint ignpar -parmrk -inpck -istrip -inlcr -igncr icrnl ixon -ixoff -iuclc -ixany imaxbel iutf8
opost -olcuc -ocrnl onlcr -onocr -onlret -ofill -ofdel nl0 cr0 tab0 bs0 vt0 ff0
isig icanon iexten -echo echoe echok -echonl -noflsh -xcase -tostop -echoprt echoctl echoke

 2078 /lib/cryptsetup/askpass Passphrase:
 2079 stty -a
 2080 stty echo
 2081 stty -a
 2082 /lib/cryptsetup/askpass Passphrase:
 2083 stty -a
 2084 stty echo

Status changed to 'Confirmed' because the bug affects multiple users.

I see this exact problem with /lib/cryptsetup/askpass in Debian jessie

The problem appears to stem from disable_method(NULL) not getting called, thus, console_finish not being called, either. Askpass seems to be a script external to cryptsetup (debian/ubuntu specific). Have a fix. I'll submit a patch.

Attaching the debdiff for those who need the fix before my merge request gets accepted.

Attaching debdiff for those who need the fix before merge request gets accepted.

The attachment "package patch" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

It'd probably be a good idea to forward patch and debugging information to debian also.

I sent an email to the referred bug report and subscribed to the bug.

Have not received any response from upstream yet.

Instead of updating the code, should we create a separate patch in the interim that can be released and easily discarded?

This bug was fixed in the package cryptsetup - 2:1.6.1-1ubuntu2

---------------
cryptsetup (2:1.6.1-1ubuntu2) utopic; urgency=medium

  * debian/askpass.c:
    - Fix bug (LP: #1301086) where askpass fails to restore terminal
      settings.
 -- Robert Barabas <dc@0xdc.org> Fri, 18 Apr 2014 14:08:51 -0400

When will the fix be released for trusty?

This needs to be fixed in Trusty as well.