"reviews" widget not displaying properly

Bug #1301309 reported by dobey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity8 (Ubuntu)
Fix Released
High
Andrea Cimitan

Bug Description

When adding reviews to the preview with the "reviews" widget, the reviews are not properly displayed. The author and review text are missing from display, though they are required attributes in the API. Only the rating stars are shown for the review. Also, the rating stars seem to not always display correctly either, as I added a review with a "rating" of 1, and all 5 stars were filled in the display.

This was tested by adding fake data of { { 3, "author", "This is a review" }, { 1, "author2", "This is another review."} } in the widget.

Related branches

Revision history for this message
Michał Sawicz (saviq) wrote :

FWIW, this is example data against which the widget is tested, we need to verify that's the format we're getting from the scopes.

[ { author: "Some dude", rating: 4.5, review: "Very cool app" },
  { author: "Yet Another dude", rating: 5, review: "Very cool app" }, ]

Changed in unity8:
assignee: nobody → Andrea Cimitan (cimi)
importance: Undecided → High
Revision history for this message
dobey (dobey) wrote :

So, after another look, it looks like the text is just being rendered white, which is invisible on the white background. Squinting very hard on the slightly grey portion, I could see that the text actually is there.

Also, I am not seeing the full 5 stars rendering instead of 1 any more, so it might have been a weird fluke.

Revision history for this message
Andrea Cimitan (cimi) wrote :

The widget is using the right font colour, but the palette is giving the widget the wrong colour :) We workarounded this in the TextSummary with a static "grey" definition instead using the palette, shall we do the same here?

Revision history for this message
dobey (dobey) wrote :

All the text in the dash will probably need to either have a calculated color to contrast against the background, or some sort of shadow or similar, so that it will be generally contrasted.

Michał Sawicz (saviq)
Changed in unity8:
status: New → Triaged
Andrea Cimitan (cimi)
Changed in unity8:
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (3.5 KiB)

This bug was fixed in the package unity8 - 7.85+14.04.20140416-0ubuntu1

---------------
unity8 (7.85+14.04.20140416-0ubuntu1) trusty; urgency=low

  [ Albert Astals ]
  * Fix last item X position Fixes clicking on the last item sometimes
    not working (LP: #1301871)
  * Use upstart in ./run Makes it so that you can use the lock button on
    the device without getting that nasty hwc crash
  * Remove AnimationControllerWithSignals.
  * Use the correct delegate base item for the Carousel test
  * Some simplification in DashContent Kill the ScopeDelegateMapper in
    favour of a simple if (that will eventually go away). Removal of all
    the fake scopes in the tests that added nothing of value to the
    tests. Removal of movementEnded signal that was unused. Removal of
    movementStarted and positionedAtBeginning signals that were being
    used as function calls. Rework DashContent tests so they what the
    function does what it is supposed to do instead of just making sure
    QML signals work .
  * Improve Card creation time by adding loaders that make sure only
    what's needed is loaded In my computer it goes from RESULT :
    qmltestrunner::benchmark_time:"cardTitleArtSubtitleMascotSummaryMode
    l": 3.217 msecs per iteration (total: 3,218, iterations: 1000)
    RESULT :
    qmltestrunner::benchmark_time:"cardTitleArtSubtitleMascotModel":
    1.647 msecs per iteration (total: 1,648, iterations: 1000) RESULT :
    qmltestrunner::benchmark_time:"cardTitleArtSubtitleModel": 1.514
    msecs per iteration (total: 1,515, iterations: 1000) RESULT :
    qmltestrunner::benchmark_time:"cardTitleArtModel": 1.471 msecs per
    iteration (total: 1,471, iterations: 1000) RESULT :
    qmltestrunner::benchmark_time:"cardArtModel": 1.447 msecs per
    iteration (total: 1,448, iterations: 1000) RESULT :
    qmltestrunner::benchmark_time:"cardTitleModel": 1.276 msecs per
    iteration (total: 1,276, iterations: 1000) to RESULT :
    qmltestrunner::benchmark_time:"cardTitleArtSubtitleMascotSummaryMode
    l": 2.916 msecs per iteration (total: 2,917, iterations: 1000)
    RESULT :
    qmltestrunner::benchmark_time:"cardTitleArtSubtitleMascotModel":
    1.504 msecs per iteration (total: 1,504, iterations: 1000) RESULT :
    qmltestrunner::benchmark_time:"cardTitleArtSubtitleModel": 1.060
    msecs per iteration (total: 1,061, iterations: 1000) RESULT :
    qmltestrunner::benchmark_time:"cardTitleArtModel": 1.052 msecs per
    iteration (total: 1,053, iterations: 1000) RESULT :
    qmltestrunner::benchmark_time:"cardArtModel": 0.727 msecs per
    iteration (total: 728, iterations: 1000) RESULT :
    qmltestrunner::benchmark_time:"cardTitleModel": 0.817 msecs per
    iteration (total: 818, iterations: 1000) (LP: #1297197)

  [ Allan LeSage ]
  * DashApps emulator get_applications should return a list ordered by
    visible y, x.

  [ Andrea Cimitan ]
  * Workaround for lp1301309 until fixes for palette in ui toolkit (LP:
    #1301309)

  [ Leo Arias ]
  * Reverted the change that returns application cards instead of
    titles.

  [ Nick Dedekind ]
  * Indicator services started by unity8 upstart configuration rather
    than manual emmision from indicat...

Read more...

Changed in unity8 (Ubuntu):
status: New → Fix Released
Michał Sawicz (saviq)
Changed in unity8:
status: In Progress → Fix Released
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
assignee: nobody → Andrea Cimitan (cimi)
importance: Undecided → High
no longer affects: unity8
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.