Service request: This Is My Jam

Bug #1310616 reported by Jan Vlnas
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Nuvola Apps Runtime (Nuvola Player)
Fix Released
Wishlist
Unassigned

Bug Description

Status
======

The fix is available as a service update package. See https://nuvolaplayer.fenryxo.cz/download/service_updates.html

Fix committed to lp:nuvola-player as r818. Will be released in Nuvola Player 2.4.0.
<http://bazaar.launchpad.net/~fenryxo/nuvola-player/trunk/revision/818>

Original report
===============

This Is My Jam is a bit of a niche service for posting one song at a time: https://www.thisismyjam.com/
Unlike other services, this one streams music from third parties, such as YouTube and Soundcloud, and provides a playlist interface over different embedded players.

I have created an integration (attached) which uses their player through the DOM, though eventually I'd like to exploit their internal JS API.
This implementation has also one issue – the album art might be incorrectly replaced when the profile page is visited. Unfortunately TIMJ's player does not show album art across different pages like Google Play, so the integration will have to guess the correct art and maintain it within the internal state.
I'd also like to add an icon for the service; is there any template I could use?

Díky. ;)

Related branches

Revision history for this message
Jan Vlnas (jnv) wrote :
Revision history for this message
Jiří Janoušek (fenryxo) wrote :

Thanks for your work. Please subscribe to the Nuvola Player Development mailing list at https://launchpad.net/~nuvola-player-devel to be notified about API changes and breakages.

Code looks good, but wrap description.html to 80 characters per line.

> This implementation has also one issue – the album art might be incorrectly replaced when the profile page is visited. Unfortunately TIMJ's player does not show album art across different pages like Google Play, so the integration will have to guess the correct art and maintain it within the internal state.

I think we can live with it in the 2.x series, but the 3.x series contains API for a temporary key-value storage that could be used to maintain the internal state.

http://bazaar.launchpad.net/~fenryxo/nuvola-player/trunk-next/revision/122

> I'd also like to add an icon for the service; is there any template I could use?

I would rather to get in touch with Alex who created the other icons. There are also other services that need an icon.

Changed in nuvola-player:
status: New → Incomplete
importance: Undecided → Wishlist
milestone: none → 2.4.0
Revision history for this message
Jan Vlnas (jnv) wrote :

> Code looks good, but wrap description.html to 80 characters per line.

I have attached the reformatted description file.

KeyValue storage looks useful, though it looks like an unnecessary roundtrip to the native code; on the other hand, I understand why there should be one place for integrations to store their internal state.
Also the support for ‘like status’ as described in #1081077 is something I will definitely look into.

description: updated
Changed in nuvola-player:
status: Incomplete → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.