Zope 3

zope.app.securitypolicy breaks the IPrincipalPermissionMap interface.

Bug #131115 reported by Christian Theune
2
Affects Status Importance Assigned to Milestone
Zope 3
Won't Fix
Undecided
Unassigned
zope.securitypolicy
Fix Committed
Medium
Christian Theune

Bug Description

In zopepolicy.py the IPrincipalPermissionMap.getSetting method is called with 3 arguments, although only 2 are required by the interface. Something is out of sync.

Christian Theune (ctheune)
Changed in zope3:
status: New → Won't Fix
affects: zope.app.securitypolicy → zope.securitypolicy
Changed in zope.securitypolicy:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Christian Theune (ctheune) wrote :

There's a similar code path for the principal role map which also has a getSetting method that passes the default of 'Unset' directory to the queryCell without having a third argument in getSetting.

I think we need to extend the interface (and should do so in both cases) because the client code of PrincipalPermissionManager.getSetting already uses it as a sentinel to avoid feeding caches with negative responses.

Changed in zope.securitypolicy:
assignee: nobody → Christian Theune (ct-gocept)
Revision history for this message
Christian Theune (ctheune) wrote :

Fixed in r112528.

Changed in zope.securitypolicy:
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.