[patch] Update to fix minibuf-electric.el for Emacs 24

Bug #1313199 reported by Karl Hegbloom
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
emacs-goodies-el (Debian)
Fix Released
Unknown
emacs-goodies-el (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

minibuf-electric.el contains some code which is not compatible with Emacs 24. The attached patch updates the code with the following changes.

  * directory-sep-char is obsolete; defvar it so it's always defined.

  * Emacs 24 wants last-command-event, not last-command-char

Tags: patch
Revision history for this message
Karl Hegbloom (karl.hegbloom) wrote :
Revision history for this message
Karl Hegbloom (karl.hegbloom) wrote :

Oh, to get it to build I had to fix another couple of patches. Sorry if I'm duplicating work...

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Patch against bzr checkout as of date of this bug report." seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Karl Hegbloom (karl.hegbloom) wrote :

Please add the attached diff to debian/patches with an entry in the debian/patches/series file. That will close this bug.

Affects: upstream

Revision history for this message
era (era) wrote :

Please update the bug description to explain the problem that this patch is supposed to fix, and explain why it should be applied to Ubuntu and not to Debian.

Revision history for this message
Karl Hegbloom (karl.hegbloom) wrote :

The patch should be applied to both and I reported it to Debian as well so you will probably see it come back from upstream eventually, but perhaps if other people out there are using it and running into the same error you might want to get it to them sooner.

era (era)
no longer affects: emacs-goodies-el
Changed in emacs-goodies-el (Debian):
status: Unknown → New
Revision history for this message
era (era) wrote :

I updated the bug description. Please review and maybe add something to reflect the additional changes in your latest update of the patch.

description: updated
Revision history for this message
Karl Hegbloom (karl.hegbloom) wrote : Re: [Bug 1313199] Re: [patch] Update to fix minibuf-electric.el for Emacs 24

Thank you for the example now I know what you were expecting.

On Mon, Nov 2, 2015, 05:11 era <email address hidden> wrote:

> I updated the bug description. Please review and maybe add something to
> reflect the additional changes in your latest update of the patch.
>
> ** Description changed:
>
> - Patch will be attached to this bug report.
> + minibuf-electric.el contains some code which is not compatible with
> + Emacs 24. The attached patch updates the code with the following
> + changes.
> +
> + * directory-sep-char is obsolete; defvar it so it's always defined.
> +
> + * Emacs 24 wants last-command-event, not last-command-char
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1313199
>
> Title:
> [patch] Update to fix minibuf-electric.el for Emacs 24
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu/+source/emacs-goodies-el/+bug/1313199/+subscriptions
>

Mathew Hodson (mhodson)
Changed in emacs-goodies-el (Ubuntu):
importance: Undecided → Low
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package emacs-goodies-el - 35.12ubuntu2

---------------
emacs-goodies-el (35.12ubuntu2) xenial; urgency=medium

  [ Karl Hegbloom ]
  * Update minibuf-electric.el for emacs 24 compatibilty. (LP: #1313199, see
    also Debian bug #803728)

 -- Iain Lane <email address hidden> Mon, 07 Dec 2015 14:05:31 +0000

Changed in emacs-goodies-el (Ubuntu):
status: New → Fix Released
Changed in emacs-goodies-el (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.