Mahara

Progress completion bar giving errors

Bug #1314460 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
1.10
Fix Released
High
Robert Lyon
Mahara 1.10.0
1.9
Fix Released
High
Robert Lyon
Mahara 1.9.0

Bug Description

[WAR] bf (lib/mahara.php:2970) Array to string conversion
Call stack (most recent first):

    log_message("Array to string conversion", 8, true, true, "/home/kristina/code/19stable/htdocs/lib/mahara.php", 2970) at /home/kristina/code/19stable/htdocs/lib/errors.php:433
    error(8, "Array to string conversion", "/home/kristina/code/19stable/htdocs/lib/mahara.php", 2970, array(size 19)) at Unknown:0
    array_diff(array(size 3), array(size 0)) at /home/kristina/code/19stable/htdocs/lib/mahara.php:2970
    progressbar_sideblock(true) at /home/kristina/code/19stable/htdocs/lib/web.php:635
    smarty() at /home/kristina/code/19stable/htdocs/admin/users/progressbar.php:228

Revision history for this message
Robert Lyon (robertl-9) wrote :

A problem I found was the array_diff() was trying to check a multi-dimensional array against an array.

According to php.net "This function only checks one dimension of a n-dimensional array. "

So I'll fix that up first.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3302

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
importance: Undecided → High
milestone: none → 1.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3302
Committed: http://gitorious.org/mahara/mahara/commit/6ca2821affe8eccbeda5ee0b27f087e4c72423ad
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6ca2821affe8eccbeda5ee0b27f087e4c72423ad
Author: Aaron Wells <email address hidden>
Date: Wed Apr 30 15:56:21 2014 +1200

Removing unnecessary array_diff

Bug 1314460: No need to remove $locked from $progressbaritems, because the
list of progressbaritems is limited by the $onlytheseplugins array, and that
has already had $locked removed from it.

Change-Id: Ie8418703d0333eaf2ef2ba8301ec235e4dcddd03

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "1.9_STABLE" branch: https://reviews.mahara.org/3309

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3309
Committed: http://gitorious.org/mahara/mahara/commit/718602a06560a21b0a6ebbcb5bcf54addb6ed67e
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.9_STABLE

commit 718602a06560a21b0a6ebbcb5bcf54addb6ed67e
Author: Aaron Wells <email address hidden>
Date: Wed Apr 30 15:56:21 2014 +1200

Removing unnecessary array_diff

Bug 1314460: No need to remove $locked from $progressbaritems, because the
list of progressbaritems is limited by the $onlytheseplugins array, and that
has already had $locked removed from it.

Change-Id: Ie8418703d0333eaf2ef2ba8301ec235e4dcddd03

Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.10.0 → none
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.