Mahara

Better way to fetch template for some json files

Bug #1321053 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Robert Lyon
Mahara 1.10.0

Bug Description

Some json files have:

ob_start();
$smarty->display('name/of/json.tpl');
$html = ob_get_contents();
ob_end_clean();

But this can be simplified to:

$html = $smarty->fetch('name/of/json.tpl');

So I'll do that in this patch.

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 1.10.0
assignee: nobody → Robert Lyon (robertl-9)
importance: Undecided → Low
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3372

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3372
Committed: http://gitorious.org/mahara/mahara/commit/274c7c2df625f3bd0bb62dbc0fe25a51ae18e374
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 274c7c2df625f3bd0bb62dbc0fe25a51ae18e374
Author: Robert Lyon <email address hidden>
Date: Tue May 20 12:38:18 2014 +1200

Fetch template html via some json files in a better way (Bug #1321053)

Change-Id: I13a7a9a95da0b46a6b29862e8ad14e3e66bbb4f6
Signed-off-by: Robert Lyon <email address hidden>

Aaron Wells (u-aaronw)
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.