feisty: metacity: inconsistent window maximize behavior

Binary package hint: metacity

New application windows pick up some partial notion of "maximized" by virtue of having been created with a maximal width or height. "maximized" is conceptually distinct from "at maximal width/height"--windows created with the latter attribute shouldn't assume the former.

Steps to recreate in the vertical using Firefox are described below. The problem is not restricted to Firefox (I can recreate with gedit), nor to the vertical (I can recreate in the horizontal as well).

To recreate:

- Open a new Firefox instance. Arrange that the new instance will open in a window that's smaller than maximum in both horizontal and vertical directions and is not adjacent to either panel or left or right screen edges.

- Move the initial Firefox window so the top of the window is adjacent to the top panel.

- Resize the Firefox window vertically so that the bottom of the window is adjacent to the bottom panel.

- Open a new Firefox window (ctrl-N).

- Note that the original window can be moved and resized both horizontally and vertically.

- Note that the new window can only be moved and resized horizontally, not vertically. Note that when the cursor approaches the top or bottom border of the new window, it changes to the resize cursor, but an attempt to resize does not work.

- Maximize the new window. Note that when maximized the cursor does not change to the resize cursor when it approaches a window border.

- Unmaximize the new window. Note that it can now be moved and resized both horizontally and vertically.

If the initial window is resized to maximal width _and_ height before the new window is created, then the new window is created fully maximized and cannot be moved or resized in either direction. The window can then be unmaximized; it will still be at maximal width and height, but can then be resized or moved in either direction.

Relevant package levels:

$ dpkg -l | grep -Ei 'metacity|firefox|gedit'
ii firefox 2.0.0.6+1-0ubuntu1 lightweight web browser based on Mozilla
ii firefox-gnome-support 2.0.0.6+1-0ubuntu1 Support for Gnome in Mozilla Firefox
ii gedit 2.18.1-0ubuntu1 light-weight text editor
ii gedit-common 2.18.1-0ubuntu1 light-weight text editor support files
ii libmetacity0 2.18.2-0ubuntu1.1 library of lightweight GTK2 based Window Man
ii libnspr4 1.firefox2.0.0.6+1-0ubuntu1 Netscape Portable Runtime Library
ii libnss3 1.firefox2.0.0.6+1-0ubuntu1 Network Security Service Libraries - runtime
ii metacity 2.18.2-0ubuntu1.1 A lightweight GTK2 based Window Manager
ii metacity-common 2.18.2-0ubuntu1.1 Shared files of lightweight GTK2 based Windo
ii mozilla-firefox-locale-en-gb 2.0.0.1ubuntu-1 Mozilla Firefox English language/region pack

I believe this is a metacity problem, and it looks to me like the culprit may be in meta_window_place(). The call-chain might be:

meta_window_new_with_attrs() -> meta_window_move_resize_internal() -> meta_window_constrain() -> place_window_if_needed() -> meta_window_place()

I suspect the following code:

  /* Maximize windows if they are too big for their work area (bit of
   * a hack here). Assume undecorated windows probably don't intend to
   * be maximized.
   */
  if (window->has_maximize_func && window->decorated &&
      !window->fullscreen)
    {
      MetaRectangle workarea;
      MetaRectangle outer;

      meta_window_get_work_area_for_xinerama (window,
                                              xineramas_list[placed_on],
                                              &workarea);
      meta_window_get_outer_rect (window, &outer);

      if (outer.width >= workarea.width)
        window->maximize_horizontally_after_placement = TRUE;

      if (outer.height >= workarea.height)
        window->maximize_vertically_after_placement = TRUE;
    }