Expose user agent as part of downloadRequest
Bug #1337369 reported by
Michael Sheldon
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Oxide |
Fix Released
|
High
|
Alexandre Abreu | ||
| webapps-sprint |
Fix Released
|
High
|
Alexandre Abreu | ||
Bug Description
To allow the correct user agent to be passed to download manager it would be useful to have the user agent provided as part of a download request. This then avoids the issue of the user agent provided via the WebContext not having user agent overrides taken into account.
Related branches
lp:~abreu-alexandre/oxide/add-ua-to-downloadrequested
- Chris Coulson: Approve
-
Diff: 650 lines (+256/-57)17 files modifiedpatches/add-suggested-filename-to-download-starting-resource-delegate.patch (+57/-0)
patches/series (+2/-1)
qt/core/api/oxideqdownloadrequest.cc (+17/-7)
qt/core/api/oxideqdownloadrequest.h (+3/-0)
qt/core/api/oxideqdownloadrequest_p.h (+3/-1)
qt/core/browser/oxide_qt_web_view.cc (+4/-2)
qt/core/browser/oxide_qt_web_view.h (+2/-1)
qt/tests/qmltests/api/tst_WebView_downloadRequested.qml (+41/-0)
qt/tests/qmltests/api/tst_WebView_downloadRequestedAnchor.html (+7/-0)
shared/browser/oxide_browser_context.cc (+11/-1)
shared/browser/oxide_resource_dispatcher_host_delegate.cc (+82/-28)
shared/browser/oxide_resource_dispatcher_host_delegate.h (+15/-11)
shared/browser/oxide_web_view.cc (+4/-2)
shared/browser/oxide_web_view.h (+2/-1)
shared/browser/oxide_web_view_client.cc (+2/-1)
shared/browser/oxide_web_view_client.h (+2/-1)
shared/shared.gyp (+2/-0)
| Changed in oxide: | |
| assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
| status: | New → In Progress |
| importance: | Undecided → High |
| Changed in oxide: | |
| milestone: | none → branch-1.6 |
| Changed in oxide: | |
| milestone: | branch-1.6 → branch-1.7 |
| Changed in oxide: | |
| milestone: | branch-1.7 → branch-1.8 |
| Changed in oxide: | |
| milestone: | branch-1.8 → branch-1.9 |
| Changed in webapps-sprint: | |
| milestone: | none → sprint-10 |
| assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
| importance: | Undecided → High |
| status: | New → In Progress |
| Changed in oxide: | |
| status: | In Progress → Fix Committed |
| Changed in webapps-sprint: | |
| status: | In Progress → Fix Committed |
| Changed in oxide: | |
| status: | Fix Committed → Fix Released |
| Changed in webapps-sprint: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
