Launchpad itself

Checkwatches script doesn't use correct DB user

Bug #134312 reported by Tom Haddon
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Tom Haddon

Bug Description

The checkwatches.py cronscript should use the "checkwatches" DB user, but it currently uses the default DB user from the launchpad.conf file in the specified LPCONFIG environment variable's directory.

Additionally, it seems like the permissions for checkwatches user needs updating. Running the checkwatches script while explicitly specifying the user I got the following error message:

"permission denied for relation packagebugcontact"

Tags: lp-bugs
Tom Haddon (mthaddon)
Changed in launchpad:
importance: Undecided → Critical
status: New → Confirmed
Revision history for this message
Stuart Bishop (stub) wrote :

I've manually granted the permission.

To close this bug we need to:
  - Add the correct permissions to database/schema/security.cfg.
    Remove the 'groups=write' line and explicitly list all required
    permissions.

  - Make checkwatches.py connect as the 'checkwatches' user.

  - Make the tests connect as the correct user.

Revision history for this message
Stuart Bishop (stub) wrote :

Targetting for 1.1.9 as the manual permission override will be reset next time security.py is run against the production database (next rollout).

Revision history for this message
Stuart Bishop (stub) wrote :

Also needs perms on MessageChunk, messagechunk_id_seq, bugnotification_id_seq, validpersonorteamcache, questionbug, questionbug_id_seq, question

Revision history for this message
Stuart Bishop (stub) wrote :

questionsubscription, answercontact too

Revision history for this message
Joey Stanford (joey) wrote :

demoting to high and moving to 1.1.10

Changed in launchpad:
importance: Critical → High
Björn Tillenius (bjornt)
Changed in malone:
assignee: nobody → bjornt
status: Confirmed → In Progress
Revision history for this message
Björn Tillenius (bjornt) wrote :

Fixed in RF 4986.

Changed in malone:
status: In Progress → Fix Committed
Joey Stanford (joey)
Changed in malone:
status: Fix Committed → Fix Released
Revision history for this message
Tom Haddon (mthaddon) wrote :

This isn't quite fix released, as nightly.sh has to be modified as well to actually begin using this new user. I have made this change and will confirm it works. If this is the case, I can commit a branch to RF that will codify this change, and then on the next release this will actually be fix released. I've targeted to 1.1.12 as this is likely when the changes to nightly.sh will land.

Changed in malone:
assignee: bjornt → mthaddon
milestone: 1.1.10 → 1.1.12
status: Fix Released → Fix Committed
Revision history for this message
Tom Haddon (mthaddon) wrote :

This is now in nightly.sh

Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.