Uploadcsv email addr and username cache
Bug #1364229 reported by
Nigel Cunningham
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mahara |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
We can speed the validation of email addresses and usernames by doing a single query for each of usernames, email addresses and internal email addresses prior to entering the validation loop.
Test runs with 2000 preexisting users using XHProf showed a reduction in execution time from 6.5 seconds to 3.8 seconds, with an increase in memory use of approximately 1.3MB.
| Changed in mahara: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Changed in mahara: | |
| status: | Confirmed → Fix Committed |
| milestone: | none → 15.04.0 |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A change has been merged | #1 |
| Changed in mahara: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/
Committed: http://
Submitter: Robert Lyon (<email address hidden>)
Branch: master
commit e5a0f676901c36d
Author: Nigel Cunningham <email address hidden>
Date: Mon Jul 28 12:03:08 2014 +1000
(Bug1364229) Upload CSV email addr and username cache optimisation.
This patch optimises the validation function by getting a list
of known email addresses and usernames prior to entering the
validation loop.
Test runs with 2000 preexisting users using XHProf showed a
reduction in execution time from 6.5 seconds to 3.8 seconds,
with an increase in memory use of approximately 1.3MB.
Change-Id: I099f1e3b7d4595
Signed-off-by: Nigel Cunningham <email address hidden>