Ubuntu Kylin

when I turn off online search option, it still display search results in Dash.

Bug #1370353 reported by shijing on 2014-09-17

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Ubuntu Kylin	Fix Released	High	shijing	Ubuntu Kylin vivid-alpha1
Trusty	Won't Fix	Medium	Unassigned	Ubuntu Kylin trusty-sru
Vivid	Fix Released	High	shijing	Ubuntu Kylin vivid-alpha1
unity-china-music-scope (Ubuntu)	Fix Released	High	shijing
Trusty	Fix Released	Medium	Anthony Wong	Ubuntu trusty-updates
Vivid	Fix Released	High	shijing
unity-china-photo-scope (Ubuntu)	Invalid	Undecided	Unassigned
Trusty	Invalid	Undecided	Unassigned
Vivid	Invalid	Undecided	Unassigned
unity-china-video-scope (Ubuntu)	Invalid	Undecided	Unassigned
Trusty	Invalid	Undecided	Unassigned
Vivid	Invalid	Undecided	Unassigned

Bug Description

SRU Justification
=================

[impact]
Without this patch, even users have turned off "include online search results", the scope will still do an online search. As we value privacy, we think it's good to backport this fix.

[test case]
1. press super-M, type an artist or song name, you should get online results from this scope.
2. go to settings > security & privacy > search, turn off "include online search results"
3. press super-M, type an artist or song name, you should NOT get any online results from this scope.

[regression potential]
minimal, the patch is used in vivid and tested in trusty.

---------
[original bug description]

OS: ubuntukylin 1404 & 1410
descibe:when I turn off online search option, it still display search results in Dash.
I turn off the option in system settings--safe and privacy.
detail in attachment.

See original description

Tags:

Related branches

lp:ubuntu/vivid-proposed/unity-china-music-scope

lp:~anthonywong/ubuntu/trusty/unity-china-music-scope/lp1370353

Merged into lp:ubuntu/trusty/unity-china-music-scope

Didier Roche-Tolomelli: Approve on 2015-01-22

lp:ubuntu/trusty-proposed/unity-china-music-scope

Revision history for this message

shijing (shijing) wrote on 2014-09-17:

online-dash.png Edit (473.3 KiB, image/png)

Revision history for this message

shijing (shijing) wrote on 2014-09-17:

Is the system-settings problem?

Changed in ubuntukylin:
milestone:	none → utopic-beta2

Revision history for this message

Anthony Wong (anthonywong) wrote on 2014-09-19:

This is the problem of the scopes themselves.

Please refer to bug 1054746 to see how to fix this problem. As an example, you can refer to the patch in https://code.launchpad.net/~didrocks/unity-lens-music/add-conditional-activation.

Revision history for this message

Anthony Wong (anthonywong) wrote on 2014-09-19:

@shijing
Does this problem also happen in the music and video scopes?

Revision history for this message

Ubuntu QA Website (ubuntuqa) wrote on 2014-09-19:

This bug has been reported on the Ubuntu ISO testing tracker.

A list of all reports related to this bug can be found here:
http://iso.qa.ubuntu.com/qatracker/reports/bugs/1370353

tags:

added: iso-testing

Revision history for this message

shijing (shijing) wrote on 2014-09-22:

@anthony
video and photo were not happend.

shijing (shijing) on 2014-09-22

Changed in ubuntukylin:
status:	New → Confirmed
Changed in unity-china-music-scope (Ubuntu):
status:	New → Confirmed
Changed in unity-china-photo-scope (Ubuntu):
status:	New → Invalid
Changed in unity-china-video-scope (Ubuntu):
status:	New → Invalid

Ma Jun (maclin.jun) on 2014-09-23

Changed in ubuntukylin:
assignee:	nobody → shijing (shijing)

Anthony Wong (anthonywong) on 2014-09-23

Changed in ubuntukylin:
importance:	Undecided → Medium
Changed in unity-china-music-scope (Ubuntu):
importance:	Undecided → Medium

Anthony Wong (anthonywong) on 2014-09-26

Changed in ubuntukylin:
milestone:	utopic-beta2 → utopic-final
importance:	Medium → High

Anthony Wong (anthonywong) on 2014-10-24

Changed in ubuntukylin:
milestone:	utopic-rc → vivid-alpha1
Changed in unity-china-music-scope (Ubuntu):
assignee:	nobody → shijing (shijing)
importance:	Medium → High

Revision history for this message

Jack Yu (jackyu) wrote on 2014-10-30:

bug 1054746 has been fixed.

Revision history for this message

shijing (shijing) wrote on 2014-12-12:

Being processed。。。

Revision history for this message

Eason (qulei) wrote on 2014-12-15:

This bug still exists in Vivid x32 Daily Build 20141214

Revision history for this message

jiaowen520li (jiaowen520li) wrote on 2014-12-15:

#10

This bug still exists in Vivid x64 Daily Build 20141214.

shijing (shijing) on 2014-12-17

Changed in unity-china-music-scope (Ubuntu):
status:	Confirmed → Fix Committed
Changed in ubuntukylin:
status:	Confirmed → Fix Committed

Revision history for this message

shijing (shijing) wrote on 2014-12-18:

#11

this bug fixed in trusty

Revision history for this message

Anthony Wong (anthonywong) wrote on 2014-12-18:

#12

shijing, do you really mean trusty? trusty is 14.04.

Revision history for this message

shijing (shijing) wrote on 2014-12-18:

#13

@anthony 1404 也存在这个问题，在LP上同时编译了trusty上的包，安装测试后，解决了，
在1504上也测试过，也解决了

Aron Xu (happyaron) on 2014-12-18

Changed in unity-china-photo-scope (Ubuntu Trusty):
status:	New → Invalid
Changed in unity-china-video-scope (Ubuntu Trusty):
status:	New → Invalid

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-12-18:

#14

This bug was fixed in the package unity-china-music-scope - 1.0.7-0ubuntu1

---------------
unity-china-music-scope (1.0.7-0ubuntu1) vivid; urgency=medium

* Make sure online search can be turned off (LP: #1370353)
-- Jing Shi <email address hidden> Thu, 18 Dec 2014 15:53:14 +0800

Changed in unity-china-music-scope (Ubuntu Vivid):
status:	Fix Committed → Fix Released

Anthony Wong (anthonywong) on 2014-12-18

Changed in unity-china-music-scope (Ubuntu Trusty):
importance:	Undecided → Medium
milestone:	none → trusty-updates

Revision history for this message

shijing (shijing) wrote on 2014-12-19:

#15

vivid alpha1 had fixed this problem.

Anthony Wong (anthonywong) on 2015-01-09

description:	updated
Changed in unity-china-music-scope (Ubuntu Trusty):
assignee:	nobody → Anthony Wong (anthonywong)
status:	New → Confirmed

Revision history for this message

Sebastien Bacher (seb128) wrote on 2015-01-30:

#16

the package has been uploaded, unsubscribing sponsors

Anthony Wong (anthonywong) on 2015-02-02

Changed in unity-china-music-scope (Ubuntu Trusty):
status:	Confirmed → In Progress

Revision history for this message

Chris J Arges (arges) wrote on 2015-02-04: Please test proposed package

#17

Hello shijing, or anyone else affected,

Accepted unity-china-music-scope into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/unity-china-music-scope/1.0.5-0ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in unity-china-music-scope (Ubuntu Trusty):
status:	In Progress → Fix Committed
tags:	added: verification-needed

Revision history for this message

Anthony Wong (anthonywong) wrote on 2015-02-05:

#18

Verified with 1.0.5-0ubuntu2, bug is fixed.

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-02-12:

#19

This bug was fixed in the package unity-china-music-scope - 1.0.5-0ubuntu2

---------------
unity-china-music-scope (1.0.5-0ubuntu2) trusty-proposed; urgency=medium

* Honour online search privacy setting. (LP: #1370353)
-- Anthony Wong <email address hidden> Fri, 09 Jan 2015 17:09:43 +0800

Changed in unity-china-music-scope (Ubuntu Trusty):
status:	Fix Committed → Fix Released

Revision history for this message

Adam Conrad (adconrad) wrote on 2015-02-12: Update Released

#20

The verification of the Stable Release Update for unity-china-music-scope has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.