Missing plugins not disabled cleanly.
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mahara |
Fix Released
|
Medium
|
Nigel Cunningham | ||
| 15.04 |
Fix Released
|
Medium
|
Nigel Cunningham | ||
Bug Description
While working on bug505732, I've found that having data but not files for a plugin results in the same errors described in bug629209 (Mahara: Site unavailable. A nonrecoverable error occured. This probably means you have encountered a bug in the system).
This is because the plugin isnot marked inactive when the safe_require fails, and later code doesn't check whether a plugin is active before attempting to again require and use the plugin.
With the patch that I intend to submit to Gerrit, the page is loaded as normal, with the missingplugindi
(Currently tested with the extensions page; I've seen that I need to make further changes to cover other cases where the plugin is also used without the active flag being checked).
| Aaron Wells (u-aaronw) wrote | #1 |
| Mahara Bot (dev-mahara) wrote A patch has been submitted for review | #2 |
| Nigel Cunningham (nigelc-g) wrote Re: [Bug 1373226] Re: Missing plugins not disabled cleanly. | #3 |
| Changed in mahara: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| milestone: | none → 1.10.0 |
| Changed in mahara: | |
| milestone: | 1.10.0 → 1.10.1 |
| no longer affects: | mahara/1.10 |
| Mahara Bot (dev-mahara) wrote A change has been merged | #4 |
| Changed in mahara: | |
| status: | Fix Committed → Fix Released |
This probably explains all the mysterious cases of "A nonrecoverable error occurred" that I've been having as I switch around between different gerrit patches lately, since we just added the "blocktype/text" plugin via db/upgrade.php.