Mahara

My groups block pagination fails when clean urls are in play

Bug #1374184 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
Mahara 1.10.0
1.10
Fix Released
High
Robert Lyon
Mahara 1.10.0
15.04
Fix Released
High
Robert Lyon
Mahara 15.04.0

Bug Description

Now that we can paginate the list of groups on the my groups block there is a problem when cleanurls are in place.

The pagination relies on scraping the url for the parameters to pass via ajax to fetch the subsequent pages.

but with clean urls the user id is not in the url so fails to go to next page.

To fix:

1) need to add a js variable to the page containing the user id number for the user whose profile page we are trying to view.
2) need to get the pagination js to add this id to the pagination params

Will mark this as a regression because before one could see all their groups in a long list - now they can only see the first page

Tags: regression
Robert Lyon (robertl-9)
no longer affects: mahara/trunk
Changed in mahara:
milestone: 1.10.0 → 1.11.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3726

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3726
Committed: http://gitorious.org/mahara/mahara/commit/3fb65b89c02e09f3947787fb28790de92a687ee3
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3fb65b89c02e09f3947787fb28790de92a687ee3
Author: Robert Lyon <email address hidden>
Date: Fri Sep 26 10:09:59 2014 +1200

Allowing the mygroups to paginate when cleanurls on (Bug #1374184)

To test:

1) Set up a few users all being members of many groups (I tested with 17
groups)

2) for each user edit their profile page and edit the 'My groups'
block and set the 'Maximum number of groups to display' value to
something less than the number of groups available
3) Then test if you can paginate on both logged-in users profile page and
other users profile pages

Test for both when clean urls are on and off

Change-Id: I26a247fc4a692b2e82b6c235d41172ff35fadeac
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/3766

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3766
Committed: http://gitorious.org/mahara/mahara/commit/2f85390b9487d184c9f783e13bda3e876bd3b43e
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit 2f85390b9487d184c9f783e13bda3e876bd3b43e
Author: Robert Lyon <email address hidden>
Date: Fri Sep 26 10:09:59 2014 +1200

Allowing the mygroups to paginate when cleanurls on (Bug #1374184)

To test:

1) Set up a few users all being members of many groups (I tested with 17
groups)

2) for each user edit their profile page and edit the 'My groups'
block and set the 'Maximum number of groups to display' value to
something less than the number of groups available
3) Then test if you can paginate on both logged-in users profile page and
other users profile pages

Test for both when clean urls are on and off

Change-Id: I26a247fc4a692b2e82b6c235d41172ff35fadeac
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.