revert listitem dividers to previous (no margins)
Bug #1380766 reported by
Jouni Helminen
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
Canonical Devices Products | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Zsombor Egri | ||
Vivid |
Fix Released
|
Undecided
|
Unassigned | ||
ubuntu-ui-toolkit (Ubuntu RTM) |
Fix Released
|
High
|
Zsombor Egri |
Bug Description
2gu margin was added to the left and right of listitem dividers.
However this is causing issues with a large number of apps. For RTM let's revert back to previous (no left/right margins on listitem dividers) and after that we can explore the issues again.
Related branches
lp:~zsombi/ubuntu-ui-toolkit/thindivider-margins
- PS Jenkins bot: Approve (continuous-integration)
- Tim Peeters: Approve
-
Diff: 86 lines (+51/-9)3 files modifiedmodules/Ubuntu/Components/ListItems/Empty.qml (+1/-5)
modules/Ubuntu/Components/ListItems/ThinDivider.qml (+4/-4)
tests/resources/listitems/Dividers.qml (+46/-0)
lp:~zsombi/ubuntu-ui-toolkit/header-divider
- PS Jenkins bot: Approve (continuous-integration)
- Tim Peeters: Approve
-
Diff: 12 lines (+0/-2)1 file modifiedmodules/Ubuntu/Components/ListItems/Header.qml (+0/-2)
lp:~zsombi/ubuntu-ui-toolkit/listitem-divider-rollback
- Tim Peeters: Approve
-
Diff: 99 lines (+51/-11)4 files modifiedmodules/Ubuntu/Components/ListItems/Empty.qml (+1/-5)
modules/Ubuntu/Components/ListItems/Header.qml (+0/-2)
modules/Ubuntu/Components/ListItems/ThinDivider.qml (+4/-4)
tests/resources/listitems/Dividers.qml (+46/-0)
tags: |
added: rtm14 removed: rtm |
Changed in ubuntu-ui-toolkit: | |
status: | New → Confirmed |
Changed in ubuntu-ui-toolkit: | |
importance: | Critical → High |
tags: | added: ota-1 |
Changed in ubuntu-ui-toolkit: | |
status: | In Progress → Fix Committed |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Zsombor Egri (zsombi) |
importance: | Undecided → High |
status: | New → In Progress |
no longer affects: | ubuntu-ui-toolkit |
Changed in canonical-devices-system-image: | |
assignee: | nobody → Canonical Devices Products (canonical-devices-products-team) |
importance: | Undecided → High |
milestone: | none → r1 |
status: | New → Confirmed |
Changed in ubuntu-ui-toolkit (Ubuntu RTM): | |
assignee: | nobody → Zsombor Egri (zsombi) |
importance: | Undecided → High |
status: | New → In Progress |
Changed in canonical-devices-system-image: | |
status: | Confirmed → Fix Released |
milestone: | ww51-2014 → ww03-2015 |
Changed in ubuntu-ui-toolkit (Ubuntu Vivid): | |
status: | New → Fix Released |
To post a comment you must log in.
please check with victorp or pmcgowan about the rtm14 tags.