revert listitem dividers to previous (no margins)

Bug #1380766 reported by Jouni Helminen
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Canonical Devices Products
ubuntu-ui-toolkit (Ubuntu)
Fix Released
High
Zsombor Egri
Vivid
Fix Released
Undecided
Unassigned
ubuntu-ui-toolkit (Ubuntu RTM)
Fix Released
High
Zsombor Egri

Bug Description

2gu margin was added to the left and right of listitem dividers.

However this is causing issues with a large number of apps. For RTM let's revert back to previous (no left/right margins on listitem dividers) and after that we can explore the issues again.

Tags: ota-1 rtm14

Related branches

Zsombor Egri (zsombi)
tags: added: rtm14
removed: rtm
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
status: New → Confirmed
Revision history for this message
Zoltan Balogh (bzoltan) wrote :

please check with victorp or pmcgowan about the rtm14 tags.

Revision history for this message
Joe Odukoya (jodukoya) wrote :

Hi - is it possible to get a couple of screenshots (before and after) so we all know what is being proposed here...

Many thanks.

Revision history for this message
Jouni Helminen (jounihelminen) wrote :

Joe - we tried adding side margins to listitem dividers for aesthetic reasons, but that created a bunch of visual inconsistencies with existing apps, so would like to roll back to previous.

Have a look at current system settings - some dividers are full width, edge to edge, and some not. Would like to roll back to previous version of listitem dividers they are all consistent, full width.

Revision history for this message
Omer Akram (om26er) wrote :

See the screenshot. With the proposed revert these divider lines will fill the width of the screen, making things look neat.

Changed in ubuntu-ui-toolkit:
importance: Critical → High
tags: added: ota-1
Revision history for this message
Niklas Wenzel (nikwen) wrote :

This might fix the issue for various existing apps. However, I feel it wouldn't make sense to revert it to the previous design now just to reintroduce the new one soon again. First of all, this would require avoidable work by developers who already adapted to the new design, secondly it would confuse users and thirdly, looking back at some screenshots with the old design, it looks really outdated in my opinion. Therefore, I vote for leaving the design as it is today.

Revision history for this message
Zsombor Egri (zsombi) wrote :

We checked with Jouni and decided to give 2 DP margin for both sides.

Changed in ubuntu-ui-toolkit:
status: Confirmed → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-ui-toolkit/staging at revision None, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

Changed in ubuntu-ui-toolkit:
status: In Progress → Fix Committed
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Hi ,

I just noticed that, we don't have way to play with ListeItem.Header ThinDivider line.
It just comes by default with margins , and not with the full width.
http://i.imgur.com/aoIsPq5.png

Changed in ubuntu-ui-toolkit:
status: Fix Committed → New
Revision history for this message
Zsombor Egri (zsombi) wrote :

This is not a new bug, this is a confirmed, and fixed bug, it's just we must land in RTM branches.

Changed in ubuntu-ui-toolkit:
status: New → In Progress
Zoltan Balogh (bzoltan)
Changed in ubuntu-ui-toolkit:
status: In Progress → Fix Committed
Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: nobody → Zsombor Egri (zsombi)
importance: Undecided → High
status: New → In Progress
Zoltan Balogh (bzoltan)
no longer affects: ubuntu-ui-toolkit
Olli Ries (ories)
Changed in canonical-devices-system-image:
assignee: nobody → Canonical Devices Products (canonical-devices-products-team)
importance: Undecided → High
milestone: none → r1
status: New → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1347+15.04.20141126-0ubuntu1

---------------
ubuntu-ui-toolkit (1.1.1347+15.04.20141126-0ubuntu1) vivid; urgency=medium

  [ Zsombor Egri ]
  * Expose refresh() function in revision 1 (Ubuntu.Components 1.1).
    Fixes LP: #1380559
  * Alarm adaptation refactored to support change granular model
    updates. Fixes LP: #1322558, LP: #1360359, LP: #1370649,
    LP: #1380553
  * Fix Header thin divider margins, restored to original no-margins.
    Fixes LP: #1380766.

  [ Tim Peeters ]
  * Add ensure_visible() function to header AP helper.
    Fixes LP: #1363591

  [ Albert Astals Cid ]
  * Add context support for i18n.tr calls. This allows to have strings
    like "All" translated to two different strings in the translated
    language if different contexts are given. Fixes LP: #1394904
 -- Ubuntu daily release <email address hidden> Wed, 26 Nov 2014 08:33:25 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Omer Akram (om26er) wrote :

Can we please land this in RTM ?

Revision history for this message
Zsombor Egri (zsombi) wrote :

Omer, as long as we get green light to land it, we will.

Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit (Ubuntu RTM):
assignee: nobody → Zsombor Egri (zsombi)
importance: Undecided → High
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1298+15.04.20150107~rtm-0ubuntu1

---------------
ubuntu-ui-toolkit (1.1.1298+15.04.20150107~rtm-0ubuntu1) 14.09; urgency=low

  [ Zsombor Egri ]
  * Rolling back ListItem dividers from 2GU left&right margins to no
    margins. (LP: #1380766)
 -- Ubuntu daily release <email address hidden> Wed, 07 Jan 2015 18:47:29 +0000

Changed in ubuntu-ui-toolkit (Ubuntu RTM):
status: In Progress → Fix Released
Changed in canonical-devices-system-image:
status: Confirmed → Fix Released
milestone: ww51-2014 → ww03-2015
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit (Ubuntu Vivid):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.