Mahara

Comments pagination is off by one

Bug #1384529 reported by Yuliya Bozhko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Yuliya Bozhko
Mahara 15.04.0
1.10
Fix Released
Low
Unassigned
Mahara 1.10.1
1.8
Fix Released
Low
Unassigned
Mahara 1.8.6
1.9
Fix Released
Low
Unassigned
Mahara 1.9.4
15.04
Fix Released
Low
Yuliya Bozhko
Mahara 15.04.0

Bug Description

When you view a page, if you pass showcomment=$commentid, it should set pagination to display the page of comments containing $commentid.

There seems to be an off by one error as at the boundaries it doesn't quite work.

If you try to show the first comment on a new page, it actually shows the previous page.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3861

Revision history for this message
Yuliya Bozhko (yuliya.bozhko) wrote :

To test:

1. Create a page.

2. Add 12 comments to the page.

3. When viewing the page add an extra parameter to the page URL:
             &showcomment=XXX
   where XXX is an ID of 11th comment.

4. Make sure that comments pagination shows the second page where this 11th comment actually is.

Changed in mahara:
importance: Undecided → Low
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3861
Committed: http://gitorious.org/mahara/mahara/commit/a63eb645ce6072420c42ad8ebdcbeb78b7360acf
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit a63eb645ce6072420c42ad8ebdcbeb78b7360acf
Author: Yuliya Bozhko <email address hidden>
Date: Thu Oct 23 16:00:19 2014 +1300

Fix for comments pagination with showcomment option (Bug #1384529)

Change-Id: If5991307ca8065c48f1309bcfc37f62df0dd12a5
Signed-off-by: Yuliya Bozhko <email address hidden>

Aaron Wells (u-aaronw)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "1.8_STABLE" branch: https://reviews.mahara.org/3863

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.9_STABLE" branch: https://reviews.mahara.org/3864

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/3865

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3863
Committed: http://gitorious.org/mahara/mahara/commit/c3b2c7708a49a67da879d2650b2bf91e71a10d8d
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.8_STABLE

commit c3b2c7708a49a67da879d2650b2bf91e71a10d8d
Author: Yuliya Bozhko <email address hidden>
Date: Thu Oct 23 16:00:19 2014 +1300

Fix for comments pagination with showcomment option (Bug #1384529)

Change-Id: If5991307ca8065c48f1309bcfc37f62df0dd12a5
Signed-off-by: Yuliya Bozhko <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/3864
Committed: http://gitorious.org/mahara/mahara/commit/24dfdf8f7b9dd10c53ded88c12c7f9ea54695226
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.9_STABLE

commit 24dfdf8f7b9dd10c53ded88c12c7f9ea54695226
Author: Yuliya Bozhko <email address hidden>
Date: Thu Oct 23 16:00:19 2014 +1300

Fix for comments pagination with showcomment option (Bug #1384529)

Change-Id: If5991307ca8065c48f1309bcfc37f62df0dd12a5
Signed-off-by: Yuliya Bozhko <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/3865
Committed: http://gitorious.org/mahara/mahara/commit/a702256f216df14060f30dcdc8b716118f86aee0
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.10_STABLE

commit a702256f216df14060f30dcdc8b716118f86aee0
Author: Yuliya Bozhko <email address hidden>
Date: Thu Oct 23 16:00:19 2014 +1300

Fix for comments pagination with showcomment option (Bug #1384529)

Change-Id: If5991307ca8065c48f1309bcfc37f62df0dd12a5
Signed-off-by: Yuliya Bozhko <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.