oslo.log

correct the position of the syslog Handler

Bug #1399088 reported by YangLei
26
This bug affects 3 people
Affects Status Importance Assigned to Milestone
oslo-incubator
Won't Fix
Medium
Simon Pasquier
oslo.log
Fix Released
Undecided
YangLei
oslo.log 0.1.0
cinder (Ubuntu)
Fix Released
Undecided
Unassigned
nova (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Nova SRU:
[Impact]

 * syslog handler doesn't have the same settings as other handlers

[Test Case]

 * Set user_syslog to True in nova.conf, restart nova services. Logs
   written to syslog doesn't have the same format as its own service
   log

[Regression Potential]

 * none

Cinder SRU:
[Impact]

 * syslog handler doesn't have the same settings as other handlers

[Test Case]

 * Set user_syslog to True in cinder.conf, restart cinder services. Logs
   written to syslog doesn't have the same format as its own service
   log

[Regression Potential]

 * none

See original description
YangLei (yanglyy)
Changed in oslo-incubator:
assignee: nobody → YangLei (yanglyy)
YangLei (yanglyy)
affects: oslo-incubator → oslo.log
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.log (master)

Fix proposed to branch: master
Review: https://review.openstack.org/138971

Changed in oslo.log:
status: New → In Progress
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

This change looks OK, but I'm not sure I understand what is broken right now. Can you give an example of a few of the options that are not supported because of the order of configuration for the logging handlers?

Changed in oslo.log:
status: In Progress → Incomplete
Revision history for this message
YangLei (yanglyy) wrote :

Here we need adjust the order of syslog handler.

Currently, the syslog handler loses the setting of
"handler.setFormatter(ContextFormatter(project=project,
                                                  version=version,
                                                  datefmt=datefmt))"
so the formatters betweent syslog handler and other handlers are different.
then the output messages are different:

example:
nova-api.log:
2014-12-05 10:23:16.869 28589 INFO nova.osapi_compute.wsgi.server [-] (28589) wsgi starting up on http://10.104.0.179:8774/

/var/log/messages:
(28589) wsgi starting up on http://10.104.0.179:8774/

OpenStack Infra (hudson-openstack)
Changed in oslo.log:
status: Incomplete → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.log (master)

Reviewed: https://review.openstack.org/138971
Committed: https://git.openstack.org/cgit/openstack/oslo.log/commit/?id=250315b7b22bf348af1f36965fdae6a38c9d5f57
Submitter: Jenkins
Branch: master

commit 250315b7b22bf348af1f36965fdae6a38c9d5f57
Author: YangLei <email address hidden>
Date: Sat Dec 20 15:59:47 2014 +0800

    Correct the position of the syslog handler

    Correct the position of the syslog handler,
    then the syslog handler can have same settings with
    other handlers.

    Change-Id: I15163f1dd12713c71d42efdb128f8d12ec5dc307
    Closes-Bug: #1399088

Changed in oslo.log:
status: In Progress → Fix Committed
Doug Hellmann (doug-hellmann)
Changed in oslo.log:
milestone: none → 0.1.0
status: Fix Committed → Fix Released
Revision history for this message
Simon Pasquier (simon-pasquier) wrote :

Fix proposed to oslo-incubator. Review: https://review.openstack.org/#/c/151157/

Simon Pasquier (simon-pasquier)
Changed in oslo-incubator:
assignee: nobody → Simon Pasquier (simon-pasquier)
Revision history for this message
Ben Nemec (bnemec) wrote :

The change to remove the oslo log code from incubator has already merged, so I'm going to mark this invalid there. Let me know if a backport is needed though.

Changed in oslo-incubator:
status: New → Won't Fix
Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

It would be nice to have backports for I and J

Revision history for this message
Simon Pasquier (simon-pasquier) wrote :

+ for the backport, AFAICT only Juno is affected.

Revision history for this message
Simon Pasquier (simon-pasquier) wrote :

@Ben
I can send a patch for stable/juno. Is it ok for you?

Revision history for this message
Ben Nemec (bnemec) wrote :

Yeah, works for me. I've reopened the bug against incubator.

Changed in oslo-incubator:
status: Won't Fix → Triaged
importance: Undecided → Medium
Revision history for this message
Simon Pasquier (simon-pasquier) wrote :

@Ben
Fix proposed: https://review.openstack.org/#/c/152438/
BTW, what is the incentive (if any) for OpenStack projects to migrate to oslo.log in the Kilo timeframe? Is it a 'must' or a 'should'?

Changed in oslo-incubator:
status: Triaged → In Progress
Liang Chen (cbjchen)
description: updated
Liang Chen (cbjchen)
description: updated
description: updated
Edward Hope-Morley (hopem)
description: updated
Davanum Srinivas (DIMS) (dims-v)
Changed in oslo-incubator:
status: In Progress → Won't Fix
Revision history for this message
James Page (james-page) wrote :

Marking both Ubuntu tasks as Fix Released; this did not impact Icehouse (14.04) and the oldest supported UCA is now Kilo, which should be just fine with the oslo.log version it has.

Changed in nova (Ubuntu):
status: New → Fix Released
Changed in cinder (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.