virtualbox-guest-dkms 4.1.12-dfsg-2ubuntu0.7: virtualbox-guest kernel module failed to build

Hi Benedikt, I uploaded a patch in my ppa:
https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/locutusofborg-ppa/

can you please wait for the build and test it? thanks!

I just verified that in current vivid the module builds fine against 3.18.0-8-generic, so closing vivid task.

Thanks! Uploaded to precise SRU queue, SRU team now needs to review/accept into -proposed.

Unsubscribing sponsors now.

Rejected on LocutusOfBorg's request, this needs another fix. Please re-subscribe ubuntu-sponsors when ready.

Attaching a working patch

I'm trying to trim down the patch to a more minimal one

BTW the patch is an cherry-pick of upstream commits here
http://anonscm.debian.org/cgit/pkg-virtualbox/virtualbox.git/log/src/VBox/Additions/linux/drm/vboxvideo_drm.c

Stripped down the debdiff as much as possible and tested.

working correctly.

patches are in costamagnagianfranco/locutusofborg-ppa (the first)
and costamagnagianfranco/costamagnagianfranco-ppa (the second)

This gets removed unconditionally:

+- .fasync = drm_fasync,

So this isn't necessary for 3.2 either? It might still build, but it might incur some performance degradation?

I don't know, I tested with 3.2 and it builds.

You can add a conditional kernel define if you want ;)

LocutusOfBorg [2015-01-12 9:41 -0000]:
> I don't know, I tested with 3.2 and it builds.

Builds for sure, I was wondering if it still works, and why this
code removal isn't conditional?

Thanks,

Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)

I think because it is really older than 3.2...
usually upstream ifdefs if something is still worth the old code.

I see usually they seem to support also 2.6 (I saw many 2.6.x defines in the code IIRC), so I presume that workaround it was wrong or too old to be useful now.

said this, I blindly follow upstream's ifdefs when a new kernel is released, so if you want to diverge from upstream it is up to you ;)

Uploaded again, thank you! Unsub'ing sponsors.

BTW linking there the upstream commit, just for future reference
https://www.virtualbox.org/changeset/48422/vbox/trunk/src/VBox/Additions/linux/drm/vboxvideo_drm.c

Hello Benedikt, or anyone else affected,

Accepted virtualbox into precise-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/virtualbox/4.1.12-dfsg-2ubuntu0.8 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

I just removed and purged all the virtualbox stuff in my preecise VM, and installed from proposed.

Everything has been built correctly, no build failures.

The verification of the Stable Release Update for virtualbox has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package virtualbox - 4.1.12-dfsg-2ubuntu0.8

---------------
virtualbox (4.1.12-dfsg-2ubuntu0.8) precise; urgency=medium

  * Add support for Virtualbox host kernel modules on Linux 3.5
    (LP: #1408939).
 -- Gianfranco Costamagna <email address hidden> Fri, 09 Jan 2015 11:48:31 +0100