Ubuntu
puppet package

wrong process name match in logrotate script

Bug #1410383 reported by Bartosz Cisek
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet (Debian)
Fix Released
Unknown
puppet (Ubuntu)
Fix Released
High
Unassigned
Trusty
Fix Released
High
Unassigned

Bug Description

Logrotate scrpit supplied by puppetmaster package tries to send signal after rotating logs. Unfortunately it matches against process name that doesn't exists. As a result puppet master process doesn't release log file descriptor that grows infinitely.

There is:
    pkill -USR2 -u puppet -f puppetmasterd || true

While it should be:
    pkill -USR2 -u puppet -f "puppet master" || true

Description: Ubuntu 14.04.1 LTS
Release: 14.04

puppetmaster:
  Installed: 3.4.3-1
  Candidate: 3.4.3-1
  Version table:
 *** 3.4.3-1 0
        500 http://archive.ubuntu.com/ubuntu/ trusty/main amd64 Packages
        100 /var/lib/dpkg/status

Related branches

lp:~bartoszcisek/ubuntu/trusty/puppet/bug-1410383
Marc Deslauriers: Approve
Diff: 25 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
debian/puppetmaster.logrotate (+1/-1)
lp:~bartoszcisek/ubuntu/vivid/puppet/bug-1410383
Marc Deslauriers: Approve
Diff: 25 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
debian/puppetmaster.logrotate (+1/-1)
lp:ubuntu/vivid-proposed/puppet
lp:ubuntu/trusty-proposed/puppet
Bartosz Cisek (bartoszcisek)
tags: added: patch
Mathieu Trudel-Lapierre (cyphermox)
Changed in puppetmaster (Ubuntu):
importance: Undecided → High
status: New → Triaged
Marc Deslauriers (mdeslaur)
affects: puppetmaster (Ubuntu) → puppet (Ubuntu)
Revision history for this message
Brian Murray (brian-murray) wrote :

It'd be good to forward this to Debian as they are also affected. A cursory inspection of bug reports about puppet didn't reveal one with the same issue.

Changed in puppet (Ubuntu Trusty):
importance: Undecided → High
status: New → Triaged
tags: added: trusty vivid
Revision history for this message
Bartosz Cisek (bartoszcisek) wrote :

I reported this to Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=780847

Bug Watch Updater (bug-watch-updater)
Changed in puppet (Debian):
status: Unknown → New
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Looks good. Uploaded to Trusty for processing by the SRU team

Thanks!

Changed in puppet (Ubuntu):
status: Triaged → Fix Committed
Changed in puppet (Ubuntu Trusty):
status: Triaged → In Progress
Revision history for this message
Adam Conrad (adconrad) wrote : Please test proposed package

Hello Bartosz, or anyone else affected,

Accepted puppet into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/puppet/3.4.3-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in puppet (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package puppet - 3.7.2-1ubuntu2

---------------
puppet (3.7.2-1ubuntu2) vivid; urgency=medium

  * fix wrong process name match in logrotate script (LP: #1410383)
 -- Bartosz Cisek <email address hidden> Fri, 20 Mar 2015 15:56:13 +0100

Changed in puppet (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Bartosz Cisek (bartoszcisek) wrote :

I can confirm that after rotating logs puppetmaster receives SIGUSR2.

Brian Murray (brian-murray)
tags: added: verification-done
removed: verification-needed vivid
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package puppet - 3.4.3-1ubuntu1.1

---------------
puppet (3.4.3-1ubuntu1.1) trusty; urgency=medium

  * fix wrong process name match in logrotate script (LP: #1410383)
 -- Bartosz Cisek <email address hidden> Fri, 06 Feb 2015 14:48:16 +0100

Changed in puppet (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for puppet has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Bug Watch Updater (bug-watch-updater)
Changed in puppet (Debian):
status: New → Fix Committed
Bug Watch Updater (bug-watch-updater)
Changed in puppet (Debian):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.