Allow Observers to show building spaces

Ok, observers can now see building spaces as well (from all players)
It is probably good to test/review the branch before merging

I compiled it, and it works and it is great.

Would it make sense to show bulding spaces also on unowned territory? As in editor. What do you think?

> Am 12.02.2015 um 13:41 schrieb TiborB <email address hidden>:
>
> I compiled it, and it works and it is great.
>
> Would it make sense to show bulding spaces also on unowned territory?
> As in editor. What do you think?

Interesting question. It boils down to: should the observer have information that none of the players have or should the information of the observer be at most (and ideally) be the Union of the information of all players.

I'd say that requires a bit more discussion in a new bug). Right now we build more towards the second, commercial game clearly go towards the first.

I think this should be merged first and the rest discussed in a bug. I did not review this (on the phone right now) so no comment about readiness for merging right now from me :). Could you send a merge proposal?

>
> --
> You received this bug notification because you are subscribed to
> widelands.
> https://bugs.launchpad.net/bugs/1419537
>
> Title:
> Allow Observers to show building spaces
>
> Status in Widelands:
> Confirmed
>
> Bug description:
> As it says on the tin ;)
>
> Observers should see all player's building spaces when hitting the
> space bar.
>
> https://wl.widelands.org/forum/topic/1646/
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/widelands/+bug/1419537/+subscriptions

Merged in r7404.

Fixed in build19-rc1.