Bug #1422359 “heimdal-kdc: kdc process leaks memory” : Bugs : heimdal package : Ubuntu

Revision history for this message

Patrik Lundin (patrik-lundin) wrote on 2015-02-16:

#1

heimdal-1.6~git20131207+dfsg-1ubuntu2 Edit (1.9 KiB, text/plain)

Below is a patch that attempts to fix the same issue that was reported to Debian. I have only build-tested the diff.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-02-16:

#2

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in heimdal (Ubuntu):
status:	New → Confirmed

Revision history for this message

Ubuntu Foundations Team Bug Bot (crichton) wrote on 2015-02-16:

#3

The attachment "heimdal-1.6~git20131207+dfsg-1ubuntu2" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags:

added: patch

Revision history for this message

Daniel Holbach (dholbach) wrote on 2015-02-19:

#4

This is fixed in vivid.

Changed in heimdal (Ubuntu):
status:	Confirmed → Fix Released

Bug Watch Updater (bug-watch-updater) on 2015-02-19

Changed in heimdal (Debian):
status:	Unknown → Fix Released

Revision history for this message

Patrik Lundin (patrik-lundin) wrote on 2015-02-26:

#5

I would appreciate if someone could take a look at the affected LTS distributions.

Revision history for this message

Brian Murray (brian-murray) wrote on 2015-03-02:

#6

The Stable Release Updates team will want to see the description of the bug updated for the SRU process, in particular to see a test case. http://wiki.ubuntu.com/StableReleaseUpdates

Thanks for working on this and the patch looks good!

Revision history for this message

Patrik Lundin (patrik-lundin) wrote on 2015-03-03:

#7

Thanks for the pointer Brian, see SRU format below:

[Impact]

* Effects of the bug on users
The kdc process leaks memory which means the users will need to restart the service when enough time has passed.

* Justification for backporting the fix to the stable release
The kdc is a long lived process, which means this leak will eventually be hit by anyone. I would not regard the current package as "stable".

* Explanation of how the upload fixes this bug
https://github.com/heimdal/heimdal/issues/93

[Test Case]

* Install heimdal-kdc package

* Modify /etc/krb5.conf so you use the same machine for AS-REQ:
---
[realms]
        YOUR.REALM = {
                kdc = your-local-machine.tld
        }
---

* Add "test" user with password "test"
kadmin -l --use-defaults test
<email address hidden>'s Password:
Verify password - <email address hidden>'s Password:

* Note how much RAM is currently being used by the kdc process:
---
# ps auxww | grep kdc | grep -v grep
root 832 0.0 0.1 79948 2768 ? S 09:22 0:00 /usr/lib/heimdal-servers/kdc --config-file=/etc/heimdal-kdc/kdc.conf
---

* Perform a bunch of requests against it:
---
# for request in {1..20000}; do echo test | kinit --password-file=STDIN <email address hidden>; done
---

* Note how much RAM is used after the test has been completed:
# ps auxww | grep kdc | grep -v grep
root 832 2.1 0.4 85660 9104 ? S 09:22 0:27 /usr/lib/heimdal-servers/kdc --config-file=/etc/heimdal-kdc/kdc.conf
---

* Install the new packages

* Reboot the machine

* Get a fresh RAM measurement:
---
# ps auxww | grep kdc | grep -v grep
root 864 0.0 0.1 79948 2764 ? S 11:01 0:00 /usr/lib/heimdal-servers/kdc --config-file=/etc/heimdal-kdc/kdc.conf
---

* Run test again
---
# for request in {1..20000}; do echo test | kinit --password-file=STDIN <email address hidden>; done
---

* Note that much less memory is used now:
---
# ps auxww | grep kdc | grep -v grep
root 864 1.8 0.1 79948 3468 ? S 11:01 0:27 /usr/lib/heimdal-servers/kdc --config-file=/etc/heimdal-kdc/kdc.conf
---

Thanks for the pointer Brian, see SRU format below:

[Impact]

* Effects of the bug on users
The kdc process leaks memory which means the users will need to restart the service when enough time has passed.

* Justification for backporting the fix to the stable release
The kdc is a long lived process, which means this leak will eventually be hit by anyone. I would not regard the current package as "stable".

* Explanation of how the upload fixes this bug
https://github.com/heimdal/heimdal/issues/93

[Test Case]

* Install heimdal-kdc package

* Modify /etc/krb5.conf so you use the same machine for AS-REQ:
---
[realms]
        YOUR.REALM = {
                kdc = your-local-machine.tld
        }
---

* Add "test" user with password "test"
kadmin -l --use-defaults test
test@YOUR.REALM's Password: 
Verify password - test@YOUR.REALM's Password:

* Note how much RAM is currently being used by the kdc process:
---
# ps auxww | grep kdc | grep -v grep
root       832  0.0  0.1  79948  2768 ?        S    09:22   0:00 /usr/lib/heimdal-servers/kdc --config-file=/etc/heimdal-kdc/kdc.conf
---

* Perform a bunch of requests against it:
---
# for request in {1..20000}; do echo test | kinit --password-file=STDIN test@YOUR.REALM; done
---

* Note how much RAM is used after the test has been completed:
# ps auxww | grep kdc | grep -v grep
root       832  2.1  0.4  85660  9104 ?        S    09:22   0:27 /usr/lib/heimdal-servers/kdc --config-file=/etc/heimdal-kdc/kdc.conf
---

* Install the new packages

* Reboot the machine

* Get a fresh RAM measurement:
---
# ps auxww | grep kdc | grep -v grep
root       864  0.0  0.1  79948  2764 ?        S    11:01   0:00 /usr/lib/heimdal-servers/kdc --config-file=/etc/heimdal-kdc/kdc.conf
---

* Run test again
---
# for request in {1..20000}; do echo test | kinit --password-file=STDIN test@YOUR.REALM; done
---

* Note that much less memory is used now:
---
# ps auxww | grep kdc | grep -v grep
root       864  1.8  0.1  79948  3468 ?        S    11:01   0:27 /usr/lib/heimdal-servers/kdc --config-file=/etc/heimdal-kdc/kdc.conf
---

Revision history for this message

Patrik Lundin (patrik-lundin) wrote on 2015-03-03:

#10

Thanks for the pointer Brian, see SRU format below:

[Impact]

* Effects of the bug on users
The kdc process leaks memory which means the users will need to restart the service when enough time has passed.

* Justification for backporting the fix to the stable release
The kdc is a long lived process, which means this leak will eventually be hit by anyone. I would not regard the current package as "stable".

* Explanation of how the upload fixes this bug
https://github.com/heimdal/heimdal/issues/93

[Test Case]

* Install heimdal-kdc package

* Modify /etc/krb5.conf so you use the same machine for AS-REQ:
---
[realms]
        YOUR.REALM = {
                kdc = your-local-machine.tld
        }
---

* Add a user with name "test" and password "test"
---
# kadmin -l --use-defaults test
<email address hidden>'s Password:
Verify password - <email address hidden>'s Password:
#
---

* Note how much RAM is currently being used by the kdc process:
---
# ps auxww | grep kdc | grep -v grep
root 832 0.0 0.1 79948 2768 ? S 09:22 0:00 /usr/lib/heimdal-servers/kdc --config-file=/etc/heimdal-kdc/kdc.conf
---

* Perform a bunch of requests against it:
---
# for request in {1..20000}; do echo test | kinit --password-file=STDIN <email address hidden>; done
---

* Note how much RAM is used after the test has been completed:
# ps auxww | grep kdc | grep -v grep
root 832 2.1 0.4 85660 9104 ? S 09:22 0:27 /usr/lib/heimdal-servers/kdc --config-file=/etc/heimdal-kdc/kdc.conf
---

* Install the new packages

* Reboot the machine

* Get a fresh RAM measurement:
---
# ps auxww | grep kdc | grep -v grep
root 864 0.0 0.1 79948 2764 ? S 11:01 0:00 /usr/lib/heimdal-servers/kdc --config-file=/etc/heimdal-kdc/kdc.conf
---

* Run test again
---
# for request in {1..20000}; do echo test | kinit --password-file=STDIN <email address hidden>; done
---

* Note that much less memory is used now:
---
# ps auxww | grep kdc | grep -v grep
root 864 1.8 0.1 79948 3468 ? S 11:01 0:27 /usr/lib/heimdal-servers/kdc --config-file=/etc/heimdal-kdc/kdc.conf
---

Thanks for the pointer Brian, see SRU format below:

[Impact]

* Effects of the bug on users
The kdc process leaks memory which means the users will need to restart the service when enough time has passed.

* Justification for backporting the fix to the stable release
The kdc is a long lived process, which means this leak will eventually be hit by anyone. I would not regard the current package as "stable".

* Explanation of how the upload fixes this bug 
https://github.com/heimdal/heimdal/issues/93

[Test Case]

* Install heimdal-kdc package

* Modify /etc/krb5.conf so you use the same machine for AS-REQ:
---
[realms]
        YOUR.REALM = { 
                kdc = your-local-machine.tld
        }   
---

* Add a user with name "test" and password "test"
---
# kadmin -l --use-defaults test
test@YOUR.REALM's Password: 
Verify password - test@YOUR.REALM's Password:
#
---

* Note how much RAM is currently being used by the kdc process:
---
# ps auxww | grep kdc | grep -v grep
root       832  0.0  0.1  79948  2768 ?        S    09:22   0:00 /usr/lib/heimdal-servers/kdc --config-file=/etc/heimdal-kdc/kdc.conf
---

* Perform a bunch of requests against it: 
---
# for request in {1..20000}; do echo test | kinit --password-file=STDIN test@YOUR.REALM; done
---

* Note how much RAM is used after the test has been completed:
# ps auxww | grep kdc | grep -v grep
root       832  2.1  0.4  85660  9104 ?        S    09:22   0:27 /usr/lib/heimdal-servers/kdc --config-file=/etc/heimdal-kdc/kdc.conf
---

* Install the new packages

* Reboot the machine

* Get a fresh RAM measurement:
---
# ps auxww | grep kdc | grep -v grep
root       864  0.0  0.1  79948  2764 ?        S    11:01   0:00 /usr/lib/heimdal-servers/kdc --config-file=/etc/heimdal-kdc/kdc.conf
---

* Run test again
---
# for request in {1..20000}; do echo test | kinit --password-file=STDIN test@YOUR.REALM; done
---

* Note that much less memory is used now:
---
# ps auxww | grep kdc | grep -v grep
root       864  1.8  0.1  79948  3468 ?        S    11:01   0:27 /usr/lib/heimdal-servers/kdc --config-file=/etc/heimdal-kdc/kdc.conf
---

Revision history for this message

Patrik Lundin (patrik-lundin) wrote on 2015-03-03:

#11

Sorry for the double-post, launchpad threw an error the first few times i tried submitting it.

Brian Murray (brian-murray) on 2015-03-03

Changed in heimdal (Ubuntu Trusty):
status:	New → In Progress
Changed in heimdal (Ubuntu Utopic):
assignee:	nobody → Brian Murray (brian-murray)
Changed in heimdal (Ubuntu Trusty):
assignee:	nobody → Brian Murray (brian-murray)
Changed in heimdal (Ubuntu Utopic):
status:	New → In Progress
Changed in heimdal (Ubuntu Trusty):
importance:	Undecided → High
Changed in heimdal (Ubuntu Utopic):
importance:	Undecided → High

Revision history for this message

Brian Murray (brian-murray) wrote on 2015-03-03:

#12

I've uploaded the debdif for Trusty, do you want to create one for Utopic also or shall I?

Revision history for this message

Patrik Lundin (patrik-lundin) wrote on 2015-03-04:

#13

If you could handle Utopic that would be great, I do not have the infrastructure in place to work on it right now.

Revision history for this message

Brian Murray (brian-murray) wrote on 2015-03-04: Please test proposed package

#14

Hello Patrik, or anyone else affected,

Accepted heimdal into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/heimdal/1.6~git20131207+dfsg-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in heimdal (Ubuntu Trusty):
status:	In Progress → Fix Committed
tags:	added: verification-needed

Brian Murray (brian-murray) on 2015-03-05

description:

updated

Revision history for this message

Brian Murray (brian-murray) wrote on 2015-03-05:

#15

I've also uploaded this to the Utopic queue.

Revision history for this message

Timo Aaltonen (tjaalton) wrote on 2015-03-06:

#16

Hello Patrik, or anyone else affected,

Accepted heimdal into utopic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/heimdal/1.6~rc2+dfsg-8ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in heimdal (Ubuntu Utopic):
status:	In Progress → Fix Committed

Revision history for this message

Patrik Lundin (patrik-lundin) wrote on 2015-03-16:

#17

I have now installed the following packages on Trusty (by asking for heimdal-kdc):

Do you want to continue? [Y/n]
Get:1 http://se.archive.ubuntu.com/ubuntu/ trusty/main krb5-config all 2.3 [23.4 kB]
Get:2 http://archive.ubuntu.com/ubuntu/ trusty-proposed/main libhdb9-heimdal amd64 1.6~git20131207+dfsg-1ubuntu1.1 [59.2 kB]
Get:3 http://se.archive.ubuntu.com/ubuntu/ trusty/main libfile-copy-recursive-perl all 0.38-1 [20.6 kB]
Get:4 http://se.archive.ubuntu.com/ubuntu/ trusty/main update-inetd all 4.43 [19.2 kB]
Get:5 http://se.archive.ubuntu.com/ubuntu/ trusty/main openbsd-inetd amd64 0.20091229-2ubuntu3 [30.8 kB]
Get:6 http://archive.ubuntu.com/ubuntu/ trusty-proposed/main libkadm5clnt7-heimdal amd64 1.6~git20131207+dfsg-1ubuntu1.1 [18.5 kB]
Get:7 http://archive.ubuntu.com/ubuntu/ trusty-proposed/main libkadm5srv8-heimdal amd64 1.6~git20131207+dfsg-1ubuntu1.1 [28.8 kB]
Get:8 http://archive.ubuntu.com/ubuntu/ trusty-proposed/main libkafs0-heimdal amd64 1.6~git20131207+dfsg-1ubuntu1.1 [15.1 kB]
Get:9 http://archive.ubuntu.com/ubuntu/ trusty-proposed/main libkdc2-heimdal amd64 1.6~git20131207+dfsg-1ubuntu1.1 [52.8 kB]
Get:10 http://archive.ubuntu.com/ubuntu/ trusty-proposed/main libotp0-heimdal amd64 1.6~git20131207+dfsg-1ubuntu1.1 [29.8 kB]
Get:11 http://archive.ubuntu.com/ubuntu/ trusty-proposed/main libsl0-heimdal amd64 1.6~git20131207+dfsg-1ubuntu1.1 [13.3 kB]
Get:12 http://archive.ubuntu.com/ubuntu/ trusty-proposed/universe heimdal-clients amd64 1.6~git20131207+dfsg-1ubuntu1.1 [264 kB]
Get:13 http://archive.ubuntu.com/ubuntu/ trusty-proposed/universe heimdal-kdc amd64 1.6~git20131207+dfsg-1ubuntu1.1 [91.9 kB]
Fetched 667 kB in 2s (284 kB/s)

I can confirm these packages fix the leak on Trusty.

tags:

added: verification-done

Revision history for this message

Patrik Lundin (patrik-lundin) wrote on 2015-03-16:

#18

I added the verification-done tag. I did not remove the verification-needed tag because I have no looked at Utopic.

Mathew Hodson (mhodson) on 2015-03-17

tags:

added: verification-done-trusty verification-needed-utopic
removed: verification-done verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-03-17:

#19

This bug was fixed in the package heimdal - 1.6~git20131207+dfsg-1ubuntu1.1

---------------
heimdal (1.6~git20131207+dfsg-1ubuntu1.1) trusty; urgency=medium

* Add 048_kdc_memleak patch based on Debian bug #746486. LP: #1422359
-- Patrik Lundin <email address hidden> Tue, 03 Mar 2015 08:16:15 -0800

Changed in heimdal (Ubuntu Trusty):
status:	Fix Committed → Fix Released

Revision history for this message

Chris Halse Rogers (raof) wrote on 2015-03-17: Update Released

#20

The verification of the Stable Release Update for heimdal has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message

Ubuntu Foundations Team Bug Bot (crichton) wrote on 2015-06-16: [heimdal/utopic] verification still needed

#21

The fix for this bug has been awaiting testing feedback in the -proposed repository for utopic for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

tags:

added: removal-candidate

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-07-09:

#22

This bug was fixed in the package heimdal - 1.6~rc2+dfsg-8ubuntu1

---------------
heimdal (1.6~rc2+dfsg-8ubuntu1) utopic; urgency=medium

* Add 051_kdc_memleak patch based on Debian bug #746486. LP: #1422359
-- Patrik Lundin <email address hidden> Wed, 04 Mar 2015 16:16:19 -0800

Changed in heimdal (Ubuntu Utopic):
status:	Fix Committed → Fix Released

Ubuntu
heimdal package

heimdal-kdc: kdc process leaks memory

Bug Description

Related branches

Other bug subscribers

Patches

Remote bug watches

	Status	Importance	Assigned to
heimdal (Debian)	Fix Released	Unknown	debbugs #746486
heimdal (Ubuntu)	Fix Released	Undecided	Unassigned
Trusty	Fix Released	High	Brian Murray
Utopic	Fix Released	High	Brian Murray

Ubuntuheimdal package

heimdal-kdc: kdc process leaks memory

Bug Description

Related branches

Other bug subscribers

Patches

Remote bug watches

Ubuntu
heimdal package